mirror of
https://github.com/odin-lang/Odin.git
synced 2026-01-10 15:03:22 +00:00
Merge pull request #3544 from ntn9995/fix-parser-empty-or-no-pkg
Fix core:odin/parser crashing on empty and/or no package files
This commit is contained in:
@@ -6,6 +6,7 @@ import "core:path/filepath"
|
||||
import "core:fmt"
|
||||
import "core:os"
|
||||
import "core:slice"
|
||||
import "core:strings"
|
||||
|
||||
collect_package :: proc(path: string) -> (pkg: ^ast.Package, success: bool) {
|
||||
NO_POS :: tokenizer.Pos{}
|
||||
@@ -32,11 +33,18 @@ collect_package :: proc(path: string) -> (pkg: ^ast.Package, success: bool) {
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
|
||||
src, ok = os.read_entire_file(fullpath)
|
||||
if !ok {
|
||||
delete(fullpath)
|
||||
return
|
||||
}
|
||||
if strings.trim_space(string(src)) == "" {
|
||||
delete(fullpath)
|
||||
delete(src)
|
||||
continue
|
||||
}
|
||||
|
||||
file := ast.new(ast.File, NO_POS, NO_POS)
|
||||
file.pkg = pkg
|
||||
file.src = string(src)
|
||||
@@ -69,7 +77,9 @@ parse_package :: proc(pkg: ^ast.Package, p: ^Parser = nil) -> bool {
|
||||
if !parse_file(p, file) {
|
||||
ok = false
|
||||
}
|
||||
if pkg.name == "" {
|
||||
if file.pkg_decl == nil {
|
||||
error(p, p.curr_tok.pos, "Expected a package declaration at the start of the file")
|
||||
} else if pkg.name == "" {
|
||||
pkg.name = file.pkg_decl.name
|
||||
} else if pkg.name != file.pkg_decl.name {
|
||||
error(p, file.pkg_decl.pos, "different package name, expected '%s', got '%s'", pkg.name, file.pkg_decl.name)
|
||||
|
||||
Reference in New Issue
Block a user