mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-08-26 06:51:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7390 from kalsprite/selfref_bitfield_hang

Browse Source 
a self-referential bit_field hangs the compiler
This commit is contained in:
Jeroen van Rijn
2026-08-19 22:55:34 +02:00
committed by GitHub
parent 43d44e5942 389416c3ef
commit bd1a2dc7f0
1 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/types.cpp
View File

@@ -983,9 +983,12 @@ gb_internal Type *base_enum_type(Type *t) {
}
gb_internal Type *core_type(Type *t) {
for (;;) {
// each step strictly unwraps one layer; this only bounds a cycle
enum { CORE_TYPE_MAX_DEPTH = 1024 };
for (isize depth = 0; depth < CORE_TYPE_MAX_DEPTH; depth += 1) {
if (t == nullptr) {
break;
return t;
}
switch (t->kind) {
@@ -996,15 +999,21 @@ gb_internal Type *core_type(Type *t) {
t = t->Named.base;
continue;
case Type_Enum:
if (t == t->Enum.base_type) {
return t_invalid;
}
t = t->Enum.base_type;
continue;
case Type_BitField:
if (t == t->BitField.backing_type) {
return t_invalid;
}
t = t->BitField.backing_type;
continue;
}
break;
return t;
}
return t;
return t_invalid;
}
gb_internal void set_base_type(Type *t, Type *base) {
@@ -4442,6 +4451,9 @@ gb_internal i64 type_align_of_internal(Type *t, TypePath *path) {
return build_context.int_size;
case Type_BitField:
if (t == t->BitField.backing_type) {
return FAILURE_ALIGNMENT;
}
return type_align_of_internal(t->BitField.backing_type, path);
case Type_Tuple: {
@@ -4458,6 +4470,9 @@ gb_internal i64 type_align_of_internal(Type *t, TypePath *path) {
case Type_Map:
return build_context.ptr_size;
case Type_Enum:
if (t == t->Enum.base_type) {
return FAILURE_ALIGNMENT;
}
return type_align_of_internal(t->Enum.base_type, path);
case Type_Union: {
@@ -4757,6 +4772,9 @@ gb_internal i64 type_size_of_internal(Type *t, TypePath *path) {
} break;
case Type_Enum:
if (t == t->Enum.base_type) {
return FAILURE_SIZE;
}
return type_size_of_internal(t->Enum.base_type, path);
case Type_Union: {
@@ -4868,6 +4886,11 @@ gb_internal i64 type_size_of_internal(Type *t, TypePath *path) {
}
case Type_BitField:
// a self-referential backing type is an illegal cycle; this prevents the
// tail call below from spinning
if (t == t->BitField.backing_type) {
return FAILURE_SIZE;
}
return type_size_of_internal(t->BitField.backing_type, path);
}