mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-18 20:40:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve handling of passing constants to implicit immutable const ref parameters

Browse Source
This commit is contained in:
gingerBill
2023-02-17 14:48:50 +00:00
parent 99460c9e32
commit c08809e29d
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/llvm_backend_proc.cpp
View File

@@ -1045,9 +1045,25 @@ gb_internal lbValue lb_emit_call(lbProcedure *p, lbValue value, Array<lbValue> c
} else if (is_odin_cc) {
// NOTE(bill): Odin parameters are immutable so the original value can be passed if possible
// i.e. `T const &` in C++
ptr = lb_address_from_load_or_generate_local(p, x);
if (LLVMIsConstant(x.value)) {
// NOTE(bill): if the value is already constant, then just it as a global variable
// and pass it by pointer
lbAddr addr = lb_add_global_generated(p->module, original_type, x);
lb_make_global_private_const(addr);
ptr = addr.addr;
} else {
ptr = lb_address_from_load_or_generate_local(p, x);
}
} else {
ptr = lb_copy_value_to_ptr(p, x, original_type, 16);
if (LLVMIsConstant(x.value)) {
// NOTE(bill): if the value is already constant, then just it as a global variable
// and pass it by pointer
lbAddr addr = lb_add_global_generated(p->module, original_type, x);
lb_make_global_private_const(addr);
ptr = addr.addr;
} else {
ptr = lb_copy_value_to_ptr(p, x, original_type, 16);
}
}
array_add(&processed_args, ptr);
}