mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2025-12-31 10:22:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

point stdin, stdout, stderr to /dev/null if unused in os2.process_start

Browse Source
This commit is contained in:
jason
2024-08-04 01:47:10 -04:00
parent 2a7db08c20
commit c691c7dc68
1 changed files with 37 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
core/os/os2/process_linux.odin
View File

@@ -412,23 +412,51 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {
if pid == 0 {
// in child process now
stdin_fd: linux.Fd
stdout_fd: linux.Fd
stderr_fd: linux.Fd
if desc.stdin != nil {
fd := linux.Fd(fd(desc.stdin))
if _, errno = linux.dup2(fd, STDIN); errno != .NONE {
intrinsics.trap()
stdin_fd = linux.Fd(fd(desc.stdin))
} else {
stdin_fd, errno = linux.open("/dev/null", {})
if errno != nil {
intrinsics.trap() // TODO: our own special pipe
}
}
write_devnull: linux.Fd = -1
if desc.stdout != nil {
fd := linux.Fd(fd(desc.stdout))
if _, errno = linux.dup2(fd, STDOUT); errno != .NONE {
intrinsics.trap()
stdout_fd = linux.Fd(fd(desc.stdout))
} else {
write_devnull, errno = linux.open("/dev/null", {.WRONLY})
if errno != nil {
intrinsics.trap() // TODO
}
stdout_fd = write_devnull
}
if desc.stderr != nil {
fd := linux.Fd(fd(desc.stderr))
if _, errno = linux.dup2(fd, STDERR); errno != .NONE {
intrinsics.trap()
stderr_fd = linux.Fd(fd(desc.stderr))
} else {
if write_devnull == -1 {
write_devnull, errno = linux.open("/dev/null", {.WRONLY})
if errno != nil {
intrinsics.trap() // TODO
}
}
stderr_fd = write_devnull
}
if _, errno = linux.dup2(stdin_fd, STDIN); errno != .NONE {
intrinsics.trap()
}
if _, errno = linux.dup2(stdout_fd, STDOUT); errno != .NONE {
intrinsics.trap()
}
if _, errno = linux.dup2(stderr_fd, STDERR); errno != .NONE {
intrinsics.trap()
}
if errno = linux.execveat(exe_fd, "", &cargs[0], env, {.AT_EMPTY_PATH}); errno != .NONE {
@@ -437,8 +465,6 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {
unreachable()
}
// TODO: We need to come up with a way to detect the execve failure from here.
process, err = process_open(int(pid))
if err == .Unsupported {
return process, nil