mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-01-01 02:42:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' of https://github.com/odin-lang/Odin

Browse Source
This commit is contained in:
gingerBill
2025-04-15 11:51:05 +01:00
parent 39363c4018 2d5b85f9f9
commit cfb8cc709c
3 changed files with 48 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/exact_value.cpp
View File

@@ -955,7 +955,7 @@ gb_internal bool compare_exact_values(TokenKind op, ExactValue x, ExactValue y)
f64 a = x.value_float;
f64 b = y.value_float;
if (isnan(a) || isnan(b)) {
return false; // Fixes #5004
return op == Token_NotEq;
}
switch (op) {

33
tests/internal/test_5004_nan_constant_comparison.odin
View File

@@ -1,33 +0,0 @@
package test_internal
import "core:testing"
@(test)
compare_constant_nans_f32 :: proc(t: ^testing.T) {
NaN :: f32(0h7fc0_0000)
NaN2 :: f32(0h7fc0_0001)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != NaN, false)
testing.expect_value(t, NaN != NaN2, false)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}
@(test)
compare_constant_nans_f64 :: proc(t: ^testing.T) {
NaN :: f64(0h7fff_0000_0000_0000)
NaN2 :: f64(0h7fff_0000_0000_0001)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != NaN, false)
testing.expect_value(t, NaN != NaN2, false)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}

47
tests/internal/test_nan_constant_comparison.odin Normal file
View File

@@ -0,0 +1,47 @@
package test_internal
import "core:testing"
@(test)
compare_constant_nans_f32 :: proc(t: ^testing.T) {
NaN :: f32(0h7fc0_0000)
NaN2 :: f32(0h7fc0_0001)
Inf :: f32(0h7F80_0000)
Neg_Inf :: f32(0hFF80_0000)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != 0, true)
testing.expect_value(t, NaN != 5, true)
testing.expect_value(t, NaN != -5, true)
testing.expect_value(t, NaN != NaN, true)
testing.expect_value(t, NaN != NaN2, true)
testing.expect_value(t, NaN != Inf, true)
testing.expect_value(t, NaN != Neg_Inf, true)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}
@(test)
compare_constant_nans_f64 :: proc(t: ^testing.T) {
NaN :: f64(0h7fff_0000_0000_0000)
NaN2 :: f64(0h7fff_0000_0000_0001)
Inf :: f64(0h7FF0_0000_0000_0000)
Neg_Inf :: f64(0hFFF0_0000_0000_0000)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != 0, true)
testing.expect_value(t, NaN != 5, true)
testing.expect_value(t, NaN != -5, true)
testing.expect_value(t, NaN != NaN, true)
testing.expect_value(t, NaN != NaN2, true)
testing.expect_value(t, NaN != Inf, true)
testing.expect_value(t, NaN != Neg_Inf, true)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}