mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-08-14 09:44:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7220 from kalsprite/i64_const

Browse Source 
fix: Signed Int Constants permitted to exceed size
This commit is contained in:
Jeroen van Rijn
2026-08-05 03:09:29 +02:00
committed by GitHub
parent cfab1e391a cd6a913e55
commit f1dc9ce3c1
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/check_expr.cpp
View File

@@ -2391,14 +2391,18 @@ gb_internal bool check_representable_as_constant(CheckerContext *c, ExactValue i
case Basic_i32be:
case Basic_i64be:
if (c->bit_field_bit_size == 0) {
// return imin <= i && i <= imax;
// NOTE: the check below is a magnitude test (mp_count_bits() <= 64),
// big_int_to_i64 would wrap u64 max to -1 and pass for any signed type.
// Compare magnitudes instead
if (!big_int_can_be_represented_in_64_bits(&i)) {
return false;
}
i64 val64 = big_int_to_i64(&i);
return imin_64 <= val64 && val64 <= imax_64;
u64 mag = mp_get_mag_u64(&i);
if (big_int_is_neg(&i)) {
return mag <= cast(u64)-(imin_64+1) + 1; // |imin_64|, without overflowing i64
}
return mag <= cast(u64)imax_64;
}
/*fallthrough*/
case Basic_i128le: