mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-17 20:12:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disallow #complete switch ranges

Browse Source
This commit is contained in:
gingerBill
2018-02-17 19:24:02 +00:00
parent cabb2bb992
commit f51de2e488
2 changed files with 8 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
examples/demo.odin
View File

@@ -741,10 +741,10 @@ complete_switch :: proc() {
b := Foo.B;
f := Foo.A;
#complete switch f {
case A...C: fmt.println("A...C");
// case A: fmt.println("A");
// case B: fmt.println("B");
// case C: fmt.println("C");
// case A...C: fmt.println("A...C");
case A: fmt.println("A");
case B: fmt.println("B");
case C: fmt.println("C");
case D: fmt.println("D");
case: fmt.println("?");
}

37
src/check_stmt.cpp
View File

@@ -739,41 +739,12 @@ void check_switch_stmt(Checker *c, AstNode *node, u32 mod_flags) {
Operand b1 = rhs;
check_comparison(c, &a1, &b1, op);
if (complete) {
if (lhs.mode != Addressing_Constant) {
error(lhs.expr, "#complete switch statement only allows constant case clauses");
}
if (rhs.mode != Addressing_Constant) {
error(rhs.expr, "#complete switch statement only allows constant case clauses");
}
error(lhs.expr, "#complete switch statement does not allow ranges");
}
if (complete &&
a1.mode != Addressing_Invalid && b1.mode != Addressing_Invalid &&
lhs.mode == Addressing_Constant && rhs.mode == Addressing_Constant &&
is_type_number(lhs.type) && is_type_number(rhs.type)) {
ExactValue start = lhs.value;
ExactValue end = rhs.value;
ExactValue one = exact_value_i64(1);
match_exact_values(&one, &start);
for (ExactValue i = start;
compare_exact_values(op, i, end);
i = exact_value_add(i, one)) {
bool use_expr = false;
Operand x = lhs;
x.value = i;
if (compare_exact_values(Token_CmpEq, i, start)) {
use_expr = true;
} else if (compare_exact_values(Token_CmpEq, i, end)) {
x = rhs;
use_expr = true;
}
add_constant_switch_case(c, &seen, x, use_expr);
}
} else {
add_constant_switch_case(c, &seen, lhs);
if (op == Token_LtEq) {
add_constant_switch_case(c, &seen, rhs);
}
add_constant_switch_case(c, &seen, lhs);
if (op == Token_LtEq) {
add_constant_switch_case(c, &seen, rhs);
}
} else {
Operand y = {};