mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-09-17 02:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure the palette is no longer in use before freeing it in the Vulkan renderer

Browse Source 
Fixes https://github.com/libsdl-org/SDL/issues/16283
This commit is contained in:
Sam Lantinga
2026-09-10 12:18:40 -07:00
parent e05eb27f2c
commit 04b2fb8046
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/render/vulkan/SDL_render_vulkan.c
View File

@@ -2638,10 +2638,17 @@ static void VULKAN_DestroyPalette(SDL_Renderer *renderer, SDL_TexturePalette *pa
VULKAN_RenderData *data = (VULKAN_RenderData *)renderer->internal;
VULKAN_PaletteData *palettedata = (VULKAN_PaletteData *)palette->internal;
if (palettedata) {
VULKAN_DestroyImage(data, &palettedata->image);
SDL_free(palettedata);
if (!palettedata) {
return;
}
/* Because VULKAN_DestroyPalette might be called while the data is in-flight, we need to issue the batch first
Unfortunately, this means that deleting a lot of palettes mid-frame will have poor performance. */
VULKAN_IssueBatch(data);
VULKAN_WaitForGPU(data);
VULKAN_DestroyImage(data, &palettedata->image);
SDL_free(palettedata);
}
static bool VULKAN_CreateTexture(SDL_Renderer *renderer, SDL_Texture *texture, SDL_PropertiesID create_props)