n3ds: SDL_SYS_GetPreferredLocales now handles error cases correctly.

Previously it would have reported success but not returned a valid string, and
didn't check for the (probably extremely unlikely) case of overflowing our
locale list array.
This commit is contained in:
Ryan C. Gordon
2026-02-20 10:10:30 -05:00
parent be82f316c4
commit 3aa531000a

View File

@@ -35,10 +35,12 @@ bool SDL_SYS_GetPreferredLocales(char *buf, size_t buflen)
static const char AVAILABLE_LOCALES[][6] = { "ja_JP", "en_US", "fr_FR", "de_DE",
"it_IT", "es_ES", "zh_CN", "ko_KR",
"nl_NL", "pt_PT", "ru_RU", "zh_TW" };
u8 current_locale = GetLocaleIndex();
if (current_locale != BAD_LOCALE) {
SDL_strlcpy(buf, AVAILABLE_LOCALES[current_locale], buflen);
const u8 current_locale = GetLocaleIndex();
if ((current_locale == BAD_LOCALE) || (current_locale >= SDL_arraysize(AVAILABLE_LOCALES))) {
return SDL_SetError("Could not obtain system locale");
}
SDL_strlcpy(buf, AVAILABLE_LOCALES[current_locale], buflen);
return true;
}