mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-12-10 08:32:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

audio: Fixed potential race condition.

Browse Source 
We need to check if the device is ready to close before releasing the lock,
in case other things are messing with the list of logical devices.
This commit is contained in:
Ryan C. Gordon
2023-10-26 22:57:34 -04:00
parent 8b6da3c701
commit c45b5121ce
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/audio/SDL_audio.c
View File

@@ -1353,9 +1353,12 @@ void SDL_CloseAudioDevice(SDL_AudioDeviceID devid)
SDL_AudioDevice *device = logdev->physical_device;
DestroyLogicalAudioDevice(logdev);
const SDL_bool close_physical = (device->logical_devices == NULL); // no more logical devices? Close the physical device, too.
// !!! FIXME: we _need_ to release this lock, but doing so can cause a race condition if someone opens a device while we're closing it.
SDL_UnlockMutex(device->lock); // can't hold the lock or the audio thread will deadlock while we WaitThread it. If not closing, we're done anyhow.
if (device->logical_devices == NULL) { // no more logical devices? Close the physical device, too.
if (close_physical) {
ClosePhysicalAudioDevice(device);
}