mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-09-06 03:18:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

filesystem: POSIX SDL_SYS_CopyFile shouldn't use a temp file.

Browse Source 
Fixes #10957.
This commit is contained in:
Ryan C. Gordon
2024-09-26 19:33:50 -04:00
parent 0d593cf39a
commit d8c76d2f34
1 changed files with 3 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/filesystem/posix/SDL_sysfsops.c
View File

@@ -83,23 +83,18 @@ bool SDL_SYS_RenamePath(const char *oldpath, const char *newpath)
bool SDL_SYS_CopyFile(const char *oldpath, const char *newpath) bool SDL_SYS_CopyFile(const char *oldpath, const char *newpath)
{ {
char *buffer = NULL; char *buffer = NULL;
char *tmppath = NULL;
SDL_IOStream *input = NULL; SDL_IOStream *input = NULL;
SDL_IOStream *output = NULL; SDL_IOStream *output = NULL;
const size_t maxlen = 4096; const size_t maxlen = 4096;
size_t len; size_t len;
bool result = false; bool result = false;
if (SDL_asprintf(&tmppath, "%s.tmp", newpath) < 0) {
goto done;
}
input = SDL_IOFromFile(oldpath, "rb"); input = SDL_IOFromFile(oldpath, "rb");
if (!input) { if (!input) {
goto done; goto done;
} }
output = SDL_IOFromFile(tmppath, "wb"); output = SDL_IOFromFile(newpath, "wb");
if (!output) { if (!output) {
goto done; goto done;
} }
@@ -125,28 +120,16 @@ bool SDL_SYS_CopyFile(const char *oldpath, const char *newpath)
goto done; goto done;
} }
if (!SDL_CloseIO(output)) { result = SDL_CloseIO(output);
output = NULL; // it's gone, even if it failed. output = NULL; // it's gone, even if it failed.
goto done;
}
output = NULL;
if (!SDL_RenamePath(tmppath, newpath)) {
SDL_RemovePath(tmppath);
goto done;
}
result = true;
done: done:
if (output) { if (output) {
SDL_CloseIO(output); SDL_CloseIO(output);
SDL_RemovePath(tmppath);
} }
if (input) { if (input) {
SDL_CloseIO(input); SDL_CloseIO(input);
} }
SDL_free(tmppath);
SDL_free(buffer); SDL_free(buffer);
return result; return result;