mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-04-05 07:09:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

uikit: Don't copy argv; the original lives the whole time we need it.

Browse Source 
Reference Issue #14510.
This commit is contained in:
Ryan C. Gordon
2025-11-24 15:29:39 -05:00
parent 29f3844b01
commit da863ff5f9
1 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/video/uikit/SDL_uikitappdelegate.m
View File

@@ -45,18 +45,9 @@ int SDL_RunApp(int argc, char *argv[], SDL_main_func mainFunction, void *reserve
SDL_CheckDefaultArgcArgv(&argc, &argv);
// store arguments
/* Note that we need to be careful about how we allocate/free memory here.
* If the application calls SDL_SetMemoryFunctions(), we can't rely on
* SDL_free() to use the same allocator after SDL_main() returns.
*/
forward_main = mainFunction;
forward_argc = argc;
forward_argv = (char **)malloc((argc + 1) * sizeof(char *)); // This should NOT be SDL_malloc()
for (int i = 0; i < argc; i++) {
forward_argv[i] = malloc((SDL_strlen(argv[i]) + 1) * sizeof(char)); // This should NOT be SDL_malloc()
strcpy(forward_argv[i], argv[i]);
}
forward_argv[argc] = NULL;
forward_argv = argv;
// Give over control to run loop, SDLUIKitDelegate will handle most things from here
@autoreleasepool {
@@ -71,12 +62,6 @@ int SDL_RunApp(int argc, char *argv[], SDL_main_func mainFunction, void *reserve
UIApplicationMain(argc, argv, nil, name);
}
// free the memory we used to hold copies of argc and argv
for (int i = 0; i < forward_argc; i++) {
free(forward_argv[i]); // This should NOT be SDL_free()
}
free(forward_argv); // This should NOT be SDL_free()
return exit_status;
}