mirrors/desktop
1
0
Fork 0
mirror of https://github.com/zen-browser/desktop.git synced 2026-02-05 19:37:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ZenMods): rework how default value for mod preferences are set (#8783)

Browse Source 
this should avoid possible collisions
This commit is contained in:
Bryan Galdámez
2025-06-02 02:06:54 -06:00
committed by GitHub
parent 0869fa55bb
commit 0642ceba40
1 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/zen/mods/ZenMods.mjs
View File

@@ -157,31 +157,33 @@
continue;
}
if (type === 'checkbox') {
const value = Services.prefs.getBoolPref(property, false);
if (typeof defaultValue !== 'boolean') {
console.warn(
'[ZenMods]: Warning, invalid data type received for expected type boolean, skipping.'
);
continue;
}
const getProperty =
type === 'checkbox' ? Services.prefs.getBoolPref : Services.prefs.getStringPref;
const setProperty =
type === 'checkbox' ? Services.prefs.setBoolPref : Services.prefs.setStringPref;
if (!value) {
Services.prefs.setBoolPref(property, defaultValue);
}
} else {
const value = Services.prefs.getStringPref(property, 'zen-property-no-saved');
try {
getProperty(property);
} catch {
console.debug(
`[ZenMods]: Setting default value for ${property} to ${defaultValue} (${typeof defaultValue})`
);
if (typeof defaultValue !== 'string' && typeof defaultValue !== 'number') {
if (
typeof defaultValue !== 'boolean' &&
typeof defaultValue !== 'string' &&
typeof defaultValue !== 'number'
) {
console.warn(
`[ZenMods]: Warning, invalid data type received (${typeof defaultValue}), skipping.`
);
continue;
}
if (value === 'zen-property-no-saved') {
Services.prefs.setStringPref(property, defaultValue.toString());
}
setProperty(
property,
typeof defaultValue === 'boolean' ? defaultValue : defaultValue.toString()
);
}
}
}