mirrors/desktop
1
0
Fork 0
mirror of https://github.com/zen-browser/desktop.git synced 2026-08-19 05:01:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-14843: Fixed invalid controller access for media playback (gh-14894)

Browse Source
This commit is contained in:
mr. m
2026-08-09 14:40:37 +02:00
committed by GitHub
parent 864a8ef713
commit 0953d0cda0
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/zen/media/ZenMediaController.mjs
View File

@@ -46,6 +46,10 @@ class ZenMediaCard {
this.#initListeners();
if (controller) {
// Queried before anything is wired up: it throws if the controller
// went away in the meantime, and the caller drops the card.
const positionState = controller.getPositionState();
this.#controllerListeners = {
positionstatechange: this.#onPositionstateChange.bind(this),
playbackstatechange: this.#onPlaybackstateChange.bind(this),
@@ -62,7 +66,7 @@ class ZenMediaCard {
this.element.classList.toggle("playing", controller.isPlaying);
this.updateMetadata();
this.updatePositionState(controller.getPositionState());
this.updatePositionState(positionState);
this.updateSupportedKeys();
} else {
this.element.setAttribute("media-sharing", "");
@@ -644,7 +648,15 @@ class nsZenMediaController {
#addCard(key, browser, controller = null) {
const element = this.#createCardElement();
const card = new ZenMediaCard(this, element, browser, controller);
let card;
try {
card = new ZenMediaCard(this, element, browser, controller);
} catch (e) {
console.error("Failed to create media card", e);
// The controller went away while the card was being set up.
element.remove();
return null;
}
this.#cards.set(key, card);
if (controller) {
// Media cards start hidden and appear via the delayed check in