mirror of
https://github.com/zen-browser/desktop.git
synced 2026-03-29 11:51:51 +00:00
feat: Improved styling for native MacOS popovers and fixed anchor positions, b=no-bug, c=workflows, media, common, folders
This commit is contained in:
@@ -2,7 +2,7 @@ name: Zen Twilight Scheduled Releases
|
||||
|
||||
on:
|
||||
schedule:
|
||||
- cron: "0 23 * * *"
|
||||
- cron: "0 23 */2 * *"
|
||||
workflow_dispatch:
|
||||
inputs:
|
||||
create_release:
|
||||
|
||||
@@ -4,7 +4,6 @@
|
||||
|
||||
- name: image.jxl.enabled
|
||||
value: true
|
||||
locked: true
|
||||
|
||||
- name: svg.context-properties.content.enabled
|
||||
value: true
|
||||
|
||||
@@ -22,7 +22,7 @@ diff --git a/browser/components/asrouter/modules/FeatureCallout.sys.mjs b/browse
|
||||
type="arrow"
|
||||
consumeoutsideclicks="never"
|
||||
norolluponanchor="true"
|
||||
+ nonnativepopover="true"
|
||||
+
|
||||
position="${panel_position.panel_position_string}"
|
||||
${hide_arrow ? "" : 'show-arrow=""'}
|
||||
${autohide ? "" : 'noautohide="true"'}
|
||||
|
||||
@@ -14,7 +14,11 @@
|
||||
"replaces": {
|
||||
// The patch we sent was for firefox 149, but we are currently in 148, so theres
|
||||
// a conflict in the patch. See https://bugzilla.mozilla.org/show_bug.cgi?id=2015354
|
||||
"overridden": "overriden"
|
||||
"overridden": "overriden",
|
||||
// Specifically trying to target FeatureCallout.sys.mjs's change.
|
||||
// IMPORTANT: Make sure Feature callouts STILL use native popopvers when
|
||||
// syncing from upstream, as this is a critical part of the patch.
|
||||
"+ nonnativepopover=\"true\"": "+ "
|
||||
}
|
||||
},
|
||||
{
|
||||
|
||||
@@ -30,7 +30,7 @@ panel[type="arrow"]:not(#feature-callout) {
|
||||
}
|
||||
|
||||
@media (-moz-platform: macos) {
|
||||
&[followanchor="false"] {
|
||||
&:where([followanchor="false"], [nonnativepopover="true"]) {
|
||||
appearance: auto !important;
|
||||
-moz-default-appearance: menupopup;
|
||||
/* We set the default background here, rather than on ::part(content),
|
||||
|
||||
@@ -744,7 +744,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
|
||||
size *= 48;
|
||||
return {
|
||||
position,
|
||||
x: 10,
|
||||
x: isRightSide ? -10 : 10,
|
||||
y: size / -2,
|
||||
};
|
||||
}
|
||||
|
||||
@@ -275,7 +275,7 @@ class nsZenLiveFoldersManager {
|
||||
{
|
||||
selector: `[id="${folder.id}"] > .tab-group-label-container`,
|
||||
panel_position: {
|
||||
anchor_attachment: "rightcenter",
|
||||
anchor_attachment: isRightSide ? "leftcenter" : "rightcenter",
|
||||
callout_attachment: isRightSide ? "topright" : "topleft",
|
||||
},
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user