mirror of
https://github.com/zen-browser/desktop.git
synced 2026-01-25 14:16:10 +00:00
Refactor ZenGlanceManager to improve readability and maintainability of tab opening logic
This commit is contained in:
@@ -13,8 +13,8 @@
|
||||
|
||||
XPCOMUtils.defineLazyPreferenceGetter(
|
||||
this._lazyPref,
|
||||
"SHOULD_OPEN_EXTERNAL_TABS_IN_GLANCE",
|
||||
"zen.glance.open-essential-external-links",
|
||||
'SHOULD_OPEN_EXTERNAL_TABS_IN_GLANCE',
|
||||
'zen.glance.open-essential-external-links',
|
||||
false
|
||||
);
|
||||
|
||||
@@ -309,8 +309,13 @@
|
||||
|
||||
shouldOpenTabInGlance(tab) {
|
||||
let owner = tab.owner;
|
||||
return owner && owner.getAttribute('zen-essential') === 'true' && this._lazyPref.SHOULD_OPEN_EXTERNAL_TABS_IN_GLANCE
|
||||
&& owner.linkedBrowser?.docShellIsActive && owner.linkedBrowser?.browsingContext?.isAppTab;
|
||||
return (
|
||||
owner &&
|
||||
owner.getAttribute('zen-essential') === 'true' &&
|
||||
this._lazyPref.SHOULD_OPEN_EXTERNAL_TABS_IN_GLANCE &&
|
||||
owner.linkedBrowser?.docShellIsActive &&
|
||||
owner.linkedBrowser?.browsingContext?.isAppTab
|
||||
);
|
||||
}
|
||||
|
||||
onTabOpen(event) {
|
||||
|
||||
Reference in New Issue
Block a user