mirrors/desktop
1
0
Fork 0
mirror of https://github.com/zen-browser/desktop.git synced 2025-09-05 19:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1565 from BrhmDev/fix/compact-mode-getting-stuck-after-context-menu

Browse Source 
Fix compact mode getting stuck on right click
This commit is contained in:
mauro 🤙
2024-09-20 21:21:44 +02:00
committed by GitHub
parent 3b426fa0cf 3ebf3fdb67
commit 5649faf085
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/browser/base/content/ZenUIManager.mjs
View File

@@ -151,7 +151,7 @@ var gZenCompactModeManager = {
Services.prefs.addObserver('zen.view.compact', this._updateEvent.bind(this));
Services.prefs.addObserver('zen.view.compact.toolbar-flash-popup.duration', this._updatedSidebarFlashDuration.bind(this));
this.sidebar.addEventListener('contextmenu', this.keepSidebarVisibleOnContextMenu.bind(this));
addEventListener('popupshowing', this.keepSidebarVisibleOnContextMenu.bind(this));
},
get prefefence() {
@@ -210,7 +210,10 @@ var gZenCompactModeManager = {
}, this.flashSidebarDuration);
},
keepSidebarVisibleOnContextMenu() {
keepSidebarVisibleOnContextMenu(event) {
if (!this.sidebar.contains(event.explicitOriginalTarget)) {
return;
}
this.sidebar.setAttribute('has-popup-menu', '');
/* If the cursor is on the popup when it hides, the :hover effect will not be reapplied to the sidebar until the cursor moves,
to mitigate this: Wait for mousemove when popup item selected
@@ -227,8 +230,8 @@ var gZenCompactModeManager = {
addEventListener('mousemove', this.__removeHasPopupAttribute, {once: true});
}
}
const removeHasPopupOnPopupHidden = (event) => {
if (['toolbar-context-menu', 'tabContextMenu'].includes(event.target.id)) {
const removeHasPopupOnPopupHidden = (hiddenEvent) => {
if (event.target === hiddenEvent.target) {
removeEventListener('click', waitForMouseMoveOnPopupSelect);
removeEventListener('popuphidden', removeHasPopupOnPopupHidden);
this.__removeHasPopupAttribute();