mirrors/desktop
1
0
Fork 0
mirror of https://github.com/zen-browser/desktop.git synced 2025-09-05 19:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor ZenCompactMode hover handling by removing unused animation tracking and simplifying hover duration logic

Browse Source
This commit is contained in:
mr. M
2025-01-15 17:04:12 +01:00
parent c909421090
commit c50b9cd555
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/base/zen-components/ZenCompactMode.mjs
View File

@@ -18,7 +18,6 @@ var gZenCompactModeManager = {
_flashTimeouts: {},
_evenListeners: [],
_removeHoverFrames: {},
_animatingElements: {},
init() {
Services.prefs.addObserver('zen.view.compact', this._updateEvent.bind(this));
@@ -275,6 +274,7 @@ var gZenCompactModeManager = {
{
element: this.sidebar,
screenEdge: this.sidebarIsOnRight ? 'right' : 'left',
keepHoverDuration: 300,
},
{
element: document.getElementById('zen-appcontent-navbar-container'),
@@ -318,19 +318,9 @@ var gZenCompactModeManager = {
target.addEventListener('mouseenter', (event) => {
this.clearFlashTimeout('has-hover' + target.id);
window.requestAnimationFrame(() => target.setAttribute('zen-has-hover', 'true'));
if (target.id === 'navigator-toolbox' && gZenCompactModeManager.prefefence) {
this._animatingElements[target.id] = true;
setTimeout(() => {
delete this._animatingElements[target.id];
}, 312.5); // 0.3125s is the duration of the sidebar animation (the longest one)
}
});
target.addEventListener('mouseleave', (event) => {
if (this._animatingElements[target.id]) {
return;
}
// If on Mac, ignore mouseleave in the area of window buttons
if (AppConstants.platform == 'macosx') {
const MAC_WINDOW_BUTTONS_X_BORDER = 75;
@@ -346,7 +336,7 @@ var gZenCompactModeManager = {
}
if (this.hoverableElements[i].keepHoverDuration) {
this.flashElement(target, keepHoverDuration, 'has-hover' + target.id, 'zen-has-hover');
this.flashElement(target, this.hoverableElements[i].keepHoverDuration, 'has-hover' + target.id, 'zen-has-hover');
} else {
this._removeHoverFrames[target.id] = window.requestAnimationFrame(() => target.removeAttribute('zen-has-hover'));
}