fix: Split View is not displayed when performing animateSelect, p=#10392

This commit is contained in:
octaviusz
2025-09-16 15:59:40 +03:00
committed by GitHub
parent ef09a30239
commit f780eb9c33

View File

@@ -1603,6 +1603,7 @@
const tabsContainer = currentGroup.querySelector('.tab-group-container');
const groupStart = currentGroup.querySelector('.zen-tab-group-start');
tabsContainer.style.overflow = 'clip';
if (tabsContainer.hasAttribute('hidden')) tabsContainer.removeAttribute('hidden');
@@ -1635,10 +1636,13 @@
}
}
const itemsToShow = [];
if (selectedTabs.length) {
for (let i = 0; i < groupItems.length; i++) {
const { item, splitViewId } = groupItems[i];
itemsToShow.push(item);
// Skip selected items
if (selectedTabs.includes(item)) continue;
@@ -1652,18 +1656,18 @@
}
// FIXME: This is a hack to fix the animations not working properly
this.styleCleanup(itemsToShow);
itemsToHide.forEach((item) => {
item.style.opacity = 0;
item.style.height = 0;
});
this.styleCleanup(selectedTabs);
animations.push(
...this.#createAnimation(
itemsToHide,
itemsToShow,
{
opacity: 0,
height: 0,
opacity: '',
height: '',
},
{
duration: 0.12,
@@ -1671,10 +1675,10 @@
}
),
...this.#createAnimation(
selectedTabs,
itemsToHide,
{
opacity: '',
height: '',
opacity: 0,
height: 0,
},
{
duration: 0.12,