mirror of
https://github.com/zen-browser/desktop.git
synced 2026-01-24 21:56:10 +00:00
chore: Small quality fixes, b=no-bug, c=common, glance
This commit is contained in:
@@ -1,12 +1,13 @@
|
||||
diff --git a/browser/base/content/browser-pageActions.js b/browser/base/content/browser-pageActions.js
|
||||
index 00da33bc11189db17b6a2e656acb3a778531197c..9571155baccad9a886cbe9c7bf0bd76a135331c4 100644
|
||||
index 00da33bc11189db17b6a2e656acb3a778531197c..bdca62e9ed5513e1e1922f1f9498755f5459e0c2 100644
|
||||
--- a/browser/base/content/browser-pageActions.js
|
||||
+++ b/browser/base/content/browser-pageActions.js
|
||||
@@ -451,6 +451,7 @@ var BrowserPageActions = {
|
||||
@@ -449,7 +449,7 @@ var BrowserPageActions = {
|
||||
document.getElementById(
|
||||
action && this.urlbarButtonNodeIDForActionID(action.id)
|
||||
),
|
||||
document.getElementById(this.mainButtonNode.id),
|
||||
document.getElementById("identity-icon"),
|
||||
- document.getElementById(this.mainButtonNode.id),
|
||||
+ document.getElementById("zen-site-data-icon-button"),
|
||||
document.getElementById("identity-icon"),
|
||||
];
|
||||
for (let node of potentialAnchorNodes) {
|
||||
if (node && !node.hidden) {
|
||||
|
||||
@@ -22,6 +22,7 @@
|
||||
<toolbarbutton id="zen-site-data-header-reader-mode"
|
||||
data-l10n-id="zen-site-data-header-reader-mode"
|
||||
command="View:ReaderView"
|
||||
tooltip="dynamic-shortcut-tooltip"
|
||||
flex="1" />
|
||||
<toolbarbutton id="zen-site-data-header-screenshot"
|
||||
data-l10n-id="zen-site-data-header-screenshot"
|
||||
|
||||
@@ -0,0 +1,12 @@
|
||||
diff --git a/browser/components/asrouter/modules/FeatureCallout.sys.mjs b/browser/components/asrouter/modules/FeatureCallout.sys.mjs
|
||||
index 2a2c5a6fe903694abbac0be86c7b3c8adc1d0275..5571b827198474a2635a9bd968adbc8c96dbc353 100644
|
||||
--- a/browser/components/asrouter/modules/FeatureCallout.sys.mjs
|
||||
+++ b/browser/components/asrouter/modules/FeatureCallout.sys.mjs
|
||||
@@ -776,6 +776,7 @@ export class FeatureCallout {
|
||||
) {
|
||||
return false;
|
||||
}
|
||||
+ if (el?.id === "zen-site-data-icon-button") return true;
|
||||
|
||||
const style = this.win.getComputedStyle(el);
|
||||
return style?.visibility === "visible" && style?.display !== "none";
|
||||
@@ -0,0 +1,12 @@
|
||||
diff --git a/browser/components/tabbrowser/AsyncTabSwitcher.sys.mjs b/browser/components/tabbrowser/AsyncTabSwitcher.sys.mjs
|
||||
index 773f595e89e268578ba153907babec95b58a155a..abe86fc3d243a85c4a8dbee854a2d0130f7270fd 100644
|
||||
--- a/browser/components/tabbrowser/AsyncTabSwitcher.sys.mjs
|
||||
+++ b/browser/components/tabbrowser/AsyncTabSwitcher.sys.mjs
|
||||
@@ -937,6 +937,7 @@ export class AsyncTabSwitcher {
|
||||
return !(
|
||||
this.tabbrowser._printPreviewBrowsers.has(browser) ||
|
||||
lazy.PictureInPicture.isOriginatingBrowser(browser)
|
||||
+ || browser?.hasAttribute('zen-glance-background')
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
diff --git a/browser/components/urlbar/UrlbarInput.sys.mjs b/browser/components/urlbar/UrlbarInput.sys.mjs
|
||||
index afc7a6c6ddbf4cf5a5b27c0bd60577b833c63093..ef88cc762969f206c9b16274c4af526c738c5704 100644
|
||||
index afc7a6c6ddbf4cf5a5b27c0bd60577b833c63093..f28c9a1ac086af429a93bd01be5d355858bcf37b 100644
|
||||
--- a/browser/components/urlbar/UrlbarInput.sys.mjs
|
||||
+++ b/browser/components/urlbar/UrlbarInput.sys.mjs
|
||||
@@ -76,6 +76,13 @@ ChromeUtils.defineLazyGetter(lazy, "logger", () =>
|
||||
@@ -147,6 +147,15 @@ index afc7a6c6ddbf4cf5a5b27c0bd60577b833c63093..ef88cc762969f206c9b16274c4af526c
|
||||
this.removeAttribute("breakout-extend");
|
||||
this.#updateTextboxPosition();
|
||||
}
|
||||
@@ -2361,7 +2444,7 @@ export class UrlbarInput {
|
||||
forceUnifiedSearchButtonAvailable = false
|
||||
) {
|
||||
let prevState = this.getAttribute("pageproxystate");
|
||||
-
|
||||
+ this.removeAttribute("had-proxystate");
|
||||
this.setAttribute("pageproxystate", state);
|
||||
this._inputContainer.setAttribute("pageproxystate", state);
|
||||
this._identityBox?.setAttribute("pageproxystate", state);
|
||||
@@ -2595,10 +2678,12 @@ export class UrlbarInput {
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -276,14 +276,17 @@ var gZenUIManager = {
|
||||
|
||||
onUrlbarOpen() {
|
||||
setTimeout(() => {
|
||||
const hadValid = gURLBar.getAttribute('pageproxystate') === 'valid';
|
||||
gURLBar.setPageProxyState('invalid', false);
|
||||
gURLBar.setAttribute('had-proxystate', hadValid);
|
||||
}, 0);
|
||||
},
|
||||
|
||||
onUrlbarClose() {
|
||||
if (!gURLBar.valueIsTyped && gURLBar._untrimmedValue !== gURLBar.value) {
|
||||
gURLBar.handleRevert();
|
||||
if (gURLBar.getAttribute('had-proxystate') == 'true') {
|
||||
gURLBar.setPageProxyState('valid', false);
|
||||
}
|
||||
gURLBar.removeAttribute('had-proxystate');
|
||||
},
|
||||
|
||||
onUrlbarSearchModeChanged(event) {
|
||||
|
||||
@@ -339,6 +339,11 @@ body > #confetti {
|
||||
justify-content: center;
|
||||
align-items: center;
|
||||
border-radius: 6px;
|
||||
|
||||
@media not (-moz-platform: macos) {
|
||||
border-radius: 4px;
|
||||
}
|
||||
|
||||
transition:
|
||||
background-color 0.1s ease-in-out,
|
||||
transform 0.12s ease-in-out;
|
||||
@@ -498,6 +503,10 @@ body > #confetti {
|
||||
padding: 8px;
|
||||
padding-bottom: 0;
|
||||
|
||||
:root[zen-single-toolbar='true']:not([zen-right-side='true']) & {
|
||||
flex-direction: row-reverse;
|
||||
}
|
||||
|
||||
& toolbarbutton {
|
||||
margin: 0;
|
||||
appearance: none;
|
||||
@@ -544,7 +553,7 @@ body > #confetti {
|
||||
}
|
||||
|
||||
@media not (-moz-platform: macos) {
|
||||
border-radius: 6px;
|
||||
border-radius: 4px;
|
||||
background-color: color-mix(in srgb, currentcolor 6%, transparent);
|
||||
}
|
||||
|
||||
|
||||
@@ -247,7 +247,7 @@
|
||||
{
|
||||
duration: 0.3,
|
||||
type: 'spring',
|
||||
delay: 0.15,
|
||||
delay: 0.2,
|
||||
bounce: 0,
|
||||
}
|
||||
);
|
||||
@@ -434,6 +434,16 @@
|
||||
};
|
||||
}
|
||||
|
||||
#createGlancePreviewElement(src) {
|
||||
const imageDataElement = document.createXULElement('image');
|
||||
imageDataElement.setAttribute('src', src);
|
||||
|
||||
const parent = document.createElement('div');
|
||||
parent.classList.add('zen-glance-element-preview');
|
||||
parent.appendChild(imageDataElement);
|
||||
return parent;
|
||||
}
|
||||
|
||||
/**
|
||||
* Handle element preview if provided
|
||||
* @param {Object} data - Glance data
|
||||
@@ -444,10 +454,7 @@
|
||||
return null;
|
||||
}
|
||||
|
||||
const imageDataElement = document.createXULElement('image');
|
||||
imageDataElement.setAttribute('src', data.elementData);
|
||||
imageDataElement.classList.add('zen-glance-element-preview');
|
||||
|
||||
const imageDataElement = this.#createGlancePreviewElement(data.elementData);
|
||||
this.browserWrapper.prepend(imageDataElement);
|
||||
this.#glances.get(this.#currentGlanceID).elementImageData = data.elementData;
|
||||
|
||||
@@ -990,10 +997,7 @@
|
||||
*/
|
||||
#addElementPreview(elementImageData) {
|
||||
if (elementImageData) {
|
||||
const imageDataElement = document.createXULElement('image');
|
||||
imageDataElement.setAttribute('src', elementImageData);
|
||||
imageDataElement.classList.add('zen-glance-element-preview');
|
||||
|
||||
const imageDataElement = this.#createGlancePreviewElement(elementImageData);
|
||||
this.browserWrapper.prepend(imageDataElement);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -171,11 +171,17 @@
|
||||
position: absolute;
|
||||
pointer-events: none;
|
||||
width: 100%;
|
||||
height: 100%;
|
||||
z-index: 0;
|
||||
border-radius: var(--zen-native-inner-radius);
|
||||
top: 0%;
|
||||
left: 50%;
|
||||
translate: -50% 0%;
|
||||
max-height: 100%;
|
||||
will-change: transform, opacity;
|
||||
background: rgba(255, 255, 255, 0.1);
|
||||
|
||||
& image {
|
||||
width: 100%;
|
||||
max-width: 100%;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -624,13 +624,6 @@ export class nsZenSiteDataPanel {
|
||||
callout_attachment: 'topleft',
|
||||
},
|
||||
},
|
||||
{
|
||||
selector: '#identity-icon-box',
|
||||
panel_position: {
|
||||
anchor_attachment: 'bottomcenter',
|
||||
callout_attachment: 'topleft',
|
||||
},
|
||||
},
|
||||
],
|
||||
content: {
|
||||
position: 'callout',
|
||||
|
||||
Reference in New Issue
Block a user