mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-08-24 16:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

terminal: reduce Parser.Action log formatting code size

Browse Source 
Shrinks libghostty-vt dylib by ~2%.
This commit is contained in:
Mitchell Hashimoto
2026-08-09 10:19:59 -07:00
parent 9d8fbd15b3
commit 0aa71d02ed
1 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/terminal/Parser.zig
View File

@@ -166,12 +166,18 @@ pub const Action = union(enum) {
// of invisible characters we don't want to handle right
// now.
// All others do the default behavior
// All others do the default behavior. Note the max
// depth of 1: this is only used for logging so we
// only want the top-level fields. Larger depths
// instantiate a recursive formatter for every nested
// type of every action payload (e.g. the full
// osc.Command union), which costs tens of kilobytes
// of binary size.
else => try writer.printValue(
"any",
.{},
@field(self, u_field.name),
3,
1,
),
}
}
@@ -386,10 +392,7 @@ inline fn doAction(self: *Parser, action: TransitionAction, c: u8) ?Action {
// We only allow colon or mixed separators for the 'm' command.
if (c != 'm' and self.params_sep.count() > 0) {
@branchHint(.cold);
log.warn(
"CSI colon or mixed separators only allowed for 'm' command, got: {f}",
.{result},
);
warnCsiSepMismatch(result.csi_dispatch);
break :csi_dispatch null;
}
@@ -406,6 +409,20 @@ inline fn doAction(self: *Parser, action: TransitionAction, c: u8) ?Action {
};
}
/// Log a warning for a CSI dispatch with colon/mixed separators on a
/// non-'m' command.
///
/// This is noinline on purpose so that this unlikely (cold) behavior
/// doesn't bloat the hot dispatch path which has been measured to actually
/// affect both binary size and performance due to icache busts.
noinline fn warnCsiSepMismatch(csi: Action.CSI) void {
@branchHint(.cold);
log.warn(
"CSI colon or mixed separators only allowed for 'm' command, got: {f}",
.{csi},
);
}
pub inline fn clear(self: *Parser) void {
self.intermediates_idx = 0;
self.params_idx = 0;