mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-04-18 13:30:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

snap: Don't leak LD_LIBRARY_PATH set by the snap launcher (#11431)

Browse Source 
LD_LIBRARY_PATH was being leaked which could break some apps launched
from ghostty, such as opening configuration in a text editor.
This commit is contained in:
Ken VanDine
2026-03-12 16:46:28 -04:00
committed by GitHub
parent 597e8cf1c5 64331b8c35
commit 174aae359d
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/os/open.zig
View File

@@ -1,6 +1,7 @@
const std = @import("std");
const builtin = @import("builtin");
const Allocator = std.mem.Allocator;
const build_config = @import("../build_config.zig");
const apprt = @import("../apprt.zig");
const log = std.log.scoped(.@"os-open");
@@ -48,6 +49,17 @@ pub fn open(
exe.stdout_behavior = .Pipe;
exe.stderr_behavior = .Pipe;
// In the snap on Linux the launcher exports LD_LIBRARY_PATH pointing at
// the snap's bundled libraries. Leaking this into child process can
// can be problematic, so let's drop it from the env
var snap_env: std.process.EnvMap = if (comptime build_config.snap) blk: {
var env = try std.process.getEnvMap(alloc);
env.remove("LD_LIBRARY_PATH");
break :blk env;
} else undefined;
defer if (comptime build_config.snap) snap_env.deinit();
if (comptime build_config.snap) exe.env_map = &snap_env;
// Spawn the process on our same thread so we can detect failure
// quickly.
try exe.spawn();