mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-06-08 12:54:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: disable ubsan and bundled runtimes for MSVC targets

Browse Source 
Zig's ubsan instrumentation emits ELF-style /exclude-symbols linker
directives into the compiled object files, causing LNK4229 warnings
with the MSVC linker. The bundled compiler_rt also produces COMDAT
sections that are incompatible with MSVC, causing fatal LNK1143.

Disable sanitize_c entirely on the root module for MSVC targets and
skip bundling both compiler_rt and ubsan_rt since MSVC provides its
own runtime.
This commit is contained in:
Mitchell Hashimoto
2026-03-23 10:52:21 -07:00
parent 31285e1ac3
commit 1ce057f053
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/build/GhosttyLibVt.zig
View File

@@ -94,25 +94,28 @@ fn initLib(
);
if (kind == .static) {
const is_msvc_abi = target.result.abi == .msvc;
// These must be bundled since we're compiling into a static lib.
// Otherwise, you get undefined symbol errors. This could cause
// problems if you're linking multiple static Zig libraries but
// we'll cross that bridge when we get to it.
//
// On MSVC targets, the MSVC runtime provides these, and Zig's
// bundled versions produce object files with ELF-style linker
// directives (e.g. /exclude-symbols) and COMDAT sections that
// are incompatible with the MSVC linker (LNK1143, LNK4229).
lib.bundle_compiler_rt = !is_msvc_abi;
lib.bundle_ubsan_rt = !is_msvc_abi;
lib.bundle_compiler_rt = true;
lib.bundle_ubsan_rt = true;
// Enable PIC so the static library can be linked into PIE
// executables, which is the default on most Linux distributions.
lib.root_module.pic = true;
}
if (target.result.os.tag == .windows) {
// Zig's ubsan emits /exclude-symbols linker directives and
// its compiler_rt produces COMDAT sections that are
// incompatible with the MSVC linker (LNK1143, LNK4229).
// Skip bundling these runtimes on Windows since consumers
// link against the MSVC runtime.
lib.bundle_compiler_rt = false;
lib.bundle_ubsan_rt = false;
}
if (lib.rootModuleTarget().abi.isAndroid()) {
// Support 16kb page sizes, required for Android 15+.
lib.link_z_max_page_size = 16384; // 16kb