mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-04-19 22:10:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

cli: dupe argument strings to retain their memory

Browse Source 
The argument iterator's .next() method returns a transient slice of the
command line buffer so we need to make our own copies of these values to
avoid referencing stale memory.
This commit is contained in:
Jon Parise
2026-03-28 12:14:28 -04:00
parent 0d1f77bc4d
commit 2b1ec5db6d
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/cli/explain_config.zig
View File

@@ -49,16 +49,19 @@ pub fn run(alloc: Allocator) !u8 {
var positional: ?[]const u8 = null;
var iter = try args.argsIterator(alloc);
defer iter.deinit();
defer if (option_name) |s| alloc.free(s);
defer if (keybind_name) |s| alloc.free(s);
defer if (positional) |s| alloc.free(s);
while (iter.next()) |arg| {
if (std.mem.startsWith(u8, arg, "--option=")) {
option_name = arg["--option=".len..];
option_name = try alloc.dupe(u8, arg["--option=".len..]);
} else if (std.mem.startsWith(u8, arg, "--keybind=")) {
keybind_name = arg["--keybind=".len..];
keybind_name = try alloc.dupe(u8, arg["--keybind=".len..]);
} else if (std.mem.eql(u8, arg, "--help") or std.mem.eql(u8, arg, "-h")) {
return Action.help_error;
} else if (!std.mem.startsWith(u8, arg, "-")) {
positional = arg;
positional = try alloc.dupe(u8, arg);
}
}