gtk: Open URIs with portals (#11754)

This is a continuation of the solid work done by @jcollie in PR #7864. I
checked with him if I could take over to continue the implementation.

His changes of last year have been adapted to be compatible with the
current GTK implementation. Aside from just "making it work", I also
dived into the portals and OpenURI implementation and made some
improvements there.

Notable improvements were:
- Improved lifecycle management of glib resources in the OpenURI
implementation
- More forgiving error handling in OpenURI implementation by adding more
fallbacks
- Fixed some memory leaks
- Less memory allocations in Portals implementation
- Added tests for building the Portals request path

Fixes #5991
This commit is contained in:
Jeffrey C. Ollie
2026-03-23 09:44:49 -05:00
committed by GitHub
4 changed files with 710 additions and 9 deletions

View File

@@ -13,4 +13,5 @@ test {
@import("std").testing.refAllDecls(@This());
_ = @import("gtk/ext.zig");
_ = @import("gtk/key.zig");
_ = @import("gtk/portal.zig");
}

View File

@@ -41,6 +41,7 @@ const Tab = @import("tab.zig").Tab;
const CloseConfirmationDialog = @import("close_confirmation_dialog.zig").CloseConfirmationDialog;
const ConfigErrorsDialog = @import("config_errors_dialog.zig").ConfigErrorsDialog;
const GlobalShortcuts = @import("global_shortcuts.zig").GlobalShortcuts;
const OpenURI = @import("../portal.zig").OpenURI;
const log = std.log.scoped(.gtk_ghostty_application);
@@ -215,6 +216,8 @@ pub const Application = extern struct {
/// not exist in Ghostty's environment variable.
saved_language: ?[:0]const u8 = null,
open_uri: OpenURI = undefined,
pub var offset: c_int = 0;
};
@@ -398,6 +401,7 @@ pub const Application = extern struct {
.custom_css_providers = .empty,
.global_shortcuts = gobject.ext.newInstance(GlobalShortcuts, .{}),
.saved_language = saved_language,
.open_uri = .init(rt_app),
};
// Signals
@@ -433,6 +437,7 @@ pub const Application = extern struct {
const priv: *Private = self.private();
priv.config.unref();
priv.winproto.deinit();
priv.open_uri.deinit();
priv.global_shortcuts.unref();
if (priv.saved_language) |language| alloc.free(language);
if (gdk.Display.getDefault()) |display| {
@@ -806,6 +811,11 @@ pub const Application = extern struct {
return &self.private().winproto;
}
/// Returns the open URI portal implementation.
pub fn openUri(self: *Self) *OpenURI {
return &self.private().open_uri;
}
/// This will get called when there are no more open surfaces.
fn startQuitTimer(self: *Self) void {
const priv = self.private();
@@ -1289,6 +1299,11 @@ pub const Application = extern struct {
// Set ourselves as the default application.
gio.Application.setDefault(self.as(gio.Application));
// The D-Bus connection is only valid after GApplication startup.
self.openUri().setDbusConnection(
self.as(gio.Application).getDbusConnection(),
);
// Setup our event loop
self.startupXev();
@@ -1873,6 +1888,17 @@ pub const Application = extern struct {
gobject.Object.virtual_methods.finalize.implement(class, &finalize);
}
};
pub fn openUrlFallback(self: *Application, kind: apprt.action.OpenUrl.Kind, url: []const u8) void {
// Fallback to the minimal cross-platform way of opening a URL.
// This is always a safe fallback and enables for example Windows
// to open URLs (GTK on Windows via WSL is a thing).
internal_os.open(
self.allocator(),
kind,
url,
) catch |err| log.warn("unable to open url: {}", .{err});
}
};
/// All apprt action handlers
@@ -2317,16 +2343,20 @@ const Action = struct {
self: *Application,
value: apprt.action.OpenUrl,
) void {
// TODO: use https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.OpenURI.html
if (std.mem.startsWith(u8, value.url, "/")) {
self.openUrlFallback(value.kind, value.url);
return;
}
if (std.mem.startsWith(u8, value.url, "file://")) {
self.openUrlFallback(value.kind, value.url);
return;
}
// Fallback to the minimal cross-platform way of opening a URL.
// This is always a safe fallback and enables for example Windows
// to open URLs (GTK on Windows via WSL is a thing).
internal_os.open(
self.allocator(),
value.kind,
value.url,
) catch |err| log.warn("unable to open url: {}", .{err});
self.openUri().start(value) catch |err| {
log.err("unable to open uri err={}", .{err});
self.openUrlFallback(value.kind, value.url);
return;
};
}
pub fn pwd(

105
src/apprt/gtk/portal.zig Normal file
View File

@@ -0,0 +1,105 @@
const std = @import("std");
const gio = @import("gio");
const Allocator = std.mem.Allocator;
pub const OpenURI = @import("portal/OpenURI.zig");
pub const token_hex_len = @sizeOf(usize) * 2;
pub const TokenBuffer = [token_hex_len + 1]u8;
const token_format = std.fmt.comptimePrint("{{x:0>{}}}", .{token_hex_len});
/// Generate a token suitable for use in requests to the XDG Desktop Portal
pub fn generateToken() usize {
return std.crypto.random.int(usize);
}
/// Format a request token consistently for use in portal object paths and payloads.
pub fn formatToken(buf: *TokenBuffer, token: usize) [:0]const u8 {
return std.fmt.bufPrintZ(buf, token_format, .{token}) catch unreachable;
}
/// Get the XDG portal request path for the current Ghostty instance.
///
/// See https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Request.html
/// for the protocol of the Request interface.
pub fn getRequestPath(alloc: Allocator, dbus: *gio.DBusConnection, token: usize) (Allocator.Error || error{NoDBusUniqueName})![:0]const u8 {
// Get the unique name from D-Bus and strip the leading `:`
const unique_name = std.mem.span(
dbus.getUniqueName() orelse {
return error.NoDBusUniqueName;
},
)[1..];
return buildRequestPath(alloc, unique_name, token);
}
/// Build the XDG portal request path for given unique name and token.
fn buildRequestPath(alloc: Allocator, unique_name: []const u8, token: usize) Allocator.Error![:0]const u8 {
var token_buf: TokenBuffer = undefined;
const token_string = formatToken(&token_buf, token);
const object_path = try std.mem.joinZ(
alloc,
"/",
&.{
"/org/freedesktop/portal/desktop/request",
unique_name,
token_string,
},
);
// Sanitize the unique name by replacing every `.` with `_`. In effect, this
// will turn a unique name like `1.192` into `1_192`.
// This sounds arbitrary, but it's part of the Request protocol.
_ = std.mem.replaceScalar(u8, object_path, '.', '_');
return object_path;
}
/// Try and parse the token out of a request path.
pub fn parseRequestPathToken(request_path: []const u8) ?usize {
const index = std.mem.lastIndexOfScalar(u8, request_path, '/') orelse return null;
const token = request_path[index + 1 ..];
return std.fmt.parseUnsigned(usize, token, 16) catch return null;
}
test "formatToken pads to fixed width" {
const testing = std.testing;
var token_buf: TokenBuffer = undefined;
const token = formatToken(&token_buf, 0x42);
try testing.expectEqual(@as(usize, token_hex_len), token.len);
try testing.expectEqualStrings("0000000000000042", token);
}
test "buildRequestPath" {
const testing = std.testing;
const path = try buildRequestPath(testing.allocator, "1.42", 0x75af01a79c6fea34);
try testing.expectEqualStrings(
"/org/freedesktop/portal/desktop/request/1_42/75af01a79c6fea34",
path,
);
testing.allocator.free(path);
}
test "buildRequestPath pads token" {
const testing = std.testing;
const path = try buildRequestPath(testing.allocator, "1.42", 0x42);
try testing.expectEqualStrings(
"/org/freedesktop/portal/desktop/request/1_42/0000000000000042",
path,
);
testing.allocator.free(path);
}
test "parseRequestPathToken" {
const testing = std.testing;
try testing.expectEqual(0x75af01a79c6fea34, parseRequestPathToken("/org/freedesktop/portal/desktop/request/1_42/75af01a79c6fea34").?);
try testing.expectEqual(null, parseRequestPathToken("/org/freedesktop/portal/desktop/request/1_42/75af01a79c6fGa34"));
try testing.expectEqual(null, parseRequestPathToken("75af01a79c6fea34"));
}

View File

@@ -0,0 +1,565 @@
//! Use DBus to call the XDG Desktop Portal to open an URI.
//! See: https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.OpenURI.html#org-freedesktop-portal-openuri-openuri
const OpenURI = @This();
const std = @import("std");
const Allocator = std.mem.Allocator;
const assert = std.debug.assert;
const gio = @import("gio");
const glib = @import("glib");
const gobject = @import("gobject");
const App = @import("../App.zig");
const portal = @import("../portal.zig");
const apprt = @import("../../../apprt.zig");
const log = std.log.scoped(.openuri);
/// The GTK app that we "belong" to.
app: *App,
/// Connection to the D-Bus session bus that we'll use for all of our messaging.
dbus: ?*gio.DBusConnection = null,
/// Mutex to protect modification of the entries map or the cleanup timer.
mutex: std.Thread.Mutex = .{},
/// Map to store data about any in-flight calls to the portal.
entries: std.AutoArrayHashMapUnmanaged(usize, *Entry) = .empty,
/// Used to manage a timer to clean up any orphan entries in the map.
cleanup_timer: ?c_uint = null,
/// Set to false during shutdown so callbacks stop touching internal state.
alive: bool = true,
const RequestData = struct {
open_uri: *OpenURI,
token: usize,
kind: apprt.action.OpenUrl.Kind,
uri: [:0]const u8,
request_path: [:0]const u8,
pub fn init(
alloc: Allocator,
open_uri: *OpenURI,
token: usize,
kind: apprt.action.OpenUrl.Kind,
uri: []const u8,
request_path: []const u8,
) Allocator.Error!*RequestData {
const uri_copy = try alloc.dupeZ(u8, uri);
errdefer alloc.free(uri_copy);
const request_path_copy = try alloc.dupeZ(u8, request_path);
errdefer alloc.free(request_path_copy);
const data = try alloc.create(RequestData);
errdefer alloc.destroy(data);
data.* = .{
.open_uri = open_uri,
.token = token,
.kind = kind,
.uri = uri_copy,
.request_path = request_path_copy,
};
return data;
}
pub fn deinit(self: *const RequestData, alloc: Allocator) void {
alloc.free(self.uri);
alloc.free(self.request_path);
}
};
/// Data about any in-flight calls to the portal.
pub const Entry = struct {
/// When the request started.
start: std.time.Instant,
/// A token used by the portal to identify requests and responses. The
/// actual format of the token does not really matter as long as it can be
/// used as part of a D-Bus object path. `usize` was chosen since it's easy
/// to hash and to generate random tokens.
token: usize,
/// The "kind" of URI. Unused here, but we may need to pass it on to the
/// fallback URL opener if the D-Bus method fails.
kind: apprt.action.OpenUrl.Kind,
/// A copy of the URI that we are opening. We need our own copy since the
/// method calls are asynchronous and the original may have been freed by
/// the time we need it.
uri: [:0]const u8,
/// Used to manage a subscription to a D-Bus signal, which is how the XDG
/// Portal reports results of the method call.
subscription: ?c_uint = null,
pub fn deinit(self: *const Entry, alloc: Allocator) void {
alloc.free(self.uri);
}
};
pub const Errors = error{
/// Could not get a D-Bus connection
DBusConnectionRequired,
/// The D-Bus connection did not have a unique name. This _should_ be
/// impossible, but is handled for safety's sake.
NoDBusUniqueName,
/// The system was unable to give us the time.
TimerUnavailable,
};
pub fn init(app: *App) OpenURI {
return .{
.app = app,
};
}
pub fn setDbusConnection(self: *OpenURI, dbus: ?*gio.DBusConnection) void {
self.dbus = dbus;
}
pub fn deinit(self: *OpenURI) void {
const alloc = self.app.app.allocator();
self.mutex.lock();
defer self.mutex.unlock();
if (!self.alive) return;
self.alive = false;
self.stopCleanupTimer();
for (self.entries.entries.items(.value)) |entry| {
self.unsubscribeFromResponse(entry);
destroyEntry(alloc, entry);
}
self.entries.deinit(alloc);
self.entries = .empty;
self.dbus = null;
}
/// Send the D-Bus method call to the XDG Desktop portal. The result of the
/// method call will be reported asynchronously.
pub fn start(self: *OpenURI, value: apprt.action.OpenUrl) (Allocator.Error || Errors)!void {
const alloc = self.app.app.allocator();
const dbus = self.dbus orelse return error.DBusConnectionRequired;
const token = portal.generateToken();
const request_path = try portal.getRequestPath(alloc, dbus, token);
defer alloc.free(request_path);
const request = try RequestData.init(alloc, self, token, value.kind, value.url, request_path);
errdefer {
request.deinit(alloc);
alloc.destroy(request);
}
self.mutex.lock();
defer self.mutex.unlock();
// Create an entry that is used to track the results of the D-Bus method
// call.
const entry = entry: {
const entry = try alloc.create(Entry);
errdefer alloc.destroy(entry);
entry.* = .{
.start = std.time.Instant.now() catch return error.TimerUnavailable,
.token = token,
.kind = value.kind,
.uri = try alloc.dupeZ(u8, value.url),
};
errdefer entry.deinit(alloc);
try self.entries.putNoClobber(alloc, token, entry);
break :entry entry;
};
errdefer {
_ = self.entries.swapRemove(token);
destroyEntry(alloc, entry);
}
self.startCleanupTimer();
self.subscribeToResponse(entry, dbus, request_path.ptr);
self.sendRequest(entry, dbus, request);
}
/// Subscribe to the D-Bus signal that will contain the results of our method
/// call to the portal. This must be called with the mutex locked.
fn subscribeToResponse(
self: *OpenURI,
entry: *Entry,
dbus: *gio.DBusConnection,
request_path: [*:0]const u8,
) void {
assert(!self.mutex.tryLock());
if (entry.subscription != null) return;
entry.subscription = dbus.signalSubscribe(
null,
"org.freedesktop.portal.Request",
"Response",
request_path,
null,
.{},
responseReceived,
self,
null,
);
}
/// Unsubscribe to the D-Bus signal that contains the result of the method call.
/// This will prevent a response from being processed multiple times. This must
/// be called when the mutex is locked.
fn unsubscribeFromResponse(self: *OpenURI, entry: *Entry) void {
assert(!self.mutex.tryLock());
// Unsubscribe from the response signal
if (entry.subscription) |subscription| {
const dbus = self.dbus orelse {
entry.subscription = null;
log.warn("unable to unsubscribe open uri response without dbus connection", .{});
return;
};
dbus.signalUnsubscribe(subscription);
entry.subscription = null;
}
}
fn destroyEntry(alloc: Allocator, entry: *Entry) void {
entry.deinit(alloc);
alloc.destroy(entry);
}
fn failRequest(self: *OpenURI, token: usize) ?*Entry {
self.mutex.lock();
defer self.mutex.unlock();
if (!self.alive) return null;
const entry = (self.entries.fetchSwapRemove(token) orelse return null).value;
self.unsubscribeFromResponse(entry);
return entry;
}
fn failRequestAndFallback(self: *OpenURI, request: *const RequestData) void {
const alloc = self.app.app.allocator();
const entry = self.failRequest(request.token) orelse return;
defer destroyEntry(alloc, entry);
self.app.app.openUrlFallback(request.kind, request.uri);
}
/// Send the D-Bus method call to the portal. The mutex must be locked when this
/// is called.
fn sendRequest(
self: *OpenURI,
entry: *Entry,
dbus: *gio.DBusConnection,
request: *RequestData,
) void {
assert(!self.mutex.tryLock());
const payload = payload: {
const builder_type = glib.VariantType.new("(ssa{sv})");
defer builder_type.free();
// Initialize our builder to build up our parameters
var builder: glib.VariantBuilder = undefined;
builder.init(builder_type);
// parent window - empty string means we have no window
builder.add("s", "");
// URI to open
builder.add("s", entry.uri.ptr);
// Options
{
const options = glib.VariantType.new("a{sv}");
defer options.free();
builder.open(options);
defer builder.close();
{
const option = glib.VariantType.new("{sv}");
defer option.free();
builder.open(option);
defer builder.close();
builder.add("s", "handle_token");
var token_buf: portal.TokenBuffer = undefined;
const token = portal.formatToken(&token_buf, entry.token);
const handle_token = glib.Variant.newString(token.ptr);
builder.add("v", handle_token);
}
{
const option = glib.VariantType.new("{sv}");
defer option.free();
builder.open(option);
defer builder.close();
builder.add("s", "writable");
const writable = glib.Variant.newBoolean(@intFromBool(false));
builder.add("v", writable);
}
{
const option = glib.VariantType.new("{sv}");
defer option.free();
builder.open(option);
defer builder.close();
builder.add("s", "ask");
const ask = glib.Variant.newBoolean(@intFromBool(false));
builder.add("v", ask);
}
}
break :payload builder.end();
};
// We're expecting an object path back from the method call.
const reply_type = glib.VariantType.new("(o)");
defer reply_type.free();
dbus.call(
"org.freedesktop.portal.Desktop",
"/org/freedesktop/portal/desktop",
"org.freedesktop.portal.OpenURI",
"OpenURI",
payload,
reply_type,
.{},
-1,
null,
requestCallback,
request,
);
}
/// Process the result of the original method call. Receiving this result does
/// not indicate that the that the method call succeeded but it may contain an
/// error message that is useful to log for debugging purposes.
fn requestCallback(
source: ?*gobject.Object,
result: *gio.AsyncResult,
ud: ?*anyopaque,
) callconv(.c) void {
const request: *RequestData = @ptrCast(@alignCast(ud orelse return));
const self = request.open_uri;
const alloc = self.app.app.allocator();
defer {
request.deinit(alloc);
alloc.destroy(request);
}
const dbus = gobject.ext.cast(gio.DBusConnection, source orelse {
log.err("Open URI request finished without a D-Bus source object", .{});
self.failRequestAndFallback(request);
return;
}) orelse {
log.err("Open URI request finished with an unexpected source object", .{});
self.failRequestAndFallback(request);
return;
};
var err_: ?*glib.Error = null;
defer if (err_) |err| err.free();
const reply_ = dbus.callFinish(result, &err_);
if (err_) |err| {
log.err("Open URI request failed={s} ({})", .{
err.f_message orelse "(unknown)",
err.f_code,
});
self.failRequestAndFallback(request);
return;
}
const reply = reply_ orelse {
log.err("D-Bus method call returned a null value!", .{});
self.failRequestAndFallback(request);
return;
};
defer reply.unref();
const reply_type = glib.VariantType.new("(o)");
defer reply_type.free();
if (reply.isOfType(reply_type) == 0) {
log.warn("Reply from D-Bus method call does not contain an object path!", .{});
self.failRequestAndFallback(request);
return;
}
var object_path: [*:0]const u8 = undefined;
reply.get("(&o)", &object_path);
const token = portal.parseRequestPathToken(std.mem.span(object_path)) orelse {
log.warn("Unable to parse token from the object path {s}", .{object_path});
self.failRequestAndFallback(request);
return;
};
if (token != request.token) {
log.warn("Open URI request returned mismatched token expected={x} actual={x}", .{
request.token,
token,
});
self.failRequestAndFallback(request);
return;
}
self.mutex.lock();
defer self.mutex.unlock();
if (!self.alive) return;
const entry = self.entries.get(token) orelse return;
if (std.mem.eql(u8, request.request_path, std.mem.span(object_path))) return;
log.debug("updating open uri request path old={s} new={s}", .{
request.request_path,
object_path,
});
self.unsubscribeFromResponse(entry);
self.subscribeToResponse(entry, dbus, object_path);
}
/// Handle the response signal from the portal. This should contain the actual
/// results of the method call (success or failure).
fn responseReceived(
_: *gio.DBusConnection,
_: ?[*:0]const u8,
object_path: [*:0]const u8,
_: [*:0]const u8,
_: [*:0]const u8,
params: *glib.Variant,
ud: ?*anyopaque,
) callconv(.c) void {
const self: *OpenURI = @ptrCast(@alignCast(ud orelse {
log.err("OpenURI response received with null userdata", .{});
return;
}));
const alloc = self.app.app.allocator();
const token = portal.parseRequestPathToken(std.mem.span(object_path)) orelse {
log.warn("invalid object path: {s}", .{std.mem.span(object_path)});
return;
};
self.mutex.lock();
defer self.mutex.unlock();
if (!self.alive) return;
const entry = (self.entries.fetchSwapRemove(token) orelse {
log.warn("no entry for token {x}", .{token});
return;
}).value;
defer destroyEntry(alloc, entry);
self.unsubscribeFromResponse(entry);
var response: u32 = 0;
var results: ?*glib.Variant = null;
defer if (results) |variant| variant.unref();
params.get("(u@a{sv})", &response, &results);
switch (response) {
0 => {
log.debug("open uri successful", .{});
},
1 => {
log.debug("open uri request was cancelled by the user", .{});
},
2 => {
log.warn("open uri request ended unexpectedly", .{});
self.app.app.openUrlFallback(entry.kind, entry.uri);
},
else => {
log.err("unrecognized response code={}", .{response});
self.app.app.openUrlFallback(entry.kind, entry.uri);
},
}
}
/// Wait this number of seconds and then clean up any orphaned entries.
const cleanup_timeout = 30;
/// If there is an active cleanup timer, cancel it. This must be called with the
/// mutex locked
fn stopCleanupTimer(self: *OpenURI) void {
assert(!self.mutex.tryLock());
if (self.cleanup_timer) |timer| {
if (glib.Source.remove(timer) == 0) {
log.warn("unable to remove cleanup timer source={d}", .{timer});
}
self.cleanup_timer = null;
}
}
/// Start a timer to clean up any entries that have not received a timely
/// response. If there is already a timer it will be stopped and replaced with a
/// new one. This must be called with the mutex locked.
fn startCleanupTimer(self: *OpenURI) void {
assert(!self.mutex.tryLock());
self.stopCleanupTimer();
self.cleanup_timer = glib.timeoutAddSeconds(cleanup_timeout + 1, cleanup, self);
}
/// The cleanup timer is used to free up any entries that may have failed
/// to get a response in a timely manner.
fn cleanup(ud: ?*anyopaque) callconv(.c) c_int {
const self: *OpenURI = @ptrCast(@alignCast(ud orelse {
log.warn("cleanup called with null userdata", .{});
return @intFromBool(glib.SOURCE_REMOVE);
}));
const alloc = self.app.app.allocator();
self.mutex.lock();
defer self.mutex.unlock();
self.cleanup_timer = null;
if (!self.alive) return @intFromBool(glib.SOURCE_REMOVE);
const now = std.time.Instant.now() catch {
// `now()` should never fail, but if it does, don't crash, just return.
// This might cause a small memory leak in rare circumstances but it
// should get cleaned up the next time a URL is clicked.
return @intFromBool(glib.SOURCE_REMOVE);
};
loop: while (true) {
for (self.entries.entries.items(.value)) |entry| {
if (now.since(entry.start) > cleanup_timeout * std.time.ns_per_s) {
log.warn("open uri request timed out token={x}", .{entry.token});
self.unsubscribeFromResponse(entry);
_ = self.entries.swapRemove(entry.token);
self.app.app.openUrlFallback(entry.kind, entry.uri);
destroyEntry(alloc, entry);
continue :loop;
}
}
break :loop;
}
return @intFromBool(glib.SOURCE_REMOVE);
}