mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-07-31 04:39:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

terminal: avoid copying set lookup items

Browse Source 
Keep the resident RefCountedSet item behind a pointer while probing. The
previous value copy materialized the complete generic item before checking
its metadata and equality, which is especially costly for terminal styles.

ReleaseFast timings are seven-run median user CPU times.

| Workload | Before | After | Change |
| --- | ---: | ---: | ---: |
| 128 styles, live lookup | 0.80s | 0.74s | -7.5% |
| 4,096 styles, live lookup | 0.92s | 0.87s | -5.4% |
| Alternating SGR stream | 1.21s | 1.20s | -0.8% |
This commit is contained in:
Mitchell Hashimoto
2026-07-11 19:53:19 -07:00
parent c68d27c5fa
commit 498533d663
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/terminal/ref_counted_set.zig
View File

@@ -560,7 +560,7 @@ pub fn RefCountedSet(
return null;
}
const item = items[id];
const item = &items[id];
// An item with a shorter probe sequence length would never
// end up in the middle of another sequence, since it would