mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-08-24 16:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

shell-integration: avoid owning temporary commands (#13919)

Browse Source 
Some shell setup functions previously converted their stack-backed
command builders to owned sentinel slices before duplicating them into
the result arena. Duplicate the builders' written bytes directly
instead, avoiding unnecessary ownership transfer and sentinel handling.
This commit is contained in:
Mitchell Hashimoto
2026-08-19 15:18:05 -07:00
committed by GitHub
parent 49e503fd40 8e8d76b634
commit 50d3ac8ed6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/termio/shell_integration.zig
View File

@@ -407,7 +407,7 @@ fn setupBash(
}
// Return a copy of our modified command line to use as the shell command.
return .{ .shell = try alloc.dupeZ(u8, try cmd.toOwnedSlice()) };
return .{ .shell = try alloc.dupeZ(u8, cmd.buffer.written()) };
}
test "bash" {
@@ -839,7 +839,7 @@ fn setupNushell(
}
// Return a copy of our modified command line to use as the shell command.
return .{ .shell = try alloc.dupeZ(u8, try cmd.toOwnedSlice()) };
return .{ .shell = try alloc.dupeZ(u8, cmd.buffer.written()) };
}
test "nushell" {