mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-04-06 07:38:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

macOS: fix upper cased letter is not correctly mapped to menu shortcut

Browse Source
This commit is contained in:
Lukas
2026-04-01 14:50:53 +02:00
parent b7e56044db
commit 702a2b43c3
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
macos/Sources/Ghostty/Ghostty.Input.swift
View File

@@ -29,8 +29,11 @@ extension Ghostty {
}
case GHOSTTY_TRIGGER_UNICODE:
guard let scalar = UnicodeScalar(trigger.key.unicode) else { return nil }
key = KeyEquivalent(Character(scalar))
guard
let scalar = UnicodeScalar(trigger.key.unicode),
let normalized = Character(scalar).lowercased().first
else { return nil }
key = KeyEquivalent(normalized)
case GHOSTTY_TRIGGER_CATCH_ALL:
// catch_all matches any key, so it can't be represented as a KeyboardShortcut

15
macos/Tests/Ghostty/ConfigTests.swift
View File

@@ -220,4 +220,19 @@ struct ConfigTests {
#expect(config.maximize == true)
#expect(config.focusFollowsMouse == true)
}
@Test
func uppercasedLetterShouldBeNormalized() async throws {
let config = try TemporaryConfig("""
keybind=cmd+L=goto_split:left
""")
let shortcut = try #require(config.keyboardShortcut(for: "goto_split:left"))
#expect(shortcut == .init("l", modifiers: [.command]))
let config2 = try TemporaryConfig("""
keybind=cmd+Ä=goto_split:left
""")
let shortcut2 = try #require(config2.keyboardShortcut(for: "goto_split:left"))
#expect(shortcut2 == .init("ä", modifiers: [.command]))
}
}