mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-09-19 12:08:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

embedded: route split and close C APIs through performBindingAction

Browse Source 
macOS menus call ghostty_surface_split, split_focus, and request_close
directly, while keybinds go through Surface.performBindingAction. GTK
already uses that path for splits and close. Route the embedded C APIs
the same way so menus and keybinds share one hook.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Jason Gauci
2026-09-16 14:52:15 -05:00
parent f9a3f24a56
commit a1bf5b5e11
1 changed files with 32 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/apprt/embedded.zig
View File

@@ -2164,16 +2164,30 @@ pub const CAPI = struct {
/// Request that the surface become closed. This will go through the
/// normal trigger process that a close surface input binding would.
export fn ghostty_surface_request_close(ptr: *Surface) void {
ptr.core_surface.close();
// Prefer the binding path so close goes through the same Surface
// hook as a close-surface keybind, rather than a raw close() that
// bypasses it.
const handled = ptr.core_surface.performBindingAction(.{ .close_surface = {} }) catch |err| {
log.err("error requesting close err={}", .{err});
return;
};
if (!handled) ptr.core_surface.close();
}
/// Request that the surface split in the given direction.
export fn ghostty_surface_split(ptr: *Surface, direction: apprt.action.SplitDirection) void {
_ = ptr.app.performAction(
.{ .surface = &ptr.core_surface },
.new_split,
direction,
) catch |err| {
// Menu shortcuts call this C API directly. Route through
// performBindingAction so menus and keybinds share one path,
// matching GTK.
const action: input.Binding.Action = .{
.new_split = switch (direction) {
.right => .right,
.left => .left,
.down => .down,
.up => .up,
},
};
_ = ptr.core_surface.performBindingAction(action) catch |err| {
log.err("error creating new split err={}", .{err});
return;
};
@@ -2184,12 +2198,18 @@ pub const CAPI = struct {
ptr: *Surface,
direction: apprt.action.GotoSplit,
) void {
_ = ptr.app.performAction(
.{ .surface = &ptr.core_surface },
.goto_split,
direction,
) catch |err| {
log.err("error creating new split err={}", .{err});
const action: input.Binding.Action = .{
.goto_split = switch (direction) {
.previous => .previous,
.next => .next,
.up => .up,
.down => .down,
.left => .left,
.right => .right,
},
};
_ = ptr.core_surface.performBindingAction(action) catch |err| {
log.err("error focusing split err={}", .{err});
return;
};
}