mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-09-05 19:08:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix abnormal exit detection on macOS (#7752)

Browse Source 
I made an oopsie with #7705 and omitted the check entirely on macOS when
the original logic only omitted the exit code check.
This commit is contained in:
Mitchell Hashimoto
2025-07-01 12:15:53 -07:00
committed by GitHub
parent eea7088919 fbdaea7456
commit a4005946e1
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Surface.zig
View File

@@ -1002,10 +1002,11 @@ fn childExited(self: *Surface, info: apprt.surface.Message.ChildExited) void {
if (info.runtime_ms <= self.config.abnormal_command_exit_runtime_ms) runtime: {
// On macOS, our exit code detection doesn't work, possibly
// because of our `login` wrapper. More investigation required.
if (comptime builtin.target.os.tag.isDarwin()) break :runtime;
if (comptime !builtin.target.os.tag.isDarwin()) {
// If the exit code is 0 then it was a good exit.
if (info.exit_code == 0) break :runtime;
}
// If the exit code is 0 then we it was a good exit.
if (info.exit_code == 0) break :runtime;
log.warn("abnormal process exit detected, showing error message", .{});
// Update our terminal to note the abnormal exit. In the future we