mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-05-24 05:40:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

renderer: fix preedit range width

Browse Source
This commit is contained in:
dobbylee
2026-04-27 00:49:37 +09:00
parent c74f6d56d1
commit ac67a6160c
1 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/renderer/State.zig
View File

@@ -112,7 +112,7 @@ pub const Preedit = struct {
// If our preedit goes off the end of the screen, we adjust it so
// that it shifts left.
const end = start + w;
const end = if (w > 0) start + (w - 1) else start;
const start_offset = if (end > max) end - max else 0;
return .{
.start = start -| start_offset,
@@ -121,3 +121,41 @@ pub const Preedit = struct {
};
}
};
const test_hangul_ga: u21 = 0xAC00; // U+AC00 HANGUL SYLLABLE GA
test "preedit range covers exact cell width" {
const testing = std.testing;
{
const p: Preedit = .{
.codepoints = &.{.{ .codepoint = 'a' }},
};
const range = p.range(2, 9);
try testing.expectEqual(@as(terminalpkg.size.CellCountInt, 2), range.start);
try testing.expectEqual(@as(terminalpkg.size.CellCountInt, 2), range.end);
try testing.expectEqual(@as(usize, 0), range.cp_offset);
}
{
const p: Preedit = .{
.codepoints = &.{.{ .codepoint = test_hangul_ga, .wide = true }},
};
const range = p.range(2, 9);
try testing.expectEqual(@as(terminalpkg.size.CellCountInt, 2), range.start);
try testing.expectEqual(@as(terminalpkg.size.CellCountInt, 3), range.end);
try testing.expectEqual(@as(usize, 0), range.cp_offset);
}
}
test "preedit range shifts left at right edge" {
const testing = std.testing;
const p: Preedit = .{
.codepoints = &.{.{ .codepoint = test_hangul_ga, .wide = true }},
};
const range = p.range(9, 9);
try testing.expectEqual(@as(terminalpkg.size.CellCountInt, 8), range.start);
try testing.expectEqual(@as(terminalpkg.size.CellCountInt, 9), range.end);
try testing.expectEqual(@as(usize, 0), range.cp_offset);
}