mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-04-14 11:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use underline for preedit texts instead of inverting colors (#10368)

Browse Source 
issue: https://github.com/ghostty-org/ghostty/issues/10366

Presently, IME preediting texts are rendered with inverted colors
styles. This pull request changes that style to adding underlines.

Before
<img width="314" height="60" alt="image"
src="https://github.com/user-attachments/assets/183410c3-06b5-4157-b3a2-37188f507e4c"
/>

After
<img width="320" height="63" alt="image"
src="https://github.com/user-attachments/assets/d50b8898-7db1-4b4e-ad73-0a157f63068c"
/>

If it is preferred that adding configure like `ime-preedit-text-style`
with default value `invert` to keep the current behaviour as is, I can
add such a config (see https://github.com/shivaduke28/ghostty/pull/1 ).

Thanks!

Disclosure: This PR was written primarily by Claude Code.
This commit is contained in:
Mitchell Hashimoto
2026-01-20 08:24:30 -08:00
committed by GitHub
parent 9ec6e9ea9a b0c868811d
commit c4dcb8849e
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/renderer/generic.zig
View File

@@ -3370,10 +3370,6 @@ pub fn Renderer(comptime GraphicsAPI: type) type {
screen_bg: terminal.color.RGB,
screen_fg: terminal.color.RGB,
) !void {
// Preedit is rendered inverted
const bg = screen_fg;
const fg = screen_bg;
// Render the glyph for our preedit text
const render_ = self.font_grid.renderCodepoint(
self.alloc,
@@ -3392,11 +3388,11 @@ pub fn Renderer(comptime GraphicsAPI: type) type {
// Add our opaque background cell
self.cells.bgCell(coord.y, coord.x).* = .{
bg.r, bg.g, bg.b, 255,
screen_bg.r, screen_bg.g, screen_bg.b, 255,
};
if (cp.wide and coord.x < self.cells.size.columns - 1) {
self.cells.bgCell(coord.y, coord.x + 1).* = .{
bg.r, bg.g, bg.b, 255,
screen_bg.r, screen_bg.g, screen_bg.b, 255,
};
}
@@ -3404,7 +3400,7 @@ pub fn Renderer(comptime GraphicsAPI: type) type {
try self.cells.add(self.alloc, .text, .{
.atlas = .grayscale,
.grid_pos = .{ @intCast(coord.x), @intCast(coord.y) },
.color = .{ fg.r, fg.g, fg.b, 255 },
.color = .{ screen_fg.r, screen_fg.g, screen_fg.b, 255 },
.glyph_pos = .{ render.glyph.atlas_x, render.glyph.atlas_y },
.glyph_size = .{ render.glyph.width, render.glyph.height },
.bearings = .{
@@ -3412,6 +3408,12 @@ pub fn Renderer(comptime GraphicsAPI: type) type {
@intCast(render.glyph.offset_y),
},
});
// Add underline
try self.addUnderline(@intCast(coord.x), @intCast(coord.y), .single, screen_fg, 255);
if (cp.wide and coord.x < self.cells.size.columns - 1) {
try self.addUnderline(@intCast(coord.x + 1), @intCast(coord.y), .single, screen_fg, 255);
}
}
/// Sync the atlas data to the given texture. This copies the bytes