mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-04-06 07:38:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

apprt: show title override in command palette jump commands (#10458)

Browse Source 
Relates to https://github.com/ghostty-org/ghostty/discussions/3709

When a surface has a title override set (via `prompt_surface_title`),
the command palette's "Focus:" jump commands now display the override
instead of the terminal title.

**No title override:**
<img width="515" height="265" alt="Screenshot 2026-01-26 at 6 11 56 PM"
src="https://github.com/user-attachments/assets/55f49878-87fd-498d-be4e-098ea42b7aaf"
/>

**With title override**
<img width="519" height="270" alt="Screenshot 2026-01-26 at 6 11 30 PM"
src="https://github.com/user-attachments/assets/e2a293ef-0c29-4fab-94ff-b6b357193321"
/>

**AI DISCLAIMER**

I leveraged Claude Code to understand the codebase, make a plan and
write the first draft of the code. I reviewed and edited the code
written by claude and manually tested the change on iOS.
This commit is contained in:
Mitchell Hashimoto
2026-02-26 07:28:08 -08:00
committed by GitHub
parent e6da439e43 9fe3cc125d
commit e3d68e28c9
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
macos/Sources/Features/Command Palette/TerminalCommandPalette.swift
View File

@@ -143,8 +143,15 @@ struct TerminalCommandPaletteView: View {
let displayColor = color != TerminalTabColor.none ? color : nil
return controller.surfaceTree.map { surface in
let title = surface.title.isEmpty ? window.title : surface.title
let displayTitle = title.isEmpty ? "Untitled" : title
let terminalTitle = surface.title.isEmpty ? window.title : surface.title
let displayTitle: String
if let override = controller.titleOverride, !override.isEmpty {
displayTitle = override
} else if !terminalTitle.isEmpty {
displayTitle = terminalTitle
} else {
displayTitle = "Untitled"
}
let pwd = surface.pwd?.abbreviatedPath
let subtitle: String? = if let pwd, !displayTitle.contains(pwd) {
pwd

7
src/apprt/gtk/class/command_palette.zig
View File

@@ -691,12 +691,12 @@ const Command = extern struct {
defer surface.unref();
const alloc = priv.arena.allocator();
const surface_title = surface.getTitle() orelse "Untitled";
const effective_title = surface.getEffectiveTitle() orelse "Untitled";
j.title = std.fmt.allocPrintSentinel(
alloc,
"Focus: {s}",
.{surface_title},
.{effective_title},
0,
) catch null;
@@ -717,8 +717,7 @@ const Command = extern struct {
defer surface.unref();
const alloc = priv.arena.allocator();
const title = surface.getTitle() orelse "Untitled";
const title = surface.getEffectiveTitle() orelse "Untitled";
const pwd = surface.getPwd();
if (pwd) |p| {