mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2026-05-24 05:40:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

build(xcframework): exclude libghostty-vt headers from GhosttyKit

Browse Source 
The GhosttyKit xcframework previously shipped the entire include/
directory, which pulled in the libghostty-vt headers under
include/ghostty/. Because those headers are not referenced from the
ghostty.h umbrella, Clang's module system emitted "umbrella header for
module 'GhosttyKit' does not include header 'ghostty/vt/*.h'" warnings
in Xcode builds.

Stage only ghostty.h and module.modulemap via addWriteFiles so the
xcframework Headers directory contains exactly the GhosttyKit API,
mirroring the pattern used in GhosttyLibVt.xcframework.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Claude
2026-04-21 14:16:34 +02:00
committed by Lukas
parent 3a1482d1a2
commit e9a196c67b
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/build/GhosttyXCFramework.zig
View File

@@ -53,6 +53,16 @@ pub fn init(
}),
));
// Generate a headers directory with only ghostty.h and the module
// map. We can't use include/ directly because it also contains the
// libghostty-vt headers under include/ghostty/, which would trigger
// "umbrella header does not include header" warnings from Clang's
// module system.
const wf = b.addWriteFiles();
_ = wf.addCopyFile(b.path("include/ghostty.h"), "ghostty.h");
_ = wf.addCopyFile(b.path("include/module.modulemap"), "module.modulemap");
const headers = wf.getDirectory();
// The xcframework wraps our ghostty library so that we can link
// it to the final app built with Swift.
const xcframework = XCFrameworkStep.create(b, .{
@@ -62,24 +72,24 @@ pub fn init(
.universal => &.{
.{
.library = macos_universal.output,
.headers = b.path("include"),
.headers = headers,
.dsym = macos_universal.dsym,
},
.{
.library = ios.output,
.headers = b.path("include"),
.headers = headers,
.dsym = ios.dsym,
},
.{
.library = ios_sim.output,
.headers = b.path("include"),
.headers = headers,
.dsym = ios_sim.dsym,
},
},
.native => &.{.{
.library = macos_native.output,
.headers = b.path("include"),
.headers = headers,
.dsym = macos_native.dsym,
}},
},