Lukas
51cd63871d
macos: passthrough right mouse down event to TabTitleEditor if needed ( #11150 )
2026-03-30 12:22:54 +02:00
Lukas
5c5029b0c4
Revert "macos: add support for middle-click tab close for macos-titlebar-style = tabs ( #11963 )"
...
This reverts commit 5540f5f249 , reversing
changes made to cca4c788ad .
2026-03-30 12:08:49 +02:00
Nicholas Ochoa
3f6683df02
macos: add support for middle-click tab close
2026-03-29 15:19:35 -07:00
Lukas
4f849a1512
macOS: fix window position for the very first window
2026-03-12 15:42:29 +01:00
Lukas
d6dfaf28fe
macOS: support injecting temporary defaults when testing
2026-03-12 13:16:55 +01:00
Lukas
596d502a75
macOS: restore window frame under certain conditions
2026-03-11 17:45:10 +01:00
Lukas
45d360dc68
macOS: set the initial window position after window is loaded
2026-03-11 17:45:09 +01:00
Lukas
de0f2ab22d
macos: add enum type for macos-titlebar-style
2026-03-10 17:15:14 +01:00
chronologos
7629130fb4
macOS: restore keyboard focus after inline tab title edit
...
After finishing an inline tab title edit (via keybind or double-click),
`TabTitleEditor.finishEditing()` calls `makeFirstResponder(nil)` to
clear focus from the text field, leaving the window itself as first
responder. No code path restores focus to the terminal surface, so all
keyboard input is lost until the user clicks into a pane.
Add a `tabTitleEditorDidFinishEditing` delegate callback that fires
after every edit (commit or cancel). TerminalWindow implements it by
calling `makeFirstResponder(focusedSurface)` to hand focus back to the
terminal.
Fixes https://github.com/ghostty-org/ghostty/discussions/11315
Co-Authored-By: Claude <noreply@anthropic.com >
2026-03-10 08:52:00 -07:00
Lukas
661470897e
macos: passthrough right mouse down event to TabTitleEditor if needed
2026-03-03 17:24:56 +01:00
Lukas
205c05d59d
macos: passthrough mouse down event to TabTitleEditor if needed
2026-03-03 17:15:12 +01:00
Lukas
e6e5f3ffe1
macos: finish editing tab title when the window resigns as key window
2026-03-03 16:34:11 +01:00
A-AKB
0db32ab9a8
macos: fix window size/position restoration on Cmd+W close
...
This fixes two overlapping issues regarding window positioning and Cmd+W window closures on macOS:
1. `window-position-x` and `window-position-y` coordinates were being ignored on initial launch because `TerminalWindow.setInitialWindowPosition` depended on the `TerminalController`, which isn't fully attached during `awakeFromNib`. This logic was moved so explicit coordinates are correctly enforced.
2. When closing a window via Cmd+W (leaving the app active), reopening the window would continuously cascade down and to the right rather than restoring to the previous position. It now checks if there are other windows open before cascading.
3. `LastWindowPosition` was updated to save both the frame origin and size (width/height), ensuring that restoring a closed window correctly mimics native AppKit State Restoration size behaviors while honoring explicit configurations.
2026-02-28 01:34:18 +01:00
Mitchell Hashimoto
f5e2561eb7
macos: rename to TabTitleEditor
2026-02-23 08:38:10 -08:00
Mitchell Hashimoto
b6a9d54e98
macos: extract inline title editing to standalone file
2026-02-23 08:38:09 -08:00
MiUPa
879d7cf337
macOS: remove dead tab title edit helper
2026-02-23 08:38:09 -08:00
MiUPa
368e190a41
macOS: defer inline tab rename start to reduce flicker
2026-02-23 08:38:09 -08:00
MiUPa
f6e9b19fd5
macOS: widen inline tab title editor
2026-02-23 08:38:09 -08:00
MiUPa
feee4443da
macOS: add inline tab title editing
2026-02-23 08:38:09 -08:00
MiUPa
daa2a9d0d5
macos: allow renaming tab title on double-click
2026-02-23 08:38:09 -08:00
Jon Parise
b532cd55d6
macos: swiftlint 'trailing_whitespace' rule
2026-02-19 18:56:43 -05:00
Jon Parise
6052f664cf
macos: swiftlint 'opening_brace' rule
2026-02-19 18:53:13 -05:00
Jon Parise
9287a61920
macos: swiftlint 'implicit_optional_initialization' rule
2026-02-19 18:36:38 -05:00
Jon Parise
56d67ce88f
macos: swiftlint 'control_statement' rule
2026-02-19 18:34:37 -05:00
Jon Parise
6ade5df799
macos: swiftlint 'comma' rule
2026-02-19 18:33:34 -05:00
Jon Parise
786bad9774
macos: swiftlint 'colon' rule
2026-02-19 18:32:44 -05:00
Mitchell Hashimoto
3e399a3d35
macos: detect surface tab bar hovers and focus them
2025-12-30 15:07:27 -08:00
Lukas
1c90af3569
macOS: move NSGlassEffectView into TerminalViewContainer
2025-12-26 11:44:30 +01:00
Mitchell Hashimoto
2415116ad0
Revert "macOS: move NSGlassEffectView into TerminalViewContainer ( #10046 )"
...
This reverts commit b8490f40c5 , reversing
changes made to 050278feae .
2025-12-25 13:52:59 -08:00
Lukas
574ee470bd
macOS: move NSGlassEffectView into TerminalViewContainer
2025-12-24 23:10:31 +01:00
Mitchell Hashimoto
95f4093e96
macos: make syncAppearance a virtual method on BaseTerminalController
2025-12-16 12:59:56 -08:00
himura467
4c6d3f8ed2
macos: add toggle_background_opacity keybind action
2025-12-16 11:32:10 -08:00
Mitchell Hashimoto
8482e0777d
macos: remove glass view on syncAppearance with blur
2025-12-15 10:58:35 -08:00
Mitchell Hashimoto
a6ddf03a2e
remove the macos-background-style config
2025-12-15 10:54:35 -08:00
Justy Null
42493de098
fix: make titlebar transparent when using glass background style
2025-12-15 10:12:36 -08:00
Mitchell Hashimoto
d5c378cd6b
minor style tweaks
2025-12-15 10:12:36 -08:00
Justy Null
45aceace72
fix: disable renderer background when macOS effects are enabled
2025-12-15 10:12:11 -08:00
Justy Null
d40af61960
refactor: migrate background glass effect to new macos-background-style config
2025-12-15 10:10:51 -08:00
Justy Null
a02364cbef
feat: add liquid glass background effect support
2025-12-15 10:10:51 -08:00
Mitchell Hashimoto
ddaf307cf7
macos: more strict detection for tab context menu
...
We were accidentally modifying the "View" menu.
2025-12-12 14:05:46 -08:00
Mitchell Hashimoto
65c5e72d3e
macos: add tab title change to tab context menu
2025-12-11 16:24:50 -08:00
Mitchell Hashimoto
4d757f0f28
macos: show tab color as header for menu item so its not grey
2025-12-11 14:43:26 -08:00
Mitchell Hashimoto
89bdee447f
macos: selected color in tab color menu should use target's color
2025-12-11 14:33:50 -08:00
Mitchell Hashimoto
2331e17835
macos: change tab color label to circle
2025-12-11 14:18:57 -08:00
Mitchell Hashimoto
f71a25a621
macos: make the tab color indicator SwiftUI
2025-12-11 13:57:39 -08:00
Mitchell Hashimoto
c83bf1de75
macos: simplify terminal controller a bunch
2025-12-11 13:50:24 -08:00
Mitchell Hashimoto
1073e89a0d
macos: move context menu stuff in terminal window down to an ext
2025-12-11 13:40:01 -08:00
Mitchell Hashimoto
f559bccc38
macos: clean up setting up the tab menu by using an NSMenu extension
2025-12-11 13:36:49 -08:00
Mitchell Hashimoto
a0089702f1
macos: convert tab color view to SwiftUI
2025-12-11 13:27:51 -08:00
Mitchell Hashimoto
51589a4e02
macos: move TerminalTabColor to its own file
2025-12-11 07:23:51 -08:00