Commit Graph

16783 Commits

Author SHA1 Message Date
Mitchell Hashimoto
6b09bb3fca terminal/snapshot: ignore hex files in typos
Exclude annotated snapshot fixture hex files from typo checking. Their arbitrary binary byte sequences can otherwise be misidentified as misspelled words.
2026-07-31 13:21:53 -07:00
Mitchell Hashimoto
05d4934848 terminal/snapshot: better root export
Expose complete encode and decode entry points directly from terminal.snapshot instead of requiring terminal.snapshot.snapshot. Reorder the decode APIs to accept the allocator and I/O context before the reader.
2026-07-31 13:16:42 -07:00
Mitchell Hashimoto
e2e74fecbe terminal/snapshot: move history size hints to screen record
Publish each screen's logical history extent before READY so clients can size scrollbars while older pages are still arriving. Keep the value advisory and continue deriving native PageList totals from decoded pages.

Reduce HISTORY to its structural screen key and page count, and update the format documentation, Kaitai schema, verifier, and versioned fixtures.
2026-07-31 11:57:58 -07:00
Mitchell Hashimoto
d37e1fe184 terminal/snapshot: format doesn't require EOF
Treat FINISH as the self-delimiting snapshot boundary instead of peeking for end-of-file. Normal decoding now leaves continuation bytes unread, allowing snapshots and live protocol data to share a stream without waiting for closure.

Add decodeExact for bounded files that still require strict exhaustion, and update the Kaitai schema, documentation, and tests for continuation and sequential snapshot decoding.
2026-07-31 11:46:07 -07:00
Mitchell Hashimoto
f0fe788fcc terminal/snapshot: less buffering, better stream writing
Stream complete snapshot records to any std.Io.Writer while retaining one reusable payload buffer for length and CRC calculation. Update BLAKE3 incrementally so checkpoints no longer require rehashing an allocating destination.

Wrap decode hashing in StreamReader to enforce exact checkpoint boundaries. Preserve v1 bytes while allowing snapshots to begin at the current writer position and retaining only valid prefixes on failures.
2026-07-31 11:27:11 -07:00
Mitchell Hashimoto
58e92098a2 terminal/snapshot: snapshot robustness
Route HISTORY sequences by their encoded screen key so both keyed sequence groups can arrive in either order. Keep undeclared and duplicate routing strict, separate HISTORY manifest parsing from page restoration, and clear decoder-only generation state before returning the terminal.
2026-07-31 10:57:28 -07:00
Mitchell Hashimoto
9d1c6a9217 terminal/snapshot: terminal robustness
Normalize unknown terminal-wide semantic fields during restore while keeping dimensions and screen count structural. Preserve canonical encoding, ignore reserved mode and tab-stop bits, reset invalid color and scrolling state, and clamp finite scrollback policies to the native range.
2026-07-31 10:53:23 -07:00
Mitchell Hashimoto
7c64181b69 terminal/snapshot: history robustness
Treat HISTORY row counts as canonical metadata rather than a reason to reject otherwise usable history. Restore topology from the declared PAGE sequence while keeping record framing, routing keys, and sequence boundaries strict.
2026-07-31 10:47:05 -07:00
Mitchell Hashimoto
a44eb83358 terminal/snapshot: style/hyperlink robustness in page and screen
Keep the standalone style and hyperlink codecs strict while allowing PAGE and SCREEN decoders to discard invalid optional data at boundaries they own. Normalize invalid styles to defaults, ignore unrepresentable hyperlinks, reuse duplicate entries, and validate hyperlink values before encoding.
2026-07-31 09:59:42 -07:00
Mitchell Hashimoto
465488d6b4 terminal/snapshot: screen robustness
Keep SCREEN encoding strict while allowing decoding to recover from unknown or noncanonical semantic state. Cursor positions now clamp to the restored active area, and invalid enum values, reserved bits, and optional state degrade to native defaults.
2026-07-31 09:41:04 -07:00
Mitchell Hashimoto
a508720a89 terminal/snapshot: grid decode robustness principle
Keep snapshot grid encoding strict by rejecting malformed wide-cell relationships before they can produce invalid wire data.

Decode untrusted grids liberally while preserving record alignment. Unknown semantic values and content kinds degrade to safe defaults, optional graphemes and hyperlinks are dropped when invalid or over capacity, and malformed wide-cell markers normalize to narrow cells.
2026-07-31 09:29:10 -07:00
Mitchell Hashimoto
f8ac0ca98f terminal/snapshot: accept kitty placeholder cells, track rows
Treat Kitty virtual placeholder codepoints as ordinary valid grid content during snapshot restore and derive the native row lookup hint from decoded cells. Image and placement registries remain intentionally omitted.

Cover the behavior with a complete snapshot round trip containing a real virtual placement and its grapheme diacritics.
2026-07-31 08:16:35 -07:00
Mitchell Hashimoto
66ea61dd9d ci: verify snapshot kaitai
Run the snapshot Kaitai verifier in its own required xsm job. This gives schema, fixture, checksum, and cross-record validation a distinct CI result without coupling it to the libghostty-vt test suite.
2026-07-30 21:10:14 -07:00
Mitchell Hashimoto
38d92c50c9 terminal/snapshot: kaitai verification
Describe the complete version 1 snapshot format with a Kaitai schema and make every golden fixture self-describing for automatic discovery. Add a verifier that compiles the schema, parses all fixtures, and checks record checksums, checkpoint digests, and cross-record invariants.

Preserve Kaitai metadata when generating fixture candidates and provide the compiler and Python runtime dependencies through the development shell. Keep the mode registry portable to Kaitai JavaScript targets so the complete fixture also works in the web IDE.
2026-07-30 21:02:19 -07:00
Mitchell Hashimoto
13bc78b7f3 terminal/snapshot: grid tests 2026-07-30 20:16:46 -07:00
Mitchell Hashimoto
627f343097 build: helpgen needs terminal options 2026-07-30 15:48:15 -07:00
Mitchell Hashimoto
32f11a4663 terminal/snapshot: test fixtures 2026-07-30 15:14:14 -07:00
Mitchell Hashimoto
92c8dfd508 terminal/snapshot: clean up tests 2026-07-30 13:22:15 -07:00
Mitchell Hashimoto
43ec9b373b terminal/snapshot: harden hyperlink decoding, allow invalid hyperlinks for page 2026-07-30 13:07:25 -07:00
Mitchell Hashimoto
b867a0f59e terminal/snapshot: use lib.Enum enums where possible 2026-07-30 12:58:02 -07:00
Mitchell Hashimoto
86ec146334 terminal/snapshot: full encode/decode 2026-07-30 11:24:38 -07:00
Mitchell Hashimoto
83e482700b terminal/snapshot: ready/finish checkpoints 2026-07-30 11:24:38 -07:00
Mitchell Hashimoto
0288bec3cf terminal/snapshot: terminal record 2026-07-30 11:24:37 -07:00
Mitchell Hashimoto
7d91b87766 terminal/snapshot: history record 2026-07-30 11:24:37 -07:00
Mitchell Hashimoto
d34fd0593e terminal/snapshot: screen decoding 2026-07-30 11:24:37 -07:00
Mitchell Hashimoto
f50bdfab20 terminal/snapshot: screen plus active encoding 2026-07-30 11:22:48 -07:00
Mitchell Hashimoto
6508cbbb49 terminal/snapshot: screen record 2026-07-30 11:22:48 -07:00
Mitchell Hashimoto
e8e56e782c terminal/snapshot: small edits 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
83ffa74e2b terminal/snapshot: page records 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
406f5e7d82 terminal/snapshot: encode sparse page grids 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
2fc238ed01 terminal/snapshot: decode directly into pages 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
d44baa9147 terminal/snapshot: setup the snapshot main 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
805c3b0baf terminal/snapshot: start page encoding 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
b4fd26f0d9 terminal/snapshot: hyperlink and style encoding 2026-07-30 11:22:47 -07:00
Mitchell Hashimoto
fdf8dfd7b1 terminal/snapshot: define v0 record framing 2026-07-30 11:22:46 -07:00
Mitchell Hashimoto
4d605bf0d8 Misc improvements for future binary snapshot API (#13525)
Extracted out the raw `src/terminal` changes needed for the future
snapshot work, 4 separate changes. These are uncontroversial and
relatively simple, summarized below. Tests AI assisted but the rest
including commit messages, this PR message, etc. all organic.

* **Add iterator to ref counted set.** Iterate over live entries and
their IDs. Const, doesn't mutate the set.
* **lib.Enum produces stable enums for Zig.** Basically the same as C
except it uses the smallest fitting integer including the holes.
* **PageList: a couple helpers for manually creating pages.** There is
`PageList.Builder` for creating a new pagelist and
`PageList.allocatePage` for modifying an existing one. This allows
PageList construction from raw pages.
2026-07-30 11:21:45 -07:00
Mitchell Hashimoto
457c5a0a64 terminal: PageList align Builder/PageAllocation APIs better
Rename Builder.addPage and PageAllocation.cancel to their consistent allocatePage and deinit forms. Track successful ownership transfers so both builder APIs can use unconditional deferred cleanup without releasing pages transferred to a PageList.
2026-07-30 11:02:12 -07:00
Mitchell Hashimoto
506de8517a terminal: fix string capacity check in hyperlink reflow (#13524)
Fixes #13522

Fixes unreachable when reflow dupes a hyperlink into a destination page
whose string allocator is nearly full.

The capacity precondition in ReflowCursor.writeCell performed a single
test allocation of `uri.len + id.len` bytes before duping a hyperlink
into the destination page. But PageEntry.dupe allocates the URI and the
explicit ID as two separate allocations, and the string allocator rounds
every allocation up to its 32-byte chunk size independently, so the two
separate allocations can require one more chunk than the single combined
test allocation.

Write a new helper to make sure we get the right amount of space using
the same allocation pattern of dupe.

**AI note:** Verified upstream via Fable. I told it to ignore any
conclusions and do its own validation and fix suggestion. It did
validate it with a failing test which I studied. It implement a fix, I
rewrote it to be more idiomatic.
2026-07-30 09:45:58 -07:00
Mitchell Hashimoto
d5c7e54ae4 terminal: fix string capacity check in hyperlink reflow
Fixes #13522

Fixes unreachable when reflow dupes a hyperlink into a destination page 
whose string allocator is nearly full.

The capacity precondition in ReflowCursor.writeCell performed a single
test allocation of `uri.len + id.len` bytes before duping a hyperlink
into the destination page. But PageEntry.dupe allocates the URI and
the explicit ID as two separate allocations, and the string allocator
rounds every allocation up to its 32-byte chunk size independently, so
the two separate allocations can require one more chunk than the
single combined test allocation.

Write a new helper to make sure we get the right amount of space
using the same allocation pattern of dupe.
2026-07-30 09:36:20 -07:00
Mitchell Hashimoto
e77c2612e5 lib: Zig enums have stable values 2026-07-30 08:51:38 -07:00
Mitchell Hashimoto
35db32078b terminal: PageList allocatePage 2026-07-30 07:22:03 -07:00
ghostty-vouch[bot]
70c498ac32 Update VOUCHED list (#13521)
Triggered by [discussion
comment](https://github.com/ghostty-org/ghostty/discussions/13520#discussioncomment-17837792)
from @pluiedev.

Vouch: @carlvillads

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-07-30 08:51:35 +00:00
ghostty-vouch[bot]
96e39f8235 Update VOUCHED list (#13518)
Triggered by [discussion
comment](https://github.com/ghostty-org/ghostty/discussions/13516#discussioncomment-17834904)
from @jcollie.

Vouch: @fallintoplace

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-07-30 03:17:51 +00:00
Mitchell Hashimoto
fc1bd06a1a terminal: PageList builder to build from raw pages 2026-07-29 14:04:39 -07:00
Mitchell Hashimoto
6ad1fe7d8c url: exclude trailing spaces from path matches (#13505)
This change improves the user experience for Pi TUI users on macOS.

As a user of Ghostty 1.3.1, Pi 0.80.7, and macOS 26.5, I noticed that
Command-click was not working.

With Pi's help (GPT-5.6 Terra High), I narrowed the cause down to Pi's
redraw
behavior and `src/config/url.zig`'s regular expression. More details are
in
[Vouch Request
#13491](https://github.com/ghostty-org/ghostty/discussions/13491).

The `trailing_spaces_at_eol` behavior in `src/config/url.zig` was
introduced in
[PR #9921](https://github.com/ghostty-org/ghostty/pull/9921) while
improving
Command-click handling for relative and local paths. The concern about
matching
trailing whitespace was also noted in [a review
comment](https://github.com/ghostty-org/ghostty/pull/9921#issuecomment-3661107609).

However, supporting file paths with trailing spaces does not seem like a
good
trade-off because it blocks Command-click for file paths displayed by Pi
TUI.

This PR removes that behavior.

I tested this on my Mac with a patched Ghostty build, and Command-click
worked
correctly for file paths in Pi TUI.

AI disclosure: I used Pi with GPT-5.6 Terra High to investigate and
implement this change.
I reviewed the code and tested the result myself.
2026-07-29 08:18:20 -07:00
Jeffrey C. Ollie
adfef29776 wayland/Hotkeys: polish & simplify (#13512)
I've come up with a way to avoid manually allocating each entry which
honestly makes the code flow much more smoothly. Basically you collect
all the applicable keybinds first, then try to bind them with their
stable memory addresses.
2026-07-29 10:10:34 -05:00
Leah Amelia Chen
c3b5cab941 wayland/Hotkeys: polish & simplify
I've come up with a way to avoid manually allocating each entry which
honestly makes the code flow much more smoothly. Basically you collect
all the applicable keybinds first, then try to bind them with their
stable memory addresses.
2026-07-29 22:18:55 +08:00
ghostty-vouch[bot]
a34bf0dce7 Update VOUCHED list (#13511)
Triggered by [discussion
comment](https://github.com/ghostty-org/ghostty/discussions/13508#discussioncomment-17828581)
from @jcollie.

Vouch: @simonbcn

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-07-29 14:17:15 +00:00
Mitchell Hashimoto
ae8727401d docs: clarify macOS dependencies (#13498)
reword: The doc said "macOS doesn't need any dependencies" and then
immediately listed things you needed to install for macOS 😁. This is
just rewording the doc to be more consistent.
2026-07-28 20:02:19 -07:00
Mitchell Hashimoto
6bbbf59e9f update zig-gobject to 0.3.2 (#13502)
Includes better ZIg 0.16 compat and updates for Gnome 50.
2026-07-28 20:02:06 -07:00