Louis Qian
90d71dd2f6
chore: clean up comments
2026-03-30 18:49:17 -07:00
Louis Qian
b29f261dc8
chore: clean up versionConfig to be init-able
2026-03-30 18:44:49 -07:00
Louis Qian
ed6f0588a3
feat: make version clickable depending on type
2026-03-30 18:41:26 -07:00
Mitchell Hashimoto
d643792f36
macOS: add keyboard shortcut test ( #11986 )
...
This is the first step (also another step forward for completing #7879 )
to fix various responder issues regarding keyboard shortcuts. I tried my
best to separate changes chunk by chunk; there will follow up pr based
on this to fix them.
This pr doesn't change any existing behaviours/flaws, but following
changes will be easier to review after this.
## AI Disclosure
Claude wrote most of the test cases
2026-03-30 09:20:35 -07:00
Mitchell Hashimoto
1672e891b9
macOS: remove redundant tab event overrides ( #11984 )
...
- Revert 5540f5f249894e8d91baffe4afe538#11150
https://github.com/user-attachments/assets/8660368e-05ae-45b0-aa81-6196f3434daf
2026-03-30 09:19:33 -07:00
Lukas
de8139bbc3
macOS: move MenuShortcutManager to a separate file
2026-03-30 16:10:06 +02:00
Lukas
1845dd26b6
macOS: extract menu shortcut syncing into MenuShortcutManager
2026-03-30 16:09:21 +02:00
Lukas
65cd31dc79
macOS: add NormalizedMenuShortcutKeyTests
2026-03-30 15:47:07 +02:00
Lukas
5c5f645b61
macOS: support reloading temporary config for testing
2026-03-30 15:47:07 +02:00
Lukas
51cd63871d
macos: passthrough right mouse down event to TabTitleEditor if needed ( #11150 )
2026-03-30 12:22:54 +02:00
Lukas
5de30c0dce
Revert "macOS: fix tab context menu opens on macOS 26 with titlebar tabs ( #9831 )"
...
This reverts commit 894e8d91ba4a173052fb
2026-03-30 12:09:51 +02:00
Lukas
5c5029b0c4
Revert "macos: add support for middle-click tab close for macos-titlebar-style = tabs ( #11963 )"
...
This reverts commit 5540f5f249cca4c788ad
2026-03-30 12:08:49 +02:00
Lukas
013579cfcf
macOS: fix initial focus of command palette when building with Xcode 26.4
...
Tip works fine, but I've tried release and debug build with Xcode 26.4, it failed to focus as expected
2026-03-30 10:03:09 +02:00
Lukas
32920b6b2a
macOS: handle surface focus more gracefully
...
This will fix surface focus state is not consistent with first responder state when the search bar is open
2026-03-30 10:03:09 +02:00
Nicholas Ochoa
3f6683df02
macos: add support for middle-click tab close
2026-03-29 15:19:35 -07:00
Lukas
ad0c5fbec3
macOS: fix regression caused by 3ee8ef4f65
2026-03-26 19:58:18 +01:00
Lukas
95ee878904
macOS: add test case for search bar focus change
2026-03-26 19:58:18 +01:00
Lukas
d80d84862e
macOS: fix mouse not working correctly in CommandPaletteView ( #11658 )
2026-03-19 19:26:58 +01:00
Lukas
ac3893d0b9
macOS: Add command palette tests
2026-03-19 19:26:57 +01:00
Lukas
50113ab678
macOS: add mouse state tests for #11276
...
It will fail on 4e24adf71#11276
2026-03-19 19:02:13 +01:00
Mitchell Hashimoto
f3ac604fff
macos: select tab applescript command should not activate application ( #11459 )
...
Related to #11457
2026-03-13 08:53:53 -07:00
Mitchell Hashimoto
4c4e83784c
macos: new tab applescript command should not activate application
...
Related to #11457
2026-03-13 08:49:22 -07:00
Lukas
5c51603b0b
chore: make ci happy
2026-03-12 20:02:23 +01:00
Lukas
07bc888682
macOS: fix window position when dragging split into a new window
2026-03-12 19:54:41 +01:00
Lukas
3022aa05ea
macOS: add test cases for drag-split
2026-03-12 19:54:12 +01:00
Lukas
d6d6fe4e58
macOS: update window cascading
...
Make it smaller and add comparisons between y values
2026-03-12 18:58:37 +01:00
Lukas
5e3866381b
macOS: fix window cascading for the second window
2026-03-12 18:32:04 +01:00
Lukas
ea262cdd34
macOS: fix window cascading for 3rd+ window
2026-03-12 18:32:04 +01:00
Lukas
77c2acf843
macOS: add test case for window cascading without moving the window
2026-03-12 18:32:04 +01:00
Lukas
08107d342a
macOS: we don't need initialFrame anymore
2026-03-12 15:42:29 +01:00
Lukas
4f849a1512
macOS: fix window position for the very first window
2026-03-12 15:42:29 +01:00
Lukas
c399812036
macOS: add test case for positioning the very first window
2026-03-12 15:42:28 +01:00
Lukas
d6dfaf28fe
macOS: support injecting temporary defaults when testing
2026-03-12 13:16:55 +01:00
Mitchell Hashimoto
ab269e2c79
config: add progress-style option ( #11289 )
...
Adds progress-style config to control OSC 9;4 progress bar visibility.
Defaults to true, set false to hide.
Fixes #11241
AI Disclosure: Claude Code (Opus 4.6) used for codebase exploration,
code review, and testing assistance. All code written and reviewed by
hand.
2026-03-11 20:46:59 -07:00
Mitchell Hashimoto
8093695055
macos: only run key equivalents for Ghostty-owned menu items
...
Fixes #11396
Track menu items populated from Ghostty keybind actions and only trigger
those from SurfaceView performKeyEquivalent. This avoids app-default
shortcuts such as Hide from pre-empting explicit keybinds.
2026-03-11 19:59:56 -07:00
Michal Olechowski
84d48d1c6a
config: add progress-style option
...
Add option to disable OSC 9;4 ConEmu progress bars via config.
Fixes #11241
2026-03-12 01:33:25 +01:00
Mitchell Hashimoto
fe98f3884d
macos: only show split grab handle when the mouse is near it
...
Fixes #11379
For this pass, I made it a very simple "within 20%" (height-wise) of the
split handle. There is no horizontal component. I want to find the right
balance between always visible (today mostly) to only visible on direct
hover, because I think it'll be too hard to discover on that far right
side.
2026-03-11 10:48:09 -07:00
Mitchell Hashimoto
19e5053b28
macos: only show the grab handle in fullscreen if there are splits ( #11381 )
...
Fixes #11376
2026-03-11 10:08:25 -07:00
Mitchell Hashimoto
12bc1e7860
macos: only show the grab handle in fullscreen if there are splits
...
Fixes #11376
2026-03-11 10:02:09 -07:00
Lukas
596d502a75
macOS: restore window frame under certain conditions
2026-03-11 17:45:10 +01:00
Lukas
45d360dc68
macOS: set the initial window position after window is loaded
2026-03-11 17:45:09 +01:00
Lukas
e8c82ca1af
macOS: save frame only if the window is visible
2026-03-11 17:45:09 +01:00
Lukas
0af9938ad2
macos: add UI test for window position restore across titlebar styles
...
Tests that window position and size are correctly restored after
reopen for all four macos-titlebar-style variants.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-11 17:45:09 +01:00
Mitchell Hashimoto
86c2a2e87f
input: add direct set_surface_title and set_tab_title actions
...
Fixes #11316
This mirrors the `prompt` actions (hence why there is no window action
here) and enables setting titles via keybind actions which importantly
lets this work via command palettes, App Intents, AppleScript, etc.
2026-03-11 09:25:08 -07:00
ydah
c2206542d3
macos: fix tab title rename hit testing and focus handling in fullscreen mode
2026-03-11 07:24:49 -07:00
Mitchell Hashimoto
6dd5b856b0
macos: disable Tahoe one-time codes
...
This disables all the automatic one-time code inputs in Ghostty.
It'd be really neat to actually dynamically change this (not sure if its
possible with NSTextContext or how often thats cached) but for now we
should just fully disable it.
2026-03-10 19:41:22 -07:00
Lukas
90dc4315e2
macos: add test cases for Ghostty.Config properties
...
Test boolean, string, enum, and numeric config properties using
TemporaryConfig to verify defaults and parsed values.
Co-Authored-By: Claude <noreply@anthropic.com >
2026-03-10 20:03:17 +01:00
Lukas
32934445cf
macos: add TemporaryConfig for AI to write test cases
2026-03-10 19:45:52 +01:00
Mitchell Hashimoto
71f81527ad
macos: remove IntrinsicSizeTimingTests temporarily
...
These were too flaky.
2026-03-10 11:08:47 -07:00
Mitchell Hashimoto
f88b42ad39
macos: add enum type for macos-titlebar-style ( #11262 )
2026-03-10 10:58:47 -07:00
