chore: upgrade eslint plugins, remove eslint-plugin-github (#38046)

- Bump `eslint`, `typescript-eslint` and `eslint-plugin-unicorn` (to v68), and configure the rules added in unicorn v66/v67/v68. - Remove `eslint-plugin-github` and its workarounds (rules, type stub, pnpm peer override, in-code `eslint-disable` comments); the rules worth keeping are covered by `unicorn` equivalents. - Apply the resulting fixes and autofixes across the JS codebase. _Prepared with Claude (Opus 4.8)._ --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2026-06-22 03:03:44 +00:00 · 2026-06-21 08:07:13 +02:00
parent 5368542f8e
commit 804b9bf120
54 changed files with 622 additions and 840 deletions
--- a/eslint.config.ts
+++ b/eslint.config.ts
@@ -1,7 +1,6 @@
 import arrayFunc from 'eslint-plugin-array-func';
 import comments from '@eslint-community/eslint-plugin-eslint-comments';
 import deMorgan from 'eslint-plugin-de-morgan';
-import github from 'eslint-plugin-github';
 import globals from 'globals';
 import importPlugin from 'eslint-plugin-import-x';
 import playwright from 'eslint-plugin-playwright';
@@ -72,7 +71,6 @@ export default defineConfig([
      regexp,
      sonarjs,
      unicorn,
-      github,
      wc,
    },
    settings: {
@@ -86,7 +84,6 @@ export default defineConfig([
      '@eslint-community/eslint-comments/no-duplicate-disable': [2],
      '@eslint-community/eslint-comments/no-restricted-disable': [0],
      '@eslint-community/eslint-comments/no-unlimited-disable': [2],
-      '@eslint-community/eslint-comments/no-unused-disable': [2],
      '@eslint-community/eslint-comments/no-unused-enable': [2],
      '@eslint-community/eslint-comments/no-use': [0],
      '@eslint-community/eslint-comments/require-description': [0],
@@ -193,7 +190,6 @@ export default defineConfig([
      '@typescript-eslint/no-duplicate-type-constituents': [2, {ignoreUnions: true}],
      '@typescript-eslint/no-dynamic-delete': [0],
      '@typescript-eslint/no-empty-function': [0],
-      '@typescript-eslint/no-empty-interface': [0],
      '@typescript-eslint/no-empty-object-type': [2],
      '@typescript-eslint/no-explicit-any': [0],
      '@typescript-eslint/no-extra-non-null-assertion': [2],
@@ -206,7 +202,6 @@ export default defineConfig([
      '@typescript-eslint/no-invalid-this': [0],
      '@typescript-eslint/no-invalid-void-type': [0],
      '@typescript-eslint/no-loop-func': [0],
-      '@typescript-eslint/no-loss-of-precision': [0],
      '@typescript-eslint/no-magic-numbers': [0],
      '@typescript-eslint/no-meaningless-void-operator': [0],
      '@typescript-eslint/no-misused-new': [2],
@@ -235,7 +230,7 @@ export default defineConfig([
      '@typescript-eslint/no-unsafe-assignment': [0],
      '@typescript-eslint/no-unsafe-call': [0],
      '@typescript-eslint/no-unsafe-declaration-merging': [2],
-      '@typescript-eslint/no-unsafe-enum-comparison': [2],
+      '@typescript-eslint/no-unsafe-enum-comparison': [0],
      '@typescript-eslint/no-unsafe-function-type': [2],
      '@typescript-eslint/no-unsafe-member-access': [0],
      '@typescript-eslint/no-unsafe-return': [0],
@@ -279,7 +274,6 @@ export default defineConfig([
      '@typescript-eslint/strict-void-return': [0],
      '@typescript-eslint/switch-exhaustiveness-check': [0],
      '@typescript-eslint/triple-slash-reference': [2],
-      '@typescript-eslint/typedef': [0],
      '@typescript-eslint/unbound-method': [0], // too many false-positives
      '@typescript-eslint/unified-signatures': [2],
      'accessor-pairs': [2],
@@ -312,32 +306,9 @@ export default defineConfig([
      'func-names': [0],
      'func-style': [0],
      'getter-return': [2],
-      'github/a11y-aria-label-is-well-formatted': [0],
-      'github/a11y-no-title-attribute': [0],
-      'github/a11y-no-visually-hidden-interactive-element': [0],
-      'github/a11y-role-supports-aria-props': [0],
-      'github/a11y-svg-has-accessible-name': [0],
-      'github/array-foreach': [0],
-      'github/async-currenttarget': [2],
-      'github/async-preventdefault': [0], // https://github.com/github/eslint-plugin-github/issues/599
-      'github/authenticity-token': [0],
-      'github/get-attribute': [0],
-      'github/js-class-name': [0],
-      'github/no-blur': [0],
-      'github/no-d-none': [0],
-      'github/no-dataset': [2],
-      'github/no-dynamic-script-tag': [2],
-      'github/no-implicit-buggy-globals': [2],
-      'github/no-inner-html': [0],
-      'github/no-innerText': [2],
-      'github/no-then': [2],
-      'github/no-useless-passive': [2],
-      'github/prefer-observers': [0],
-      'github/require-passive-events': [2],
-      'gitea/unescaped-html-literal': [2],
      'grouped-accessor-pairs': [2],
      'guard-for-in': [0],
-      'id-blacklist': [0],
+      'id-denylist': [0],
      'id-length': [0],
      'id-match': [0],
      'import-x/consistent-type-specifier-style': [0],
@@ -384,7 +355,6 @@ export default defineConfig([
      'import-x/prefer-default-export': [0],
      'import-x/unambiguous': [0],
      'init-declarations': [0],
-      'line-comment-position': [0],
      'logical-assignment-operators': [0],
      'max-classes-per-file': [0],
      'max-depth': [0],
@@ -393,14 +363,12 @@ export default defineConfig([
      'max-nested-callbacks': [0],
      'max-params': [0],
      'max-statements': [0],
-      'multiline-comment-style': [0],
      'new-cap': [0],
      'no-alert': [0],
      'no-array-constructor': [0], // handled by @typescript-eslint/no-array-constructor
      'no-async-promise-executor': [0],
      'no-await-in-loop': [0],
      'no-bitwise': [0],
-      'no-buffer-constructor': [0],
      'no-caller': [2],
      'no-case-declarations': [2],
      'no-class-assign': [2],
@@ -557,12 +525,11 @@ export default defineConfig([
      'no-nested-ternary': [0],
      'no-new-func': [0], // handled by @typescript-eslint/no-implied-eval
      'no-new-native-nonconstructor': [2],
-      'no-new-object': [2],
-      'no-new-symbol': [0], // handled by no-new-native-nonconstructor
      'no-new-wrappers': [2],
      'no-new': [0],
      'no-nonoctal-decimal-escape': [2],
      'no-obj-calls': [2],
+      'no-object-constructor': [2],
      'no-octal-escape': [2],
      'no-octal': [2],
      'no-param-reassign': [0],
@@ -622,10 +589,8 @@ export default defineConfig([
      'no-warning-comments': [0],
      'no-with': [0], // handled by no-restricted-syntax
      'object-shorthand': [2, 'always'],
-      'one-var-declaration-per-line': [0],
      'one-var': [0],
      'operator-assignment': [2, 'always'],
-      'operator-linebreak': [0], // handled by @stylistic/operator-linebreak
      'prefer-arrow-callback': [2, {allowNamedFunctions: true, allowUnboundThis: true}],
      'prefer-const': [2, {destructuring: 'all', ignoreReadBeforeAssign: true}],
      'prefer-destructuring': [0],
@@ -761,139 +726,309 @@ export default defineConfig([
      'strict': [0],
      'symbol-description': [2],
      'unicode-bom': [2, 'never'],
-      'unicorn/better-regex': [0],
+      'unicorn/better-dom-traversing': [2],
      'unicorn/catch-error-name': [0],
+      'unicorn/class-reference-in-static-methods': [2],
+      'unicorn/comment-content': [0],
+      'unicorn/consistent-assert': [0],
+      'unicorn/consistent-boolean-name': [0],
+      'unicorn/consistent-class-member-order': [0],
+      'unicorn/consistent-compound-words': [0], // too opinionated
+      'unicorn/consistent-conditional-object-spread': [2],
+      'unicorn/consistent-date-clone': [2],
      'unicorn/consistent-destructuring': [2],
      'unicorn/consistent-empty-array-spread': [2],
-      'unicorn/consistent-template-literal-escape': [2],
      'unicorn/consistent-existence-index-check': [0],
+      'unicorn/consistent-export-decorator-position': [2],
      'unicorn/consistent-function-scoping': [0],
+      'unicorn/consistent-function-style': [2],
+      'unicorn/consistent-json-file-read': [2],
+      'unicorn/consistent-optional-chaining': [2],
+      'unicorn/consistent-template-literal-escape': [2],
      'unicorn/custom-error-definition': [0],
+      'unicorn/default-export-style': [2],
+      'unicorn/dom-node-dataset': [2, {preferAttributes: true}],
      'unicorn/empty-brace-spaces': [2],
      'unicorn/error-message': [0],
      'unicorn/escape-case': [0],
      'unicorn/expiring-todo-comments': [0],
      'unicorn/explicit-length-check': [0],
+      'unicorn/explicit-timer-delay': [2],
      'unicorn/filename-case': [0],
-      'unicorn/import-index': [0],
+      'unicorn/id-match': [2],
      'unicorn/import-style': [0],
      'unicorn/isolated-functions': [2, {functions: []}],
+      'unicorn/logical-assignment-operators': [0],
+      'unicorn/max-nested-calls': [0],
+      'unicorn/name-replacements': [0],
      'unicorn/new-for-builtins': [2],
      'unicorn/no-abusive-eslint-disable': [0],
+      'unicorn/no-accessor-recursion': [2],
+      'unicorn/no-accidental-bitwise-operator': [2],
      'unicorn/no-anonymous-default-export': [0],
      'unicorn/no-array-callback-reference': [0],
-      'unicorn/no-array-for-each': [2],
+      'unicorn/no-array-concat-in-loop': [2],
+      'unicorn/no-array-fill-with-reference-type': [2],
+      'unicorn/no-array-from-fill': [2],
+      'unicorn/no-array-front-mutation': [0],
      'unicorn/no-array-method-this-argument': [2],
-      'unicorn/no-array-push-push': [2],
      'unicorn/no-array-reduce': [2],
+      'unicorn/no-array-reverse': [0],
+      'unicorn/no-array-sort': [0],
+      'unicorn/no-array-sort-for-min-max': [2],
+      'unicorn/no-array-splice': [0],
+      'unicorn/no-asterisk-prefix-in-documentation-comments': [0],
      'unicorn/no-await-expression-member': [0],
      'unicorn/no-await-in-promise-methods': [2],
+      'unicorn/no-blob-to-file': [2],
+      'unicorn/no-boolean-sort-comparator': [2],
+      'unicorn/no-break-in-nested-loop': [0],
+      'unicorn/no-canvas-to-image': [2],
+      'unicorn/no-chained-comparison': [2],
+      'unicorn/no-collection-bracket-access': [2],
+      'unicorn/no-computed-property-existence-check': [0],
+      'unicorn/no-confusing-array-splice': [2],
+      'unicorn/no-confusing-array-with': [2],
      'unicorn/no-console-spaces': [0],
+      'unicorn/no-constant-zero-expression': [2],
+      'unicorn/no-declarations-before-early-exit': [0],
      'unicorn/no-document-cookie': [2],
+      'unicorn/no-double-comparison': [2],
+      'unicorn/no-duplicate-if-branches': [2],
+      'unicorn/no-duplicate-logical-operands': [2],
+      'unicorn/no-duplicate-loops': [0],
+      'unicorn/no-duplicate-set-values': [2],
      'unicorn/no-empty-file': [2],
+      'unicorn/no-error-property-assignment': [2],
+      'unicorn/no-exports-in-scripts': [2],
+      'unicorn/no-for-each': [2],
      'unicorn/no-for-loop': [0],
-      'unicorn/no-hex-escape': [0],
+      'unicorn/no-global-object-property-assignment': [0],
      'unicorn/no-immediate-mutation': [0],
-      'unicorn/no-instanceof-array': [0],
+      'unicorn/no-impossible-length-comparison': [2],
+      'unicorn/no-incorrect-query-selector': [2],
+      'unicorn/no-incorrect-template-string-interpolation': [0],
+      'unicorn/no-instanceof-builtins': [2],
+      'unicorn/no-invalid-argument-count': [0],
+      'unicorn/no-invalid-character-comparison': [2],
      'unicorn/no-invalid-fetch-options': [2],
+      'unicorn/no-invalid-file-input-accept': [2],
      'unicorn/no-invalid-remove-event-listener': [2],
      'unicorn/no-keyword-prefix': [0],
-      'unicorn/no-length-as-slice-end': [2],
+      'unicorn/no-late-current-target-access': [2],
      'unicorn/no-lonely-if': [2],
+      'unicorn/no-loop-iterable-mutation': [2],
      'unicorn/no-magic-array-flat-depth': [0],
+      'unicorn/no-manually-wrapped-comments': [0], // too opinionated
+      'unicorn/no-mismatched-map-key': [2],
+      'unicorn/no-misrefactored-assignment': [2],
+      'unicorn/no-named-default': [2],
+      'unicorn/no-negated-array-predicate': [2],
+      'unicorn/no-negated-comparison': [2],
      'unicorn/no-negated-condition': [0],
      'unicorn/no-negation-in-equality-check': [2],
      'unicorn/no-nested-ternary': [0],
      'unicorn/no-new-array': [0],
      'unicorn/no-new-buffer': [0],
+      'unicorn/no-non-function-verb-prefix': [0],
+      'unicorn/no-nonstandard-builtin-properties': [2],
      'unicorn/no-null': [0],
      'unicorn/no-object-as-default-parameter': [0],
+      'unicorn/no-object-methods-with-collections': [2],
+      'unicorn/no-optional-chaining-on-undeclared-variable': [2],
      'unicorn/no-process-exit': [0],
+      'unicorn/no-redundant-comparison': [2],
+      'unicorn/no-return-array-push': [2],
+      'unicorn/no-selector-as-dom-name': [2],
      'unicorn/no-single-promise-in-promise-methods': [2],
      'unicorn/no-static-only-class': [2],
+      'unicorn/no-subtraction-comparison': [2],
      'unicorn/no-thenable': [2],
      'unicorn/no-this-assignment': [2],
+      'unicorn/no-this-outside-of-class': [0], // gitea uses `this` in non-class functions
+      'unicorn/no-top-level-assignment-in-function': [0],
+      'unicorn/no-top-level-side-effects': [0],
      'unicorn/no-typeof-undefined': [2],
+      'unicorn/no-uncalled-method': [2],
+      'unicorn/no-undeclared-class-members': [2],
+      'unicorn/no-unnecessary-array-flat-depth': [2],
+      'unicorn/no-unnecessary-array-splice-count': [2],
      'unicorn/no-unnecessary-await': [2],
+      'unicorn/no-unnecessary-boolean-comparison': [2],
+      'unicorn/no-unnecessary-global-this': [0],
+      'unicorn/no-unnecessary-nested-ternary': [2],
      'unicorn/no-unnecessary-polyfills': [2],
+      'unicorn/no-unnecessary-slice-end': [2],
+      'unicorn/no-unnecessary-splice': [2],
      'unicorn/no-unreadable-array-destructuring': [0],
+      'unicorn/no-unreadable-for-of-expression': [0],
      'unicorn/no-unreadable-iife': [0],
+      'unicorn/no-unreadable-new-expression': [0],
+      'unicorn/no-unreadable-object-destructuring': [0],
+      'unicorn/no-unsafe-buffer-conversion': [2],
+      'unicorn/no-unsafe-dom-html': [0],
+      'unicorn/no-unsafe-property-key': [0],
+      'unicorn/no-unsafe-string-replacement': [0],
+      'unicorn/no-unused-array-method-return': [2],
      'unicorn/no-unused-properties': [2],
+      'unicorn/no-useless-boolean-cast': [2],
+      'unicorn/no-useless-coercion': [2],
      'unicorn/no-useless-collection-argument': [2],
+      'unicorn/no-useless-compound-assignment': [2],
+      'unicorn/no-useless-concat': [2],
+      'unicorn/no-useless-continue': [2],
+      'unicorn/no-useless-delete-check': [2],
+      'unicorn/no-useless-else': [0],
+      'unicorn/no-useless-error-capture-stack-trace': [2],
      'unicorn/no-useless-fallback-in-spread': [2],
      'unicorn/no-useless-iterator-to-array': [2],
      'unicorn/no-useless-length-check': [2],
+      'unicorn/no-useless-logical-operand': [2],
+      'unicorn/no-useless-override': [2],
      'unicorn/no-useless-promise-resolve-reject': [2],
+      'unicorn/no-useless-recursion': [0],
      'unicorn/no-useless-spread': [2],
      'unicorn/no-useless-switch-case': [2],
+      'unicorn/no-useless-template-literals': [2],
      'unicorn/no-useless-undefined': [0],
+      'unicorn/no-xor-as-exponentiation': [2],
      'unicorn/no-zero-fractions': [2],
      'unicorn/number-literal-case': [0],
      'unicorn/numeric-separators-style': [0],
+      'unicorn/operator-assignment': [2],
      'unicorn/prefer-add-event-listener': [2],
+      'unicorn/prefer-add-event-listener-options': [2],
      'unicorn/prefer-array-find': [0], // handled by @typescript-eslint/prefer-find
      'unicorn/prefer-array-flat': [2],
      'unicorn/prefer-array-flat-map': [2],
+      'unicorn/prefer-array-from-async': [2],
+      'unicorn/prefer-array-from-map': [2],
      'unicorn/prefer-array-index-of': [2],
+      'unicorn/prefer-array-iterable-methods': [2],
+      'unicorn/prefer-array-last-methods': [2],
+      'unicorn/prefer-array-slice': [2],
      'unicorn/prefer-array-some': [2],
      'unicorn/prefer-at': [0],
+      'unicorn/prefer-await': [2],
+      'unicorn/prefer-bigint-literals': [2],
      'unicorn/prefer-blob-reading-methods': [2],
+      'unicorn/prefer-boolean-return': [2],
+      'unicorn/prefer-class-fields': [2],
+      'unicorn/prefer-classlist-toggle': [2],
      'unicorn/prefer-code-point': [0],
+      'unicorn/prefer-continue': [0],
      'unicorn/prefer-date-now': [2],
      'unicorn/prefer-default-parameters': [0],
+      'unicorn/prefer-direct-iteration': [2],
+      'unicorn/prefer-dispose': [2],
      'unicorn/prefer-dom-node-append': [2],
-      'unicorn/prefer-dom-node-dataset': [0],
+      'unicorn/prefer-dom-node-html-methods': [0],
      'unicorn/prefer-dom-node-remove': [2],
      'unicorn/prefer-dom-node-text-content': [2],
+      'unicorn/prefer-early-return': [0],
+      'unicorn/prefer-else-if': [2],
      'unicorn/prefer-event-target': [2],
      'unicorn/prefer-export-from': [0],
+      'unicorn/prefer-flat-math-min-max': [2],
+      'unicorn/prefer-get-or-insert-computed': [2],
+      'unicorn/prefer-global-number-constants': [2],
      'unicorn/prefer-global-this': [0],
+      'unicorn/prefer-has-check': [2],
+      'unicorn/prefer-hoisting-branch-code': [2],
+      'unicorn/prefer-https': [0], // false-positives on namespace and schema URIs
+      'unicorn/prefer-identifier-import-export-specifiers': [2],
+      'unicorn/prefer-import-meta-properties': [2],
      'unicorn/prefer-includes': [0], // handled by @typescript-eslint/prefer-includes
-      'unicorn/prefer-json-parse-buffer': [0],
+      'unicorn/prefer-includes-over-repeated-comparisons': [0], // too opinionated
+      'unicorn/prefer-iterable-in-constructor': [2],
+      'unicorn/prefer-iterator-concat': [0], // too opinionated
+      'unicorn/prefer-iterator-to-array': [2],
+      'unicorn/prefer-iterator-to-array-at-end': [2],
      'unicorn/prefer-keyboard-event-key': [2],
+      'unicorn/prefer-location-assign': [2],
      'unicorn/prefer-logical-operator-over-ternary': [2],
+      'unicorn/prefer-map-from-entries': [0],
+      'unicorn/prefer-math-abs': [2],
+      'unicorn/prefer-math-constants': [2],
      'unicorn/prefer-math-min-max': [2],
      'unicorn/prefer-math-trunc': [2],
+      'unicorn/prefer-minimal-ternary': [0],
      'unicorn/prefer-modern-dom-apis': [0],
      'unicorn/prefer-modern-math-apis': [2],
      'unicorn/prefer-module': [2],
      'unicorn/prefer-native-coercion-functions': [2],
      'unicorn/prefer-negative-index': [2],
      'unicorn/prefer-node-protocol': [2],
+      'unicorn/prefer-number-coercion': [0],
+      'unicorn/prefer-number-is-safe-integer': [0],
      'unicorn/prefer-number-properties': [0],
+      'unicorn/prefer-object-define-properties': [2],
+      'unicorn/prefer-object-destructuring-defaults': [2],
      'unicorn/prefer-object-from-entries': [2],
-      'unicorn/prefer-object-has-own': [0],
+      'unicorn/prefer-object-iterable-methods': [2],
      'unicorn/prefer-optional-catch-binding': [2],
+      'unicorn/prefer-path2d': [2],
+      'unicorn/prefer-private-class-fields': [0],
+      'unicorn/prefer-promise-with-resolvers': [2],
      'unicorn/prefer-prototype-methods': [0],
      'unicorn/prefer-query-selector': [2],
+      'unicorn/prefer-queue-microtask': [2],
      'unicorn/prefer-reflect-apply': [0],
+      'unicorn/prefer-regexp-escape': [0],
      'unicorn/prefer-regexp-test': [2],
      'unicorn/prefer-response-static-json': [2],
+      'unicorn/prefer-scoped-selector': [0],
      'unicorn/prefer-set-has': [0],
      'unicorn/prefer-set-size': [2],
+      'unicorn/prefer-short-arrow-method': [2],
      'unicorn/prefer-simple-condition-first': [0],
+      'unicorn/prefer-simple-sort-comparator': [2],
+      'unicorn/prefer-single-array-predicate': [2],
+      'unicorn/prefer-single-call': [2],
+      'unicorn/prefer-single-object-destructuring': [2],
+      'unicorn/prefer-single-replace': [2],
+      'unicorn/prefer-smaller-scope': [2],
+      'unicorn/prefer-split-limit': [0], // too opinionated
      'unicorn/prefer-spread': [0],
+      'unicorn/prefer-string-match-all': [2],
+      'unicorn/prefer-string-pad-start-end': [2],
      'unicorn/prefer-string-raw': [0],
+      'unicorn/prefer-string-repeat': [2],
      'unicorn/prefer-string-replace-all': [0],
      'unicorn/prefer-string-slice': [0],
      'unicorn/prefer-string-starts-ends-with': [0], // handled by @typescript-eslint/prefer-string-starts-ends-with
      'unicorn/prefer-string-trim-start-end': [2],
      'unicorn/prefer-structured-clone': [2],
      'unicorn/prefer-switch': [0],
+      'unicorn/prefer-temporal': [0],
      'unicorn/prefer-ternary': [0],
      'unicorn/prefer-top-level-await': [0],
      'unicorn/prefer-type-error': [0],
+      'unicorn/prefer-type-literal-last': [0],
+      'unicorn/prefer-uint8array-base64': [0],
+      'unicorn/prefer-unary-minus': [2],
+      'unicorn/prefer-unicode-code-point-escapes': [0],
+      'unicorn/prefer-url-can-parse': [2],
+      'unicorn/prefer-url-href': [2],
+      'unicorn/prefer-while-loop-condition': [2],
      'unicorn/prevent-abbreviations': [0],
      'unicorn/relative-url-style': [2],
      'unicorn/require-array-join-separator': [2],
+      'unicorn/require-array-sort-compare': [0],
+      'unicorn/require-css-escape': [2],
+      'unicorn/require-module-attributes': [2],
+      'unicorn/require-module-specifiers': [0],
      'unicorn/require-number-to-fixed-digits-argument': [2],
+      'unicorn/require-passive-events': [2],
      'unicorn/require-post-message-target-origin': [0],
+      'unicorn/require-proxy-trap-boolean-return': [2],
      'unicorn/string-content': [0],
      'unicorn/switch-case-braces': [0],
      'unicorn/switch-case-break-position': [2],
      'unicorn/template-indent': [2],
      'unicorn/text-encoding-identifier-case': [0],
      'unicorn/throw-new-error': [2],
+      'unicorn/try-complexity': [0],
      'use-isnan': [2],
      'valid-typeof': [2, {requireStringLiterals: true}],
      'vars-on-top': [0],
@@ -956,6 +1091,7 @@ export default defineConfig([
    languageOptions: {globals: globals.vitest},
    rules: {
      'gitea/unescaped-html-literal': [0],
+      'unicorn/no-error-property-assignment': [0],
      'vitest/consistent-test-filename': [0],
      'vitest/consistent-test-it': [0],
      'vitest/expect-expect': [0],
@@ -967,7 +1103,6 @@ export default defineConfig([
      'vitest/no-conditional-in-test': [0],
      'vitest/no-conditional-tests': [0],
      'vitest/no-disabled-tests': [0],
-      'vitest/no-done-callback': [0],
      'vitest/no-duplicate-hooks': [0],
      'vitest/no-focused-tests': [2],
      'vitest/no-hooks': [0],
--- a/package.json
+++ b/package.json
@@ -89,19 +89,18 @@
    "@types/swagger-ui-dist": "3.30.6",
    "@types/throttle-debounce": "5.0.2",
    "@types/toastify-js": "1.12.4",
-    "@typescript-eslint/parser": "8.61.0",
+    "@typescript-eslint/parser": "8.61.1",
    "@vitejs/plugin-vue": "6.0.7",
    "@vitest/eslint-plugin": "1.6.20",
-    "eslint": "10.4.1",
+    "eslint": "10.5.0",
    "eslint-import-resolver-typescript": "4.4.5",
    "eslint-plugin-array-func": "5.1.1",
    "eslint-plugin-de-morgan": "2.1.2",
-    "eslint-plugin-github": "6.0.0",
    "eslint-plugin-import-x": "4.16.2",
    "eslint-plugin-playwright": "2.10.4",
    "eslint-plugin-regexp": "3.1.0",
    "eslint-plugin-sonarjs": "4.0.3",
-    "eslint-plugin-unicorn": "64.0.0",
+    "eslint-plugin-unicorn": "68.0.0",
    "eslint-plugin-vue": "10.9.2",
    "eslint-plugin-vue-scoped-css": "3.1.1",
    "eslint-plugin-wc": "3.1.0",
@@ -119,7 +118,7 @@
    "stylelint-value-no-unknown-custom-properties": "6.1.1",
    "svgo": "4.0.1",
    "typescript": "6.0.3",
-    "typescript-eslint": "8.61.0",
+    "typescript-eslint": "8.61.1",
    "updates": "17.18.0",
    "vitest": "4.1.8",
    "vue-tsc": "3.3.4"
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -3,10 +3,6 @@ dedupePeerDependents: false
 updateNotifier: false
 minimumReleaseAge: 0

-peerDependencyRules:
-  allowedVersions:
-    eslint-plugin-github>eslint: '>=9'
-
 allowBuilds:
  '@scarf/scarf': false
  core-js: false
--- a/tailwind.config.ts
+++ b/tailwind.config.ts
@@ -90,7 +90,7 @@ export default {
      '8xl': '96px',
      '9xl': '128px',
      ...Object.fromEntries(Array.from({length: 100}, (_, i) => {
-        return [`${i}`, `${i === 0 ? '0' : `${i}px`}`];
+        return [String(i), i === 0 ? '0' : `${i}px`];
      })),
    },
    extend: {
--- a/tools/ci-tools.ts
+++ b/tools/ci-tools.ts
@@ -83,7 +83,7 @@ async function setPrLabels(): Promise<void> {
        Accept: 'application/vnd.github+json',
        Authorization: `Bearer ${env.GITHUB_TOKEN}`,
        'X-GitHub-Api-Version': '2022-11-28',
-        ...(body ? {'Content-Type': 'application/json'} : {}),
+        ...(Boolean(body) && {'Content-Type': 'application/json'}),
      },
      body: body ? JSON.stringify(body) : undefined,
    });
--- a/tools/eslint-rules/unescaped-html-literal.ts
+++ b/tools/eslint-rules/unescaped-html-literal.ts
@@ -12,30 +12,28 @@ const rule: JSRuleDefinition<JSRuleDefinitionTypeOptions> = {
    },
  },

-  create(context) {
-    return {
-      Literal(node) {
-        if (typeof node.value !== 'string' || !htmlOpenTag.test(node.value)) return;
+  create: (context) => ({
+    Literal(node) {
+      if (typeof node.value !== 'string' || !htmlOpenTag.test(node.value)) return;

-        context.report({
-          node,
-          messageId: 'unescapedHtmlLiteral',
-        });
-      },
-      TemplateLiteral(node) {
-        const templateStart = node.quasis[0]?.value.raw;
-        if (!templateStart || !htmlOpenTag.test(templateStart)) return;
+      context.report({
+        node,
+        messageId: 'unescapedHtmlLiteral',
+      });
+    },
+    TemplateLiteral(node) {
+      const templateStart = node.quasis[0]?.value.raw;
+      if (!templateStart || !htmlOpenTag.test(templateStart)) return;

-        const parent = node.parent;
-        if (parent?.type === 'TaggedTemplateExpression' && parent.tag.type === 'Identifier' && parent.tag.name === 'html') return;
+      const parent = node.parent;
+      if (parent?.type === 'TaggedTemplateExpression' && parent.tag.type === 'Identifier' && parent.tag.name === 'html') return;

-        context.report({
-          node,
-          messageId: 'unescapedHtmlLiteral',
-        });
-      },
-    };
-  },
+      context.report({
+        node,
+        messageId: 'unescapedHtmlLiteral',
+      });
+    },
+  }),
 };

 export default rule;
--- a/tools/generate-images.ts
+++ b/tools/generate-images.ts
@@ -7,7 +7,7 @@ import {argv, exit} from 'node:process';
 async function generate(svg: string, path: string, {size, bg}: {size: number, bg?: boolean}) {
  const outputFile = new URL(path, import.meta.url);

-  if (String(outputFile).endsWith('.svg')) {
+  if (outputFile.href.endsWith('.svg')) {
    const {data} = optimize(svg, {
      plugins: [
        'preset-default',
--- a/tools/generate-svg.ts
+++ b/tools/generate-svg.ts
@@ -92,7 +92,7 @@ async function processMaterialFileIcons() {
  }

  // Use VSCode's "Language ID" mapping from its extensions
-  for (const [_, langIdExtMap] of Object.entries(vscodeExtensions)) {
+  for (const langIdExtMap of Object.values(vscodeExtensions)) {
    for (const [langId, names] of Object.entries(langIdExtMap)) {
      for (const name of names) {
        const nameLower = name.toLowerCase();
--- a/types.d.ts
+++ b/types.d.ts
@@ -1,21 +1,9 @@
-declare module 'eslint-plugin-no-use-extend-native' {
-  import type {Eslint} from 'eslint';
-  const plugin: Eslint.Plugin;
-  export = plugin;
-}
-
 declare module 'eslint-plugin-array-func' {
  import type {Eslint} from 'eslint';
  const plugin: Eslint.Plugin;
  export = plugin;
 }

-declare module 'eslint-plugin-github' {
-  import type {Eslint} from 'eslint';
-  const plugin: Eslint.Plugin;
-  export = plugin;
-}
-
 declare module '*.svg' {
  const value: string;
  export default value;
--- a/vite.config.ts
+++ b/vite.config.ts
@@ -56,7 +56,7 @@ const commonRolldownOptions: Rolldown.RolldownOptions = {
  checks: {
    pluginTimings: false,
  },
-  ...(env.CI ? {plugins: [failOnWarningsPlugin()]} : {}),
+  ...(env.CI && {plugins: [failOnWarningsPlugin()]}),
 };

 function commonViteOpts({build, ...other}: InlineConfig): InlineConfig {
--- a/web_src/js/components/ActionRunView.ts
+++ b/web_src/js/components/ActionRunView.ts
@@ -47,9 +47,9 @@ export type LogLineCommand = {

 export function parseLogLineCommand(line: LogLine): LogLineCommand | null {
  // TODO: in the future it can be refactored to be a general parser that can parse arguments, drop the "prefix match"
-  for (const prefix of Object.keys(LogLinePrefixCommandMap)) {
+  for (const [prefix, commandName] of Object.entries(LogLinePrefixCommandMap)) {
    if (line.message.startsWith(prefix)) {
-      return {name: LogLinePrefixCommandMap[prefix], prefix};
+      return {name: commandName, prefix};
    }
  }
  // Handle ::cmd:: and ::cmd args:: format (runner may pass these through raw)
--- a/web_src/js/components/ViewFileTreeStore.ts
+++ b/web_src/js/components/ViewFileTreeStore.ts
@@ -57,9 +57,7 @@ export function createViewFileTreeStore(props: {repoLink: string, treePath: stri
      await store.loadViewContent(url);
    },

-    buildTreePathWebUrl(treePath: string) {
-      return `${props.repoLink}/src/${props.currentRefNameSubURL}/${pathEscapeSegments(treePath)}`;
-    },
+    buildTreePathWebUrl: (treePath: string) => `${props.repoLink}/src/${props.currentRefNameSubURL}/${pathEscapeSegments(treePath)}`,
  });
  return store;
 }
--- a/web_src/js/components/WorkflowGraph.utils.ts
+++ b/web_src/js/components/WorkflowGraph.utils.ts
@@ -166,7 +166,7 @@ function buildDirectNeedsMap(jobs: ActionsJob[]): Map<string, string[]> {
  const reducedNeedsByJobId = new Map<string, string[]>();
  for (const [jobId, needs] of directNeedsByJobId) {
    reducedNeedsByJobId.set(jobId, needs.filter((need) => {
-      return !needs.some((other) => other !== need && canReach(need, other));
+      return needs.every((other) => other === need || !canReach(need, other));
    }));
  }
  return reducedNeedsByJobId;
--- a/web_src/js/features/admin/config.test.ts
+++ b/web_src/js/features/admin/config.test.ts
@@ -30,9 +30,9 @@ test('ConfigFormValueMapper', () => {
  const formData = mapper.collectToFormData();
  const result: Record<string, string> = {};
  const keys: string[] = [], values: string[] = [];
-  for (const [key, value] of formData.entries()) {
+  for (const [key, value] of formData) {
    if (key === 'key') keys.push(value as string);
-    if (key === 'value') values.push(value as string);
+    else if (key === 'value') values.push(value as string);
  }
  for (let i = 0; i < keys.length; i++) {
    result[keys[i]] = values[i];
--- a/web_src/js/features/admin/config.ts
+++ b/web_src/js/features/admin/config.ts
@@ -102,9 +102,7 @@ export class ConfigFormValueMapper {
    } else if (el.matches('[type="datetime-local"]')) {
      if (valType !== 'timestamp') requireExplicitValueType(el);
      if (val) el.value = toDatetimeLocalValue(val);
-    } else if (el.matches('textarea')) {
-      el.value = String(val ?? el.value);
-    } else if (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text') {
+    } else if (el.matches('textarea') || (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text')) {
      el.value = String(val ?? el.value);
    } else {
      unsupportedElement(el);
@@ -123,9 +121,7 @@ export class ConfigFormValueMapper {
    } else if (el.matches('[type="datetime-local"]')) {
      if (valType !== 'timestamp') requireExplicitValueType(el);
      val = Math.floor(new Date(el.value).getTime() / 1000) ?? 0; // NaN is fine to JSON.stringify, it becomes null.
-    } else if (el.matches('textarea')) {
-      val = el.value;
-    } else if (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text') {
+    } else if (el.matches('textarea') || (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text')) {
      val = el.value;
    } else {
      unsupportedElement(el);
@@ -178,7 +174,7 @@ export class ConfigFormValueMapper {

  collectToFormData(): FormData {
    const namedElems: Array<GeneralFormFieldElement | null> = [];
-    queryElems(this.form, '[name]', (el) => namedElems.push(el as GeneralFormFieldElement));
+    queryElems(this.form, '[name]', (el) => { namedElems.push(el as GeneralFormFieldElement) });

    // first, process the config options with sub values, for example:
    // merge "foo.bar.Enabled", "foo.bar.Message" to "foo.bar"
--- a/web_src/js/features/admin/users.ts
+++ b/web_src/js/features/admin/users.ts
@@ -5,14 +5,14 @@ export function initAdminUserListSearchForm(): void {
  const form = document.querySelector<HTMLFormElement>('#user-list-search-form');
  if (!form) return;

-  for (const button of form.querySelectorAll(`button[name=sort][value="${searchForm.SortType}"]`)) {
+  for (const button of form.querySelectorAll(`button[name=sort][value="${CSS.escape(searchForm.SortType)}"]`)) {
    button.classList.add('active');
  }

  if (searchForm.StatusFilterMap) {
    for (const [k, v] of Object.entries(searchForm.StatusFilterMap)) {
      if (!v) continue;
-      for (const input of form.querySelectorAll<HTMLInputElement>(`input[name="status_filter[${k}]"][value="${v}"]`)) {
+      for (const input of form.querySelectorAll<HTMLInputElement>(`input[name="status_filter[${CSS.escape(k)}]"][value="${CSS.escape(v)}"]`)) {
        input.checked = true;
      }
    }
--- a/web_src/js/features/common-button.ts
+++ b/web_src/js/features/common-button.ts
@@ -87,10 +87,10 @@ function onShowModalClick(el: HTMLElement, e: MouseEvent) {
    const [attrTargetName, attrTargetProp] = attrTargetCombo.split('.');
    // try to find target by: "#target" -> "[name=target]" -> ".target" -> "<target> tag", and then try the modal itself
    const attrTarget = elModal.querySelector(`#${attrTargetName}`) ||
-      elModal.querySelector(`[name=${attrTargetName}]`) ||
+      elModal.querySelector(`[name=${CSS.escape(attrTargetName)}]`) ||
      elModal.querySelector(`.${attrTargetName}`) ||
-      elModal.querySelector(`${attrTargetName}`) ||
-      (elModal.matches(`${attrTargetName}`) || elModal.matches(`#${attrTargetName}`) || elModal.matches(`.${attrTargetName}`) ? elModal : null);
+      elModal.querySelector(attrTargetName) ||
+      (elModal.matches(attrTargetName) || elModal.matches(`#${attrTargetName}`) || elModal.matches(`.${attrTargetName}`) ? elModal : null);
    if (!attrTarget) {
      if (!window.config.runModeIsProd) throw new Error(`attr target "${attrTargetCombo}" not found for modal`);
      continue;
--- a/web_src/js/features/common-fetch-action.ts
+++ b/web_src/js/features/common-fetch-action.ts
@@ -114,7 +114,7 @@ function buildFetchActionUrl(el: HTMLElement, opt: FetchActionOpts) {
    const u = new URL(url, window.location.href);
    if (name && !u.searchParams.has(name)) {
      u.searchParams.set(name, val);
-      url = u.toString();
+      url = u.href;
    }
  }
  return url;
--- a/web_src/js/features/common-form.ts
+++ b/web_src/js/features/common-form.ts
@@ -16,17 +16,13 @@ export function initGlobalEnterQuickSubmit() {
  document.addEventListener('keydown', (e) => {
    if (e.isComposing) return;
    if (e.key !== 'Enter') return;
+    const el = e.target as HTMLElement;
    const hasCtrlOrMeta = ((e.ctrlKey || e.metaKey) && !e.altKey);
-    if (hasCtrlOrMeta && (e.target as HTMLElement).matches('textarea')) {
-      if (handleGlobalEnterQuickSubmit(e.target as HTMLElement)) {
-        e.preventDefault();
-      }
-    } else if ((e.target as HTMLElement).matches('input') && !(e.target as HTMLElement).closest('form')) {
-      // input in a normal form could handle Enter key by default, so we only handle the input outside a form
-      // eslint-disable-next-line unicorn/no-lonely-if
-      if (handleGlobalEnterQuickSubmit(e.target as HTMLElement)) {
-        e.preventDefault();
-      }
+    const isCtrlEnterInTextarea = hasCtrlOrMeta && el.matches('textarea');
+    // an input in a normal form could handle Enter key by default, so we only handle the input outside a form
+    const isEnterInBareInput = el.matches('input') && !el.closest('form');
+    if ((isCtrlEnterInTextarea || isEnterInBareInput) && handleGlobalEnterQuickSubmit(el)) {
+      e.preventDefault();
    }
  });
 }
--- a/web_src/js/features/common-issue-list.ts
+++ b/web_src/js/features/common-issue-list.ts
@@ -35,7 +35,7 @@ export function initCommonIssueListQuickGoto() {
  const repoLink = elGotoButton.getAttribute('data-repo-link') || '';

  elGotoButton.addEventListener('click', () => {
-    window.location.href = elGotoButton.getAttribute('data-issue-goto-link')!;
+    window.location.assign(elGotoButton.getAttribute('data-issue-goto-link')!);
  });

  const onInput = async () => {
--- a/web_src/js/features/dropzone.ts
+++ b/web_src/js/features/dropzone.ts
@@ -110,8 +110,8 @@ export async function initDropzone(dropzoneEl: HTMLElement) {
  });

  dzInst.on('submit', () => {
-    for (const fileUuid of Object.keys(fileUuidDict)) {
-      fileUuidDict[fileUuid].submitted = true;
+    for (const value of Object.values(fileUuidDict)) {
+      value.submitted = true;
    }
  });

--- a/web_src/js/features/heatmap.ts
+++ b/web_src/js/features/heatmap.ts
@@ -24,8 +24,8 @@ export async function initHeatmap() {
      heatmap[dateStr] = (heatmap[dateStr] || 0) + contributions;
    }

-    const values = Object.keys(heatmap).map((v) => {
-      return {date: new Date(v), count: heatmap[v]};
+    const values = Object.entries(heatmap).map(([dateStr, count]) => {
+      return {date: new Date(dateStr), count};
    });

    const totalFormatted = totalContributions.toLocaleString();
--- a/web_src/js/features/imagediff.ts
+++ b/web_src/js/features/imagediff.ts
@@ -291,7 +291,7 @@ class ImageDiff {

    function updateOpacity() {
      if (ctx.imageAfter) {
-        (ctx.imageAfter.parentNode as HTMLElement).style.opacity = `${Number(rangeInput.value) / 100}`;
+        (ctx.imageAfter.parentNode as HTMLElement).style.opacity = String(Number(rangeInput.value) / 100);
      }
    }

--- a/web_src/js/features/install.ts
+++ b/web_src/js/features/install.ts
@@ -95,7 +95,7 @@ function initPostInstall() {
      if (tid && resp.status === 200) {
        clearInterval(tid);
        tid = null;
-        window.location.href = targetUrl;
+        window.location.assign(targetUrl);
      }
    } catch {}
  }, 1000);
--- a/web_src/js/features/notification.ts
+++ b/web_src/js/features/notification.ts
@@ -10,7 +10,7 @@ async function receiveUpdateCount(event: MessageEvent<{type: string, data: strin
    const data = JSON.parse(event.data.data);
    for (const count of document.querySelectorAll('.notification_count')) {
      count.classList.toggle('tw-hidden', data.Count === 0);
-      count.textContent = `${data.Count}`;
+      count.textContent = String(data.Count);
    }
    await updateNotificationTable();
  } catch (error) {
@@ -112,7 +112,7 @@ async function updateNotificationCount(): Promise<number> {
    toggleElem('.notification_count', data.new !== 0);

    for (const el of document.querySelectorAll('.notification_count')) {
-      el.textContent = `${data.new}`;
+      el.textContent = String(data.new);
    }

    return data.new as number;
--- a/web_src/js/features/repo-code.ts
+++ b/web_src/js/features/repo-code.ts
@@ -31,9 +31,9 @@ function selectRange(range: string): Element | null {
  const updateViewGitBlameFragment = function (anchor: string) {
    if (!viewGitBlame) return;
    let href = viewGitBlame.getAttribute('href')!;
-    href = `${href.replace(/#L\d+$|#L\d+-L\d+$/, '')}`;
+    href = href.replace(/#L\d+$|#L\d+-L\d+$/, '');
    if (anchor.length !== 0) {
-      href = `${href}#${anchor}`;
+      href += `#${anchor}`;
    }
    viewGitBlame.setAttribute('href', href);
  };
--- a/web_src/js/features/repo-commit.ts
+++ b/web_src/js/features/repo-commit.ts
@@ -45,8 +45,8 @@ export function initCommitFileHistoryFollowRename() {
  registerGlobalInitFunc('initCommitHistoryFollowRename', (el: HTMLInputElement) => {
    el.addEventListener('change', () => {
      const url = new URL(window.location.toString());
-      url.searchParams.set('follow-rename', `${el.checked}`);
-      window.location.assign(url.toString());
+      url.searchParams.set('follow-rename', String(el.checked));
+      window.location.assign(url.href);
    });
  });
 }
--- a/web_src/js/features/repo-common.ts
+++ b/web_src/js/features/repo-common.ts
@@ -23,7 +23,7 @@ async function onDownloadArchive(e: Event) {
      if (data.complete) break;
      await sleep(Math.min((tryCount + 1) * 750, 2000));
    }
-    window.location.href = el.href; // the archive is ready, start real downloading
+    window.location.assign(el.href); // the archive is ready, start real downloading
  } catch (e) {
    console.error(e);
    showErrorToast(`Failed to download the archive: ${errorMessage(e)}`, {duration: 2500});
--- a/web_src/js/features/repo-diff.ts
+++ b/web_src/js/features/repo-diff.ts
@@ -129,7 +129,7 @@ function initRepoDiffConversationNav() {
    const navIndex = isPrevious ? previousIndex : nextIndex;
    const elNavConversation = elAllConversations[navIndex];
    const anchor = elNavConversation.querySelector('.comment')!.id;
-    window.location.href = `#${anchor}`;
+    window.location.assign(`#${anchor}`);
  });
 }

@@ -245,7 +245,7 @@ async function onLocationHashChange() {
    const issueCommentPrefix = '#issuecomment-';
    if (currentHash.startsWith(issueCommentPrefix)) {
      const commentId = currentHash.substring(issueCommentPrefix.length);
-      const expandButton = document.querySelector<HTMLElement>(`.code-expander-button[data-hidden-comment-ids*=",${commentId},"]`);
+      const expandButton = document.querySelector<HTMLElement>(`.code-expander-button[data-hidden-comment-ids*=",${CSS.escape(commentId)},"]`);
      if (expandButton) {
        // avoid infinite loop, do not re-click the button if already clicked
        const attrAutoLoadClicked = 'data-auto-load-clicked';
--- a/web_src/js/features/repo-graph.ts
+++ b/web_src/js/features/repo-graph.ts
@@ -42,7 +42,7 @@ export function initRepoGraphGit() {

    elGraphBody.classList.add('is-loading');
    try {
-      const resp = await GET(ajaxUrl.toString());
+      const resp = await GET(ajaxUrl.href);
      elGraphBody.innerHTML = await resp.text();
    } finally {
      elGraphBody.classList.remove('is-loading');
@@ -51,7 +51,7 @@ export function initRepoGraphGit() {

  const dropdownSelected = params.getAll('branch');
  if (params.has('hide-pr-refs') && params.get('hide-pr-refs') === 'true') {
-    dropdownSelected.splice(0, 0, '...flow-hide-pr-refs');
+    dropdownSelected.unshift('...flow-hide-pr-refs');
  }

  const $dropdown = fomanticQuery('#flow-select-refs-dropdown');
--- a/web_src/js/features/repo-home.ts
+++ b/web_src/js/features/repo-home.ts
@@ -96,10 +96,7 @@ export function initRepoTopicBar() {
        };
        const query = stripTags(this.urlData.query.trim());
        let found_query = false;
-        const current_topics = [];
-        for (const el of queryElemChildren(topicDropdown, 'a.ui.label.visible')) {
-          current_topics.push(el.getAttribute('data-value'));
-        }
+        const current_topics = Array.from(queryElemChildren(topicDropdown, 'a.ui.label.visible'), (el) => el.getAttribute('data-value'));

        if (res.topics) {
          let found = false;
--- a/web_src/js/features/repo-issue-content.ts
+++ b/web_src/js/features/repo-issue-content.ts
@@ -148,7 +148,7 @@ export async function initRepoIssueContentHistory() {
    if (resp.editedHistoryCountMap[0] && elIssueDescription) {
      showContentHistoryMenu(issueBaseUrl, elIssueDescription, '0');
    }
-    for (const [commentId, _editedCount] of Object.entries(resp.editedHistoryCountMap)) {
+    for (const commentId of Object.keys(resp.editedHistoryCountMap)) {
      if (commentId === '0') continue;
      const elIssueComment = document.querySelector(`#issuecomment-${commentId}`);
      if (elIssueComment) showContentHistoryMenu(issueBaseUrl, elIssueComment, commentId);
--- a/web_src/js/features/repo-issue-list.ts
+++ b/web_src/js/features/repo-issue-list.ts
@@ -58,10 +58,7 @@ function initRepoIssueListCheckboxes() {
      const url = el.getAttribute('data-url')!;
      let action = el.getAttribute('data-action')!;
      let elementId = el.getAttribute('data-element-id')!;
-      const issueIDList: string[] = [];
-      for (const el of document.querySelectorAll('.issue-checkbox:checked')) {
-        issueIDList.push(el.getAttribute('data-issue-id')!);
-      }
+      const issueIDList: string[] = Array.from(document.querySelectorAll('.issue-checkbox:checked'), (el) => (el.getAttribute('data-issue-id')!));
      const issueIDs = issueIDList.join(',');
      if (!issueIDs) return;

@@ -109,7 +106,7 @@ function initDropdownUserRemoteSearch(el: Element) {
    fullTextSearch: true,
    selectOnKeydown: false,
    action: (_text: string, value: string) => {
-      window.location.href = actionJumpUrl.replace('{username}', encodeURIComponent(value));
+      window.location.assign(actionJumpUrl.replace('{username}', encodeURIComponent(value)));
    },
  });

@@ -192,7 +189,7 @@ function initPinRemoveButton() {
        // Delete the tooltip
        el._tippy.destroy();
        // Remove the Card
-        el.closest(`div.issue-card[data-issue-id="${id}"]`)!.remove();
+        el.closest(`div.issue-card[data-issue-id="${CSS.escape(String(id))}"]`)!.remove();
      }
    });
  }
--- a/web_src/js/features/repo-issue.ts
+++ b/web_src/js/features/repo-issue.ts
@@ -28,7 +28,7 @@ function initRepoIssueLabelFilter(elDropdown: HTMLElement) {
  const queryLabels = url.searchParams.get('labels') || '';
  const selectedLabelIds = new Set<string>();
  for (const id of queryLabels ? queryLabels.split(',') : []) {
-    selectedLabelIds.add(`${Math.abs(parseInt(id))}`); // "labels" contains negative ids, which are excluded
+    selectedLabelIds.add(String(Math.abs(parseInt(id)))); // "labels" contains negative ids, which are excluded
  }

  const excludeLabel = (e: MouseEvent | KeyboardEvent, item: Element) => {
@@ -130,9 +130,9 @@ export function initRepoIssueCommentDelete() {
          // on the Conversation page, there is no parent "tr", so no need to do anything for "add-code-comment"
          if (lineType) {
            if (lineType === 'same') {
-              document.querySelector(`[data-path="${path}"] .add-code-comment[data-idx="${idx}"]`)!.classList.remove('tw-invisible');
+              document.querySelector(`[data-path="${CSS.escape(String(path))}"] .add-code-comment[data-idx="${CSS.escape(String(idx))}"]`)!.classList.remove('tw-invisible');
            } else {
-              document.querySelector(`[data-path="${path}"] .add-code-comment[data-side="${side}"][data-idx="${idx}"]`)!.classList.remove('tw-invisible');
+              document.querySelector(`[data-path="${CSS.escape(String(path))}"] .add-code-comment[data-side="${CSS.escape(String(side))}"][data-idx="${CSS.escape(String(idx))}"]`)!.classList.remove('tw-invisible');
            }
          }
          conversationHolder.remove();
--- a/web_src/js/features/repo-projects.ts
+++ b/web_src/js/features/repo-projects.ts
@@ -120,11 +120,11 @@ function initRepoProjectColumnEdit(writableProjectBoard: Element): void {
      }

      // update the newly saved column title and color in the project board (to avoid reload)
-      const elEditButton = writableProjectBoard.querySelector<HTMLButtonElement>(`.show-project-column-modal-edit[${attrDataColumnId}="${columnId}"]`)!;
+      const elEditButton = writableProjectBoard.querySelector<HTMLButtonElement>(`.show-project-column-modal-edit[${CSS.escape(attrDataColumnId)}="${CSS.escape(columnId)}"]`)!;
      elEditButton.setAttribute(attrDataColumnTitle, elColumnTitle.value);
      elEditButton.setAttribute(attrDataColumnColor, elColumnColor.value);

-      const elBoardColumn = writableProjectBoard.querySelector<HTMLElement>(`.project-column[data-id="${columnId}"]`)!;
+      const elBoardColumn = writableProjectBoard.querySelector<HTMLElement>(`.project-column[data-id="${CSS.escape(columnId)}"]`)!;
      const elBoardColumnTitle = elBoardColumn.querySelector<HTMLElement>(`.project-column-title-text`)!;
      elBoardColumnTitle.textContent = elColumnTitle.value;
      if (elColumnColor.value) {
--- a/web_src/js/features/repo-release.ts
+++ b/web_src/js/features/repo-release.ts
@@ -12,7 +12,7 @@ export function initRepoReleaseNew() {
  registerGlobalEventFunc('click', 'onReleaseEditAttachmentDelete', (el) => {
    const uuid = el.getAttribute('data-uuid')!;
    const id = el.getAttribute('data-id')!;
-    document.querySelector<HTMLInputElement>(`input[name='attachment-del-${uuid}']`)!.value = 'true';
+    document.querySelector<HTMLInputElement>(`input[name='attachment-del-${CSS.escape(uuid)}']`)!.value = 'true';
    hideElem(`#attachment-${id}`);
  });
  registerGlobalInitFunc('initReleaseEditForm', (elForm: HTMLFormElement) => {
--- a/web_src/js/features/user-auth-webauthn.ts
+++ b/web_src/js/features/user-auth-webauthn.ts
@@ -79,7 +79,7 @@ async function loginPasskey() {
    }
    const reply = await res.json();

-    window.location.href = reply?.redirect ?? `${appSubUrl}/`;
+    window.location.assign(reply?.redirect ?? `${appSubUrl}/`);
  } catch (err) {
    webAuthnError('general', errorMessage(err));
  }
@@ -151,7 +151,7 @@ async function verifyAssertion(assertedCredential: any) { // TODO: Credential ty
  }
  const reply = await res.json();

-  window.location.href = reply?.redirect ?? `${appSubUrl}/`;
+  window.location.assign(reply?.redirect ?? `${appSubUrl}/`);
 }

 async function webauthnRegistered(newCredential: any) { // TODO: Credential type does not work
@@ -188,7 +188,7 @@ function webAuthnError(errorType: ErrorType, message:string = '') {
  if (errorType === 'general') {
    elErrorMsg.textContent = message || 'unknown error';
  } else {
-    const elTypedError = document.querySelector(`#webauthn-error [data-webauthn-error-msg=${errorType}]`);
+    const elTypedError = document.querySelector(`#webauthn-error [data-webauthn-error-msg=${CSS.escape(errorType)}]`);
    if (elTypedError) {
      elErrorMsg.textContent = `${elTypedError.textContent}${message ? ` ${message}` : ''}`;
    } else {
--- a/web_src/js/markup/html2markdown.ts
+++ b/web_src/js/markup/html2markdown.ts
@@ -18,15 +18,9 @@ function prepareProcessors(ctx:ProcessorContext): Processors {
      const level = parseInt(el.tagName.slice(1));
      el.textContent = `${'#'.repeat(level)} ${el.textContent.trim()}`;
    },
-    STRONG(el: HTMLElement) {
-      return `**${el.textContent}**`;
-    },
-    EM(el: HTMLElement) {
-      return `_${el.textContent}_`;
-    },
-    DEL(el: HTMLElement) {
-      return `~~${el.textContent}~~`;
-    },
+    STRONG: (el: HTMLElement) => `**${el.textContent}**`,
+    EM: (el: HTMLElement) => `_${el.textContent}_`,
+    DEL: (el: HTMLElement) => `~~${el.textContent}~~`,
    A(el: HTMLElement) {
      const text = el.textContent || 'link';
      const href = el.getAttribute('href');
@@ -62,9 +56,7 @@ function prepareProcessors(ctx:ProcessorContext): Processors {
      el.textContent = `${' '.repeat(nestingIdentLevel * 4)}${bullet}${el.textContent}${ctx.elementIsLast ? '' : '\n'}`;
      return el;
    },
-    INPUT(el: HTMLElement) {
-      return (el as HTMLInputElement).checked ? '[x] ' : '[ ] ';
-    },
+    INPUT: (el: HTMLElement) => (el as HTMLInputElement).checked ? '[x] ' : '[ ] ',
    CODE(el: HTMLElement) {
      const text = el.textContent;
      if (el.parentNode && (el.parentNode as HTMLElement).tagName === 'PRE') {
@@ -86,8 +78,8 @@ function prepareProcessors(ctx:ProcessorContext): Processors {

 function processElement(ctx :ProcessorContext, processors: Processors, el: HTMLElement): string | void {
  if (el.hasAttribute('data-markdown-generated-content')) return el.textContent;
-  if (el.tagName === 'A' && el.children.length === 1 && el.children[0].tagName === 'IMG') {
-    return processElement(ctx, processors, el.children[0] as HTMLElement);
+  if (el.tagName === 'A' && el.children.length === 1 && el.firstElementChild!.tagName === 'IMG') {
+    return processElement(ctx, processors, el.firstElementChild as HTMLElement);
  }

  const isListContainer = el.tagName === 'OL' || el.tagName === 'UL';
--- a/web_src/js/markup/render-iframe.test.ts
+++ b/web_src/js/markup/render-iframe.test.ts
@@ -29,7 +29,6 @@ describe('navigateToIframeLink', () => {

  test('unsafe links', () => {
    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => undefined);
-    window.location.href = 'http://localhost:3000/';

    // eslint-disable-next-line no-script-url
    navigateToIframeLink('javascript:void(0);', '_blank');
--- a/web_src/js/markup/render-iframe.ts
+++ b/web_src/js/markup/render-iframe.ts
@@ -4,7 +4,7 @@ import {isDarkTheme} from '../utils.ts';

 function safeRenderIframeLink(link: any): string | null {
  try {
-    const url = new URL(`${link}`, window.location.href);
+    const url = new URL(link, window.location.href);
    if (url.protocol !== 'http:' && url.protocol !== 'https:') {
      console.error(`Unsupported link protocol: ${link}`);
      return null;
--- a/web_src/js/modules/codeeditor/main.ts
+++ b/web_src/js/modules/codeeditor/main.ts
@@ -203,9 +203,7 @@ export async function createCodeEditor(textarea: HTMLTextAreaElement, filenameIn
        },
      }),
      cm.language.foldGutter({
-        markerDOM(open: boolean) {
-          return createElementFromHTML(svg(open ? 'octicon-chevron-down' : 'octicon-chevron-right', 13));
-        },
+        markerDOM: (open: boolean) => createElementFromHTML(svg(open ? 'octicon-chevron-down' : 'octicon-chevron-right', 13)),
      }),
      cm.view.highlightActiveLineGutter(),
      cm.view.highlightSpecialChars(),
--- a/web_src/js/modules/errors.ts
+++ b/web_src/js/modules/errors.ts
@@ -20,11 +20,11 @@ export function showGlobalErrorMessage(msg: string, msgType: Intent = 'error', d
  }
  // compact the message to a data attribute to avoid too many duplicated messages
  const msgCompact = `${msgType}-${msg.trim()}`.replace(/[^-\w\u{80}-\u{10FFFF}]+/gu, '');
-  let msgContainer = parentContainer.querySelector<HTMLDivElement>(`.js-global-error[data-global-error-msg-compact="${msgCompact}"]`);
+  let msgContainer = parentContainer.querySelector<HTMLDivElement>(`.js-global-error[data-global-error-msg-compact="${CSS.escape(msgCompact)}"]`);
  if (!msgContainer) {
    const el = document.createElement('div');
    el.innerHTML = html`<div class="ui container js-global-error tw-my-[--page-spacing]"><details class="ui ${msgType} message"><summary></summary></details></div>`;
-    msgContainer = el.childNodes[0] as HTMLDivElement;
+    msgContainer = el.firstElementChild as HTMLDivElement;
  }

  // merge duplicated messages into "the message (count)" format
@@ -51,8 +51,7 @@ export function isGiteaError(filename: string, stack: string): boolean {
  if (extensionRe.test(filename) || extensionRe.test(stack)) return false;
  const assetBaseUrl = new URL(`${window.config.assetUrlPrefix}/`, window.location.origin).href;
  if (filename && !filename.startsWith(assetBaseUrl) && !filename.startsWith(window.location.origin)) return false;
-  if (stack && !stack.includes(assetBaseUrl)) return false;
-  return true;
+  return !stack || stack.includes(assetBaseUrl);
 }

 export function processWindowErrorEvent({error, reason, message, type, filename, lineno, colno}: ErrorEvent & PromiseRejectionEvent) {
--- a/web_src/js/modules/fomantic/dropdown.ts
+++ b/web_src/js/modules/fomantic/dropdown.ts
@@ -253,22 +253,22 @@ function attachDomEvents(dropdown: HTMLElement, focusable: HTMLElement, menu: HT
  dropdown.addEventListener('mousedown', () => {
    ignoreClickPreVisible += isMenuVisible() ? 1 : 0;
    ignoreClickPreEvents++;
-  }, true);
+  }, {capture: true});
  dropdown.addEventListener('focus', () => {
    ignoreClickPreVisible += isMenuVisible() ? 1 : 0;
    ignoreClickPreEvents++;
    deferredRefreshAriaActiveItem();
-  }, true);
+  }, {capture: true});
  dropdown.addEventListener('blur', () => {
    ignoreClickPreVisible = ignoreClickPreEvents = 0;
    deferredRefreshAriaActiveItem(100);
-  }, true);
+  }, {capture: true});
  dropdown.addEventListener('mouseup', () => {
    setTimeout(() => {
      ignoreClickPreVisible = ignoreClickPreEvents = 0;
      deferredRefreshAriaActiveItem(100);
    }, 0);
-  }, true);
+  }, {capture: true});
  dropdown.addEventListener('click', (e: MouseEvent) => {
    if (isMenuVisible() &&
      ignoreClickPreVisible !== 2 && // dropdown is switch from invisible to visible
@@ -277,7 +277,7 @@ function attachDomEvents(dropdown: HTMLElement, focusable: HTMLElement, menu: HT
      e.stopPropagation(); // if the dropdown menu has been opened by focus, do not trigger the next click event again
    }
    ignoreClickPreEvents = ignoreClickPreVisible = 0;
-  }, true);
+  }, {capture: true});
 }

 // Although Fomantic Dropdown supports "hideDividers", it doesn't really work with our "scoped dividers"
--- a/web_src/js/modules/fomantic/tab.ts
+++ b/web_src/js/modules/fomantic/tab.ts
@@ -8,7 +8,7 @@ export function initTabSwitcher(tabItemContainer: Element) {
  for (const elItem of tabItems) {
    const tabName = elItem.getAttribute('data-tab')!;
    elItem.addEventListener('click', () => {
-      const elPanel = document.querySelector(`.ui.tab[data-tab="${tabName}"]`)!;
+      const elPanel = document.querySelector(`.ui.tab[data-tab="${CSS.escape(tabName)}"]`)!;
      queryElemSiblings(elPanel, '.ui.tab', (el) => el.classList.remove('active'));
      queryElemSiblings(elItem, '.item[data-tab]', (el) => el.classList.remove('active'));
      elItem.classList.add('active');
--- a/web_src/js/modules/tippy.ts
+++ b/web_src/js/modules/tippy.ts
@@ -89,7 +89,7 @@ function attachTooltip(target: Element, content: Content | null = null): Instanc
    allowHTML: target.getAttribute('data-tooltip-render') === 'html',
    placement: target.getAttribute('data-tooltip-placement') as Placement || 'top-start',
    followCursor: target.getAttribute('data-tooltip-follow-cursor') as Props['followCursor'] || false,
-    ...(target.getAttribute('data-tooltip-interactive') === 'true' ? {interactive: true, aria: {content: 'describedby', expanded: false}} : {}),
+    ...((target.getAttribute('data-tooltip-interactive') === 'true') && {interactive: true, aria: {content: 'describedby', expanded: false}}),
  };

  if (!target._tippy) {
--- a/web_src/js/modules/toast.ts
+++ b/web_src/js/modules/toast.ts
@@ -45,7 +45,7 @@ type ToastifyElement = HTMLElement & {_giteaToastifyInstance?: Toast};
 /** See https://github.com/apvarun/toastify-js#api for options */
 function showToast(message: string, level: Intent, {gravity, position, duration, useHtmlBody, preventDuplicates = true, ...other}: ToastOpts = {}): Toast | null {
  const parent = document.querySelector('.ui.dimmer.active') ?? document.body;
-  const duplicateKey = preventDuplicates ? (preventDuplicates === true ? `${level}-${message}` : preventDuplicates) : '';
+  const duplicateKey = preventDuplicates ? (typeof preventDuplicates === 'string' ? preventDuplicates : `${level}-${message}`) : '';

  // prevent showing duplicate toasts with the same level and message, and give visual feedback for end users
  if (preventDuplicates) {
--- a/web_src/js/modules/worker.ts
+++ b/web_src/js/modules/worker.ts
@@ -50,7 +50,7 @@ export class UserEventsSharedWorker {
        //     * in this case, the logout fetch call already completes and has sent the "logout" message to the worker
        //   * there can be a data-race between the fetch call's redirection and the "logout" message from the worker
        //     * the fetch call's logout redirection should always win over the worker message, because it might have a custom location
-        setTimeout(() => { window.location.href = `${appSubUrl}/` }, 1000);
+        setTimeout(() => { window.location.assign(`${appSubUrl}/`) }, 1000);
      } else if (event.data.type === 'close') {
        this.sharedWorker.port.postMessage({type: 'close'});
        this.sharedWorker.port.close();
--- a/web_src/js/render/plugins/inplace-pdf-viewer.ts
+++ b/web_src/js/render/plugins/inplace-pdf-viewer.ts
@@ -4,9 +4,7 @@ export function newInplacePluginPdfViewer(): InplaceRenderPlugin {
  return {
    name: 'pdf-viewer',

-    canHandle(filename: string, _mimeType: string): boolean {
-      return filename.toLowerCase().endsWith('.pdf');
-    },
+    canHandle: (filename: string, _mimeType: string): boolean => filename.toLowerCase().endsWith('.pdf'),

    async render(container: HTMLElement, fileUrl: string): Promise<void> {
      const PDFObject = await import('pdfobject');
--- a/web_src/js/utils/dom.ts
+++ b/web_src/js/utils/dom.ts
@@ -9,8 +9,8 @@ type ElementsCallback<T extends Element> = (el: T) => Promisable<any>;
 type ElementsCallbackWithArgs = (el: Element, ...args: any[]) => Promisable<any>;

 function elementsCall(el: ElementArg, func: ElementsCallbackWithArgs, ...args: any[]): ArrayLikeIterable<Element> {
-  if (typeof el === 'string' || el instanceof String) {
-    el = document.querySelectorAll(el as string);
+  if (typeof el === 'string') {
+    el = document.querySelectorAll(el);
  }
  if (el instanceof Node) {
    func(el, ...args);
--- a/web_src/js/utils/match.ts
+++ b/web_src/js/utils/match.ts
@@ -8,7 +8,7 @@ import type {Issue, Mention} from '../types.ts';
 const maxMatches = 6;

 function sortAndReduce<T>(map: Map<T, number>): T[] {
-  const sortedMap = new Map(Array.from(map.entries()).sort((a, b) => a[1] - b[1]));
+  const sortedMap = new Map(Array.from(map).sort((a, b) => a[1] - b[1]));
  return Array.from(sortedMap.keys()).slice(0, maxMatches);
 }

--- a/web_src/js/utils/testhelper.ts
+++ b/web_src/js/utils/testhelper.ts
@@ -10,11 +10,11 @@ export function dedent(str: string) {
  const match = str.match(/^[ \t]*(?=\S)/gm);
  if (!match) return str;

-  let minIndent = Number.POSITIVE_INFINITY;
+  let minIndent = Infinity;
  for (const indent of match) {
    minIndent = Math.min(minIndent, indent.length);
  }
-  if (minIndent === 0 || minIndent === Number.POSITIVE_INFINITY) {
+  if (minIndent === 0 || minIndent === Infinity) {
    return str;
  }

--- a/web_src/js/utils/time.ts
+++ b/web_src/js/utils/time.ts
@@ -37,7 +37,7 @@ export function firstStartDateAfterDate(inputDate: Date): number {
  }
  const dayOfWeek = inputDate.getUTCDay();
  const daysUntilSunday = 7 - dayOfWeek;
-  const resultDate = new Date(inputDate.getTime());
+  const resultDate = new Date(inputDate);
  resultDate.setUTCDate(resultDate.getUTCDate() + daysUntilSunday);
  return resultDate.valueOf();
 }
--- a/web_src/js/webcomponents/overflow-menu.ts
+++ b/web_src/js/webcomponents/overflow-menu.ts
@@ -21,7 +21,7 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
    this.popup.style.display = '';
    this.button!.setAttribute('aria-expanded', 'true');
    setTimeout(() => this.popup.focus(), 0);
-    document.addEventListener('click', this.onClickOutside, true);
+    document.addEventListener('click', this.onClickOutside, {capture: true});
  }

  hidePopup() {
@@ -125,7 +125,7 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
      const itemRight = item.offsetLeft + item.offsetWidth;
      if (menuRight - itemRight < 38) { // roughly the width of .overflow-menu-button with some extra space
        const onlyLastItem = idx === menuItems.length - 1 && this.overflowItems.length === 0;
-        const lastItemFit = onlyLastItem && menuRight - itemRight > 0;
+        const lastItemFit = onlyLastItem && menuRight > itemRight;
        const moveToPopup = !onlyLastItem || !lastItemFit;
        if (moveToPopup) this.overflowItems.push(item);
      }