mirrors/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-31 20:58:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(repo): prevent double-write redirect collisions on dependency errors, fix ui (#38627) (#38628)

Browse Source 
Backport #38627

Co-authored-by: Sudhanshu Singh <sudhanshuwriterblc@gmail.com>
This commit is contained in:
wxiaoguang
2026-07-25 23:48:56 +08:00
committed by GitHub
parent d141dc729c
commit a54324e2b7
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
routers/web/repo/issue_dependency.go
View File

@@ -35,7 +35,11 @@ func AddDependency(ctx *context.Context) {
}
// Redirect
defer ctx.Redirect(issue.Link())
defer func() {
if !ctx.Written() {
ctx.Redirect(issue.Link())
}
}()
// Dependency
dep, err := issues_model.GetIssueByID(ctx, depID)
@@ -152,6 +156,7 @@ func RemoveDependency(ctx *context.Context) {
if err = issues_model.RemoveIssueDependency(ctx, ctx.Doer, issue, dep, depType); err != nil {
if issues_model.IsErrDependencyNotExists(err) {
ctx.Flash.Error(ctx.Tr("repo.issues.dependency.add_error_dep_not_exist"))
ctx.Redirect(issue.Link())
return
}
ctx.ServerError("RemoveIssueDependency", err)

4
web_src/css/repo.css
View File

@@ -645,6 +645,10 @@ td .commit-summary {
width: 100%;
}
.repository.view.issue .ui.depending .item.dependency {
display: flex;
}
.repository.view.issue .ui.depending .item.is-closed .issue-dependency-title {
text-decoration: line-through;
}