mirrors/imgui
1
0
Fork 0
mirror of https://github.com/ocornut/imgui.git synced 2026-07-16 22:21:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tables: validate ini settings column count. (#9472)

Browse Source 
+ Amend with comment by ocornut.
This commit is contained in:
ShiroKSH
2026-07-13 21:34:14 +03:00
committed by ocornut
parent addbfa5021
commit 0720d59bb7
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
imgui_tables.cpp
View File

@@ -4165,9 +4165,12 @@ static void TableSettingsHandler_ApplyAll(ImGuiContext* ctx, ImGuiSettingsHandle
static void* TableSettingsHandler_ReadOpen(ImGuiContext*, ImGuiSettingsHandler*, const char* name)
{
// FIXME: As topology changes are allowed, strictly speaking a >= IMGUI_TABLE_MAX_COLUMNS tables stored in .ini file
// that was emitted with a higher max count could still be meaningful in some unlikely cases.
// We might want to use another MAX defined as (1<<(sizeof(ImGuiTableColumnIdx)*8-1))-1.
ImGuiID id = 0;
int columns_count = 0;
if (sscanf(name, "0x%08X,%d", &id, &columns_count) < 2)
if (sscanf(name, "0x%08X,%d", &id, &columns_count) < 2 || columns_count <= 0 || columns_count >= IMGUI_TABLE_MAX_COLUMNS)
return NULL;
return ImGui::TableSettingsCreate(id, columns_count);
}