Merge pull request #40291 from zeertzjq/vim-9.2.0661

vim-patch:9.2.{0661,0662,0663}
This commit is contained in:
zeertzjq
2026-06-17 15:36:44 +08:00
committed by GitHub
4 changed files with 51 additions and 4 deletions

View File

@@ -1,7 +1,7 @@
" Creator: Charles E Campbell
" Previous Maintainer: Luca Saccarola <github.e41mv@aleeas.com>
" Maintainer: This runtime file is looking for a new maintainer.
" Last Change: 2026 Jun 10
" Last Change: 2026 Jun 16
" Copyright: Copyright (C) 2016 Charles E. Campbell {{{1
" Permission is hereby granted to use and distribute this code,
" with or without modifications, provided that this copyright
@@ -3083,7 +3083,7 @@ function s:NetrwBrowse(islocal,dirname)
elseif !a:islocal && dirname !~ '[\/]$' && dirname !~ '^"'
" s:NetrwBrowse : remote regular file handler {{{3
if bufname(dirname) != ""
exe "NetrwKeepj b ".bufname(dirname)
exe "NetrwKeepj b ".fnameescape(bufname(dirname))
else
" attempt transfer of remote regular file
@@ -8804,7 +8804,7 @@ function s:NetrwLocalRmFile(path, fname, all)
call netrw#msg#Notify('ERROR', printf("unable to delete <%s>!", rmfile))
else
" Remove file only if there are no pending changes
execute printf('silent! bwipeout %s', rmfile)
execute printf('silent! bwipeout %s', fnameescape(rmfile))
endif
elseif dir && (all || empty(ok))

View File

@@ -3566,7 +3566,7 @@ static linenr_T dump_prefixes(slang_T *slang, char *word, char *pat, Direction *
}
}
}
} else {
} else if (depth < MAXWLEN - 1) {
// Normal char, go one level deeper.
prefix[depth++] = (char)c;
arridx[depth] = idxs[n];

View File

@@ -856,4 +856,24 @@ func Test_netrw_injection()
endtry
endfunc
" Deleting a file whose name contains an Ex command separator must not let the
" name inject commands into the :execute in s:NetrwLocalRmFile().
func Test_netrw_local_rm_injection()
CheckUnix
let dir = getcwd() . '/Xnetrwrm'
let fname = "x|let g:injected = 1"
call mkdir(dir, 'pR')
call writefile([], dir . '/' . fname)
try
call netrw#Call('NetrwLocalRmFile', dir, fname, 1)
call assert_false(exists('g:injected'), 'filename must not inject Ex commands')
" The file is removed before the sink, so its absence also confirms the
" vulnerable code path was actually exercised (not skipped on an error).
call assert_false(filereadable(dir . '/' . fname), 'crafted file must be deleted')
finally
call delete(dir . '/' . fname)
unlet! g:injected
endtry
endfunc
" vim:ts=8 sts=2 sw=2 et

View File

@@ -1592,4 +1592,31 @@ func Test_suggest_spell_restore()
bwipe!
endfunc
" A crafted .spl with a self-referential BY_INDEX node in the PREFIXTREE drove
" dump_prefixes() past its MAXWLEN-sized depth arrays (stack out-of-bounds
" write). The tree parses cleanly (shared refs aren't recursed); the walk
" happens on :spelldump. Reaching the assert means no OOB. Same class as the
" tree_count_words() fix (9.2.0653).
func Test_spelldump_prefixtree_overflow()
CheckUnix
call mkdir('Xrtp/spell', 'pR')
" VIMspell + v50, SN_PREFCOND(prefixcnt=1), SN_END,
" LWORDTREE word "a" with affixID=1 (so dump_prefixes runs),
" empty KWORDTREE, PREFIXTREE child BY_INDEX -> nodeidx 0 (self-cycle), 'A'
let spl = eval('0z56494D7370656C6C32030000000003000100FF00000004'
\ .. '0161010220010000000000000002010100000041')
call writefile(spl, 'Xrtp/spell/xx.utf-8.spl', 'b')
new
set runtimepath+=./Xrtp
set spelllang=xx
set spell
spelldump
call assert_true(line('$') > 1)
set spell& spelllang& runtimepath&
bwipe!
bwipe!
endfunc
" vim: shiftwidth=2 sts=2 expandtab