mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-17 14:41:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

tui:cursor_goto(): remove dead code #9952

Browse Source 
fix #9918
ref dbc25f5a87

Before 7ede14d191 the UGRID_FOREACH_CELL loop was never entered,
because it expanded to an always-false condition.
From build/src/nvim/auto/tui/tui.i:
    do {
      UCell *row_cells = (grid)->cells[grid->row];
      for (int col = grid->col; col < col; col++) {
        UCell *cell = row_cells + col;
        (void)(cell);
        {
          print_cell(ui, cell);
        };
      }
    } while (0);

After 7ede14d191 issue #9918 was reported.

    $ ./build/bin/nvim -Nu NONE +'colo evening'
    :h<tab>  " causes cursor to change colors

Since the code was dead before 7ede14d191, just remove it.
This commit is contained in:
Justin M. Keyes
2019-04-28 16:19:36 +02:00
committed by GitHub
parent fbd6666a06
commit 33b20ce7de
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/nvim/tui/tui.c
View File

@@ -704,14 +704,6 @@ static void cursor_goto(UI *ui, int row, int col)
// even less expensive than using BSes or CUB.
unibi_out(ui, unibi_carriage_return);
ugrid_goto(grid, grid->row, 0);
} else if (col > grid->col) {
int n = col - grid->col;
if (n <= (row == grid->row ? 4 : 2)
&& cheap_to_print(ui, grid->row, grid->col, n)) {
UGRID_FOREACH_CELL(grid, grid->row, grid->col, col, {
print_cell(ui, cell);
});
}
}
if (row == grid->row) {
if (col < grid->col