mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-05 19:08:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(vim.system): improve error message when cwd does not exist

Browse Source 
Problem:
vim.uv.spawn will emit ENOENT for either when the cmd or cwd do not
exist and does not tell you which.

Solution:
If an error occurs, check if cwd was supplied and included in the error
message if it does not exist.

(cherry picked from commit 532610388b)
This commit is contained in:
Lewis Russell
2025-04-29 10:48:18 +01:00
committed by github-actions[bot]
parent 4cb2b19197
commit 3a0d37681f
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
runtime/lua/vim/_system.lua
View File

@@ -245,7 +245,13 @@ local function spawn(cmd, opts, on_exit, on_error)
local handle, pid_or_err = uv.spawn(cmd, opts, on_exit)
if not handle then
on_error()
error(('%s: "%s"'):format(pid_or_err, cmd))
if opts.cwd and not uv.fs_stat(opts.cwd) then
error(("%s (cwd): '%s'"):format(pid_or_err, opts.cwd))
elseif vim.fn.executable(cmd) == 0 then
error(("%s (cmd): '%s'"):format(pid_or_err, cmd))
else
error(pid_or_err)
end
end
return handle, pid_or_err --[[@as integer]]
end

7
test/functional/lua/system_spec.lua
View File

@@ -55,9 +55,14 @@ describe('vim.system', function()
describe('(' .. name .. ')', function()
it('failure modes', function()
t.matches(
'ENOENT%: no such file .*: "non%-existent%-cmd"',
"ENOENT%: no such file .* %(cmd%): 'non%-existent%-cmd'",
t.pcall_err(system, { 'non-existent-cmd', 'arg1', 'arg2' }, { text = true })
)
t.matches(
"ENOENT%: no such file .* %(cwd%): 'non%-existent%-cwd'",
t.pcall_err(system, { 'echo', 'hello' }, { cwd = 'non-existent-cwd', text = true })
)
end)
it('can run simple commands', function()