mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-08-14 03:04:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.2.0953: insert completion code can be improved

Browse Source 
Problem:  The duplicate-check hashtab in insexpand.c has comments that
          do not add anything to what the code says (after v9.2.0909).
Solution: Drop the redundant comments.

related: vim/vim#20926
closes:  vim/vim#21027

4dde4afa1d

Co-authored-by: Hirohito Higashi <h.east.727@gmail.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
zeertzjq
2026-08-13 07:46:22 +08:00
parent 39dc19bab4
commit 7525e87f10
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/nvim/insexpand.c
View File

@@ -228,11 +228,9 @@ static compl_T *compl_old_match = NULL;
static compl_T *compl_preselect_match = NULL;
/// Hashtab with the strings of the matches in the list above, except the
/// original-text entries. Used to make the duplicate check O(1) instead of
/// a scan of the whole list. Each entry owns a copy of the string and
/// counts the matches with that string, so that when matches were added
/// with "adup" the entry remains until the last match with the string is
/// removed.
/// original-text entries. Each entry owns a copy of the string and counts
/// the matches with that string, so that when matches were added with "adup"
/// the entry remains until the last match with the string is removed.
typedef struct {
int cse_count; // number of matches with this string
char cse_str[]; // the string
@@ -244,8 +242,7 @@ typedef struct {
static hashtab_T compl_strings_ht;
/// Count the string of a new match in the duplicate-check hashtab.
/// "hash" is the hash of "str" when it is not zero, saving hashing the
/// string again.
/// "hash" is the hash of "str" when it is not zero.
static void compl_strings_add(const char *str, size_t len, hash_T hash)
{
if (compl_strings_ht.ht_array == NULL) {
@@ -1008,8 +1005,7 @@ static int ins_compl_add(char *const str, int len, char *const fname, char *cons
// If the same match is already present, don't add it.
if (compl_first_match != NULL && !adup && compl_strings_ht.ht_used > 0) {
// Use a stack buffer for the NUL-terminated key when it fits, so
// that rejecting a duplicate does not allocate memory.
// The key must be NUL terminated.
char keybuf[128];
char *key;
if (len < (int)sizeof(keybuf)) {