mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-31 04:39:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: unreliable "put command . register special … ring the bell" #40812

Browse Source 
Problem:

    FAILED   …/put_spec.lua:894: …/put_spec.lua @ 898: put command . register special tests should ring the bell when deleting if not appropriate
    …/put_spec.lua:894: …/put_spec.lua:898: Bell was not rung after action

    Snapshot:
    screen:expect([[
      ^ine of words 1                                       |
      Line of words 2                                      |
      {1:~                                                    }|*4
      {3:[No Name] [+]                                        }|
                                                           |
      {1:~                                                    }|*4
      {UNKNOWN_HL_ID(4):[No Name]                                            }|
      {UNKNOWN_HL_ID(1):                                                     }|
    ]])
    stack traceback:
    …/ui/screen.lua:917: in function '_wait'
    …/ui/screen.lua:540: in function 'expect'
    …/editor/put_spec.lua:894: in function 'bell_test'
    …/editor/put_spec.lua:940: in function <…/editor/put_spec.lua:932>

Analysis:
The bell was asserted via the UI 'bell' event (screen.bell), but
vim_beep() rate-limits that to 3 per 500ms. These tests share one
long-lived session, so beeps from earlier tests could exhaust the window
and drop the asserted beep.

Solution:
Use assert_beeps()/assert_nobeep(), which check called_vim_beep (set
before the rate-limit gate).
This commit is contained in:
Justin M. Keyes
2026-07-18 07:48:36 -04:00
committed by GitHub
parent b2bb60d70a
commit 99a16121d4
1 changed files with 10 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
test/functional/editor/put_spec.lua
View File

@@ -1,6 +1,5 @@
local t = require('test.testutil')
local n = require('test.functional.testnvim')()
local Screen = require('test.functional.ui.screen')
local clear = n.clear
local insert = n.insert
@@ -879,54 +878,28 @@ describe('put command', function()
)
end)
local screen
setup(function()
screen = Screen.new()
end)
local function bell_test(actions, should_ring)
-- Asserts whether `keys` makes Nvim beep.
local function bell_test(keys, should_ring)
local cmd = 'normal! ' .. keys
if should_ring then
-- check bell is not set by nvim before the action
screen:sleep(50)
eq(0, fn.assert_beeps(cmd))
else
eq(0, fn.assert_nobeep(cmd))
end
t.ok(not screen.bell and not screen.visual_bell)
actions()
screen:expect {
condition = function()
if should_ring then
if not screen.bell and not screen.visual_bell then
error('Bell was not rung after action')
end
else
if screen.bell or screen.visual_bell then
error('Bell was rung after action')
end
end
end,
unchanged = not should_ring,
}
screen.bell = false
screen.visual_bell = false
end
it('should not ring the bell with gp at end of line', function()
bell_test(function()
feed('$".gp')
end)
bell_test('$".gp')
-- Even if the last character is a multibyte character.
reset()
fn.setline(1, 'helloม')
bell_test(function()
feed('$".gp')
end)
bell_test('$".gp')
end)
it('should not ring the bell with gp and end of file', function()
fn.setpos('.', { 0, 2, 1, 0 })
bell_test(function()
feed('$vl".gp')
end)
bell_test('$vl".gp')
end)
it('should ring the bell when deleting if not appropriate', function()
@@ -937,9 +910,7 @@ describe('put command', function()
expect([[
ine of words 1
Line of words 2]])
bell_test(function()
feed('".P')
end, true)
bell_test('".P', true)
end)
it('should restore cursor position after undo of ".p', function()