mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-03-31 04:42:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.2.0050: WM_SETFOCUS not handled immediately

Browse Source 
Problem:  In gvim on Windows, a certain problem can occur when the
          WM_SETFOCUS event sent after an external command is not
          processed immediately.
Solution: After posting WM_SETFOCUS, run the message loop to process it
          as quickly as possible (Muraoka Taro).

The problem is that Test_normal11_showcmd may fail when running the
test_normal.vim test.  Investigation revealed that the trigger was an
external command executed in the previous test,
Test_mouse_shape_after_failed_change, when two tests were executed
consecutively.  In gvim on Windows, a WM_SETFOCUS event will be sent
when an external command finishes executing.  This WM_SETFOCUS event is
not processed immediately, but rather by redraw, which is expected to
update showcmd. Because it is queued in typebuf at this time,
clear_showcmd(), which expects typebuf to be empty, cannot update
showcmd.

Also added a test that simulates the above problem.

closes: vim/vim#19167

c4a6fa3ead

Co-authored-by: Muraoka Taro <koron.kaoriya@gmail.com>
This commit is contained in:
zeertzjq
2026-03-29 22:29:58 +08:00
parent 527684c8dd
commit a89b9750ee
1 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/old/testdir/test_normal.vim
View File

@@ -4441,4 +4441,33 @@ func Test_pos_percentage_in_turkish_locale()
endtry
endfunc
" This test simulates the problem with gvim on Windows, observed when
" Test_normal11_showcmd in test_normal.vim is executed consecutively after
" Test_mouse_shape_after_failed_change.
"
" The problem occurred because WM_SETFOCUS was processed slowly, and typebuf
" was not empty when it should have been.
func Test_win32_gui_setfocus_prevent_showcmd()
if !has('win32') || !has('gui_running')
throw 'Skipped: Windows GUI regression test'
endif
" WM_SETFOCUS event occurs when finish to execute filter command in gvim
exe 'silent !echo foo'
set showcmd
10new
call setline(1, ['aaaaa', 'bbbbb', 'ccccc'])
call feedkeys("ggl\<C-V>lljj", 'xt')
" showcmd could not be updated because events originating from WM_SETFOCUS
" were stored in typebuf at here. clear_showcmd() executed from redraw,
" will not draw the selection information unless you are in visual mode and
" typebuf is empty.
redraw!
call assert_match('3x3$', Screenline(&lines))
call feedkeys("\<C-V>", 'xt')
endfunc
" vim: shiftwidth=2 sts=2 expandtab nofoldenable