mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-14 13:20:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(terminal/channel_spec): wait some time for shell to start (#38995)

Browse Source 
Problem:
The retry on Windows doesn't seem to actually work, as the test still
occasionally fails on Windows. Meanwhile the test can fail on Linux as
well:

FAILED   test/functional/terminal/channel_spec.lua @ 123: chansend sends lines to terminal channel in proper order
test/functional/terminal/channel_spec.lua:131: retry() attempts: 1
test/functional/terminal/channel_spec.lua:134: Failed to match any screen lines.
Expected (anywhere): "echo "hello".*echo "world""
Actual:
  |^ech$ o "hello"                                                                                      |
  |echo "world"                                                                                        |
  |hello                                                                                               |
  |$ world                                                                                             |
  |$                                                                                                   |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |                                                                                                    |
  |term://~/work/neovim/neovim/build/Xtest_xdg_terminal//32516:sh [-]                                  |
  |                                                                                                    |

Solution:
Use a wait before the chansend() instead.

(cherry picked from commit b081cc3aeb)
This commit is contained in:
zeertzjq
2026-04-13 06:59:47 +08:00
committed by github-actions[bot]
parent 5920a1d07f
commit aac55faa2c
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/functional/terminal/channel_spec.lua
View File

@@ -127,14 +127,12 @@ it('chansend sends lines to terminal channel in proper order', function()
local shells = is_os('win') and { 'cmd.exe', 'pwsh.exe -nop', 'powershell.exe -nop' } or { 'sh' }
for _, sh in ipairs(shells) do
command([[let id = jobstart(']] .. sh .. [[', {'term':v:true})]])
-- On Windows this may fail if the shell hasn't fully started yet, so retry.
t.retry(is_os('win') and 3 or 1, 5000, function()
command([[call chansend(id, ['echo "hello"', 'echo "world"', ''])]])
-- With PowerShell the command may be highlighted, so specify attr_ids = {}.
screen:expect { any = [[echo "hello".*echo "world"]], attr_ids = {}, timeout = 2000 }
end)
screen:sleep(50) -- Wait some time for the shell to start.
command([[call chansend(id, ['echo "hello"', 'echo "world"', ''])]])
-- With PowerShell the command may be highlighted, so specify attr_ids = {}.
screen:expect({ any = [[echo "hello".*echo "world"]], attr_ids = {} })
command('bdelete!')
screen:expect { any = '%[No Name%]' }
screen:expect({ any = '%[No Name%]' })
end
end)