mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-09 19:09:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.2.0771: dict_add_list() has inconsistent ownership on failure

Browse Source 
Problem:  dict_add_list() frees the passed list on failure path
          (when dict_add() fails) but not on the other (when
          dictitem_alloc() fails), so a caller cannot tell whether it
          still owns the list after a failure.
Solution: On failure leave the passed list untouched and owned by the
          caller; only take a reference on success.

related: vim/vim#20668

Supported by AI.

3ae1443d10

Co-authored-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq
2026-07-03 15:19:24 +08:00
parent 6f98352163
commit b856d5080d
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/nvim/eval/typval.c
View File

@@ -2494,11 +2494,14 @@ int tv_dict_add_list(dict_T *const d, const char *const key, const size_t key_le
item->di_tv.v_type = VAR_LIST;
item->di_tv.vval.v_list = list;
tv_list_ref(list);
if (tv_dict_add(d, item) == FAIL) {
// Detach "list" so tv_dict_item_free() does not unref it: on failure
// ownership stays with the caller.
item->di_tv.vval.v_list = NULL;
tv_dict_item_free(item);
return FAIL;
}
tv_list_ref(list);
return OK;
}