mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-21 16:41:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coverity): coverity/530031, coverity/530027 resource leaks #37916

Browse Source 
Fixed resource leak caused by overwriting lp->sl_midword by freeing
lp->sl_midword first.
This commit is contained in:
Jibril
2026-04-05 15:08:30 -04:00
committed by GitHub
parent 398ee83f4f
commit cfbac23235
2 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/spellfile.c
View File

@@ -699,6 +699,7 @@ slang_T *spell_load_file(char *fname, char *lang, slang_T *old_lp, bool silent)
break;
case SN_MIDWORD:
XFREE_CLEAR(lp->sl_midword);
lp->sl_midword = read_string(fd, (size_t)len); // <midword>
if (lp->sl_midword == NULL) {
goto endFAIL;
@@ -759,6 +760,7 @@ slang_T *spell_load_file(char *fname, char *lang, slang_T *old_lp, bool silent)
break;
case SN_SYLLABLE:
XFREE_CLEAR(lp->sl_syllable);
lp->sl_syllable = read_string(fd, (size_t)len); // <syllable>
if (lp->sl_syllable == NULL) {
goto endFAIL;

29
test/functional/core/spellfile_spec.lua
View File

@@ -141,5 +141,34 @@ describe('spellfile', function()
n.insert('abc')
eq("Vim(normal):E764: Option 'spellfile' is not set", exc_exec('normal! zg'))
end)
it('accepts overwrites on midword and syllable section, errors on memory leak', function()
api.nvim_set_option_value('runtimepath', testdir, {})
-- stylua: ignore
-- Set SN_MIDWORD and SN_SYLLABLE twice so the loader overwrites lp->sl_midword. Should
-- not leak memory.
write_file(testdir .. '/spell/en.ascii.spl',
spellheader
-- ┌ Section identifier (#SN_MIDWORD)
-- │ ┌ Section flags (#SNF_REQUIRED or zero)
-- │ │ ┌ Section length (4 bytes, MSB first)
.. '\002\001\000\000\000\003abc' -- SN_MIDWORD (midword = "abc")
.. '\002\001\000\000\000\003def' -- Overwrites SN_MIDWORD (midword = "def")
-- ┌ Section identifier (#SN_SYLLABLE)
-- │ ┌ Section flags (#SNF_REQUIRED or zero)
-- │ │ ┌ Section length (4 bytes, MSB first)
.. '\009\001\000\000\000\003ghi' -- SN_SYLLABLE (syllable = "ghi")
.. '\009\001\000\000\000\003jib' -- Overwrites SN_SYLLABLE (syllable = "jib")
.. '\255' -- End of sections marker
.. '\000\000\000\000' -- LWORDTREE len
.. '\000\000\000\000' -- KWORDTREE len
.. '\000\000\000\000' -- PREFIXTREE len
)
api.nvim_set_option_value('spelllang', 'en', {})
n.command('set spell') -- Should not error
eq(true, api.nvim_get_option_value('spell', {}))
end)
end)
end)