mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-03-28 03:12:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): nvim_set_hl crashes when url= key is passed

Browse Source 
Problem: Calling nvim_set_hl() with url= crashes because it tries to
free arena-owned string memory.

Solution: Remove the bad free and return a validation error instead.
This commit is contained in:
glepnir
2026-03-05 17:42:35 +08:00
committed by Christian Clason
parent bfc7bae421
commit d19dc6339d
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/api/vim.c
View File

@@ -184,8 +184,8 @@ void nvim_set_hl(uint64_t channel_id, Integer ns_id, String name, Dict(highlight
// Setting URLs directly through highlight attributes is not supported
if (HAS_KEY(val, highlight, url)) {
api_free_string(val->url);
val->url = NULL_STRING;
api_set_error(err, kErrorTypeValidation, "Invalid Key: 'url'");
return;
}
HlAttrs attrs = dict2hlattrs(val, true, &link_id, err);

4
test/functional/api/highlight_spec.lua
View File

@@ -254,6 +254,10 @@ describe('API: set highlight', function()
)
assert_alive()
end)
it("'url' is rejected with an error #38162", function()
eq("Invalid Key: 'url'", pcall_err(api.nvim_set_hl, 0, 'Test', { url = 'https://example.com' }))
assert_alive()
end)
end)
describe('API: get highlight', function()